Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
galene
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
galene
Commits
b7f39d32
Commit
b7f39d32
authored
Apr 27, 2021
by
Juliusz Chroboczek
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove last traces of onabort callback.
Everything now goes through onclose, both for up and down streams.
parent
cd673d01
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
10 deletions
+1
-10
README.FRONTEND
README.FRONTEND
+0
-1
static/protocol.js
static/protocol.js
+1
-9
No files found.
README.FRONTEND
View file @
b7f39d32
...
@@ -136,7 +136,6 @@ to push a stream to the server. Given a `MediaStream` called `localStream`
...
@@ -136,7 +136,6 @@ to push a stream to the server. Given a `MediaStream` called `localStream`
```javascript
```javascript
let stream = serverConnection.newUpStream();
let stream = serverConnection.newUpStream();
stream.onerror = ...;
stream.onerror = ...;
stream.onabort = ...;
stream.onstatus = ...;
stream.onstatus = ...;
localStream.getTracks().forEach(t => {
localStream.getTracks().forEach(t => {
c.labels[t.id] = t.kind;
c.labels[t.id] = t.kind;
...
...
static/protocol.js
View file @
b7f39d32
...
@@ -757,8 +757,7 @@ ServerConnection.prototype.gotAbort = function(id) {
...
@@ -757,8 +757,7 @@ ServerConnection.prototype.gotAbort = function(id) {
let
c
=
this
.
up
[
id
];
let
c
=
this
.
up
[
id
];
if
(
!
c
)
if
(
!
c
)
throw
new
Error
(
'
unknown up stream
'
);
throw
new
Error
(
'
unknown up stream
'
);
if
(
c
.
onabort
)
c
.
close
();
c
.
onabort
.
call
(
c
);
};
};
/**
/**
...
@@ -952,13 +951,6 @@ function Stream(sc, id, localId, pc, up) {
...
@@ -952,13 +951,6 @@ function Stream(sc, id, localId, pc, up) {
* @type{(this: Stream, status: string) => void}
* @type{(this: Stream, status: string) => void}
*/
*/
this
.
onstatus
=
null
;
this
.
onstatus
=
null
;
/**
* onabort is called when the server requested that an up stream be
* closed. It is the resposibility of the client to close the stream.
*
* @type{(this: Stream) => void}
*/
this
.
onabort
=
null
;
/**
/**
* onstats is called when we have new statistics about the connection
* onstats is called when we have new statistics about the connection
*
*
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment