branches_spec.rb 4.17 KB
Newer Older
Robert Schilling's avatar
Robert Schilling committed
1 2 3
require 'spec_helper'
require 'mime/types'

4
describe API::V3::Branches do
Rémy Coutable's avatar
Rémy Coutable committed
5 6 7 8 9
  set(:user) { create(:user) }
  set(:user2) { create(:user) }
  set(:project) { create(:project, :repository, creator: user) }
  set(:master) { create(:project_member, :master, user: user, project: project) }
  set(:guest) { create(:project_member, :guest, user: user2, project: project) }
Robert Schilling's avatar
Robert Schilling committed
10
  let!(:branch_name) { 'feature' }
11
  let!(:branch_sha) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' }
Robert Schilling's avatar
Robert Schilling committed
12
  let!(:branch_with_dot) { CreateBranchService.new(project, user).execute("with.1.2.3", "master") }
Robert Schilling's avatar
Robert Schilling committed
13 14 15 16 17 18 19

  describe "GET /projects/:id/repository/branches" do
    it "returns an array of project branches" do
      project.repository.expire_all_method_caches

      get v3_api("/projects/#{project.id}/repository/branches", user), per_page: 100

20
      expect(response).to have_gitlab_http_status(200)
Robert Schilling's avatar
Robert Schilling committed
21 22 23 24 25
      expect(json_response).to be_an Array
      branch_names = json_response.map { |x| x['name'] }
      expect(branch_names).to match_array(project.repository.branch_names)
    end
  end
26

Robert Schilling's avatar
Robert Schilling committed
27 28 29 30 31 32 33 34
  describe "DELETE /projects/:id/repository/branches/:branch" do
    before do
      allow_any_instance_of(Repository).to receive(:rm_branch).and_return(true)
    end

    it "removes branch" do
      delete v3_api("/projects/#{project.id}/repository/branches/#{branch_name}", user)

35
      expect(response).to have_gitlab_http_status(200)
Robert Schilling's avatar
Robert Schilling committed
36 37 38 39 40 41
      expect(json_response['branch_name']).to eq(branch_name)
    end

    it "removes a branch with dots in the branch name" do
      delete v3_api("/projects/#{project.id}/repository/branches/with.1.2.3", user)

42
      expect(response).to have_gitlab_http_status(200)
Robert Schilling's avatar
Robert Schilling committed
43 44 45 46 47
      expect(json_response['branch_name']).to eq("with.1.2.3")
    end

    it 'returns 404 if branch not exists' do
      delete v3_api("/projects/#{project.id}/repository/branches/foobar", user)
48
      expect(response).to have_gitlab_http_status(404)
Robert Schilling's avatar
Robert Schilling committed
49 50 51
    end
  end

52 53 54 55 56 57 58 59
  describe "DELETE /projects/:id/repository/merged_branches" do
    before do
      allow_any_instance_of(Repository).to receive(:rm_branch).and_return(true)
    end

    it 'returns 200' do
      delete v3_api("/projects/#{project.id}/repository/merged_branches", user)

60
      expect(response).to have_gitlab_http_status(200)
61 62 63
    end

    it 'returns a 403 error if guest' do
Robert Schilling's avatar
Robert Schilling committed
64
      delete v3_api("/projects/#{project.id}/repository/merged_branches", user2)
65

66
      expect(response).to have_gitlab_http_status(403)
67 68
    end
  end
69 70 71 72 73 74 75

  describe "POST /projects/:id/repository/branches" do
    it "creates a new branch" do
      post v3_api("/projects/#{project.id}/repository/branches", user),
           branch_name: 'feature1',
           ref: branch_sha

76
      expect(response).to have_gitlab_http_status(201)
77 78 79 80 81 82 83 84 85

      expect(json_response['name']).to eq('feature1')
      expect(json_response['commit']['id']).to eq(branch_sha)
    end

    it "denies for user without push access" do
      post v3_api("/projects/#{project.id}/repository/branches", user2),
           branch_name: branch_name,
           ref: branch_sha
86
      expect(response).to have_gitlab_http_status(403)
87 88 89 90 91 92
    end

    it 'returns 400 if branch name is invalid' do
      post v3_api("/projects/#{project.id}/repository/branches", user),
           branch_name: 'new design',
           ref: branch_sha
93
      expect(response).to have_gitlab_http_status(400)
94 95 96 97 98 99 100
      expect(json_response['message']).to eq('Branch name is invalid')
    end

    it 'returns 400 if branch already exists' do
      post v3_api("/projects/#{project.id}/repository/branches", user),
           branch_name: 'new_design1',
           ref: branch_sha
101
      expect(response).to have_gitlab_http_status(201)
102 103 104 105 106

      post v3_api("/projects/#{project.id}/repository/branches", user),
           branch_name: 'new_design1',
           ref: branch_sha

107
      expect(response).to have_gitlab_http_status(400)
108 109 110 111 112 113 114 115
      expect(json_response['message']).to eq('Branch already exists')
    end

    it 'returns 400 if ref name is invalid' do
      post v3_api("/projects/#{project.id}/repository/branches", user),
           branch_name: 'new_design3',
           ref: 'foo'

116
      expect(response).to have_gitlab_http_status(400)
117 118 119
      expect(json_response['message']).to eq('Invalid reference name')
    end
  end
Robert Schilling's avatar
Robert Schilling committed
120
end