user_spec.rb 85.9 KB
Newer Older
gitlabhq's avatar
gitlabhq committed
1 2
require 'spec_helper'

3
describe User do
4
  include ProjectForksHelper
5

6 7 8 9 10 11 12
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
13
    it { is_expected.to include_module(BlocksJsonSerialization) }
14 15
  end

16 17 18 19
  describe 'delegations' do
    it { is_expected.to delegate_method(:path).to(:namespace).with_prefix }
  end

20
  describe 'associations' do
21
    it { is_expected.to have_one(:namespace) }
22
    it { is_expected.to have_many(:snippets).dependent(:destroy) }
23 24 25
    it { is_expected.to have_many(:members) }
    it { is_expected.to have_many(:project_members) }
    it { is_expected.to have_many(:group_members) }
26 27
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
28
    it { is_expected.to have_many(:deploy_keys).dependent(:nullify) }
29
    it { is_expected.to have_many(:events).dependent(:destroy) }
30
    it { is_expected.to have_many(:issues).dependent(:destroy) }
31 32 33
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
34
    it { is_expected.to have_many(:spam_logs).dependent(:destroy) }
35
    it { is_expected.to have_many(:todos) }
36
    it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
37
    it { is_expected.to have_many(:triggers).dependent(:destroy) }
38 39
    it { is_expected.to have_many(:builds).dependent(:nullify) }
    it { is_expected.to have_many(:pipelines).dependent(:nullify) }
40
    it { is_expected.to have_many(:chat_names).dependent(:destroy) }
41
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
42
    it { is_expected.to have_many(:reported_abuse_reports).dependent(:destroy).class_name('AbuseReport') }
43
    it { is_expected.to have_many(:custom_attributes).class_name('UserCustomAttribute') }
44

45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70
    describe "#abuse_report" do
      let(:current_user) { create(:user) }
      let(:other_user) { create(:user) }

      it { is_expected.to have_one(:abuse_report) }

      it "refers to the abuse report whose user_id is the current user" do
        abuse_report = create(:abuse_report, reporter: other_user, user: current_user)

        expect(current_user.abuse_report).to eq(abuse_report)
      end

      it "does not refer to the abuse report whose reporter_id is the current user" do
        create(:abuse_report, reporter: current_user, user: other_user)

        expect(current_user.abuse_report).to be_nil
      end

      it "does not update the user_id of an abuse report when the user is updated" do
        abuse_report = create(:abuse_report, reporter: current_user, user: other_user)

        current_user.block

        expect(abuse_report.reload.user).to eq(other_user)
      end
    end
71 72 73 74

    describe '#group_members' do
      it 'does not include group memberships for which user is a requester' do
        user = create(:user)
75
        group = create(:group, :public, :access_requestable)
76 77 78 79 80 81 82 83 84
        group.request_access(user)

        expect(user.group_members).to be_empty
      end
    end

    describe '#project_members' do
      it 'does not include project memberships for which user is a requester' do
        user = create(:user)
85
        project = create(:project, :public, :access_requestable)
86 87 88 89 90
        project.request_access(user)

        expect(user.project_members).to be_empty
      end
    end
91 92 93
  end

  describe 'validations' do
94 95 96 97 98 99 100 101 102
    describe 'username' do
      it 'validates presence' do
        expect(subject).to validate_presence_of(:username)
      end

      it 'rejects blacklisted names' do
        user = build(:user, username: 'dashboard')

        expect(user).not_to be_valid
103
        expect(user.errors.messages[:username]).to eq ['dashboard is a reserved name']
104 105
      end

106 107 108 109 110 111 112 113 114 115 116 117
      it 'allows child names' do
        user = build(:user, username: 'avatar')

        expect(user).to be_valid
      end

      it 'allows wildcard names' do
        user = build(:user, username: 'blob')

        expect(user).to be_valid
      end

118 119 120 121 122 123 124 125 126 127
      context 'when username is changed' do
        let(:user) { build_stubbed(:user, username: 'old_path', namespace: build_stubbed(:namespace)) }

        it 'validates move_dir is allowed for the namespace' do
          expect(user.namespace).to receive(:any_project_has_container_registry_tags?).and_return(true)
          user.username = 'new_path'
          expect(user).to be_invalid
          expect(user.errors.messages[:username].first).to match('cannot be changed if a personal project has container registry tags')
        end
      end
128

129 130 131 132 133 134 135 136 137
      context 'when the username is in use by another user' do
        let(:username) { 'foo' }
        let!(:other_user) { create(:user, username: username) }

        it 'is invalid' do
          user = build(:user, username: username)

          expect(user).not_to be_valid
          expect(user.errors.full_messages).to eq(['Username has already been taken'])
138 139
        end
      end
140 141
    end

142 143 144 145 146 147 148 149 150 151
    it 'has a DB-level NOT NULL constraint on projects_limit' do
      user = create(:user)

      expect(user.persisted?).to eq(true)

      expect do
        user.update_columns(projects_limit: nil)
      end.to raise_error(ActiveRecord::StatementInvalid)
    end

152 153 154 155
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
156
    it { is_expected.not_to allow_value(Gitlab::Database::MAX_INT_VALUE + 1).for(:projects_limit) }
157

158
    it { is_expected.to validate_length_of(:bio).is_at_most(255) }
159

160 161 162
    it_behaves_like 'an object with email-formated attributes', :email do
      subject { build(:user) }
    end
163

164 165 166
    it_behaves_like 'an object with email-formated attributes', :public_email, :notification_email do
      subject { build(:user).tap { |user| user.emails << build(:email, email: email_value) } }
    end
167

168
    describe 'email' do
169
      context 'when no signup domains whitelisted' do
170
        before do
171
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return([])
172
        end
173

174 175 176 177 178 179
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

180
      context 'when a signup domain is whitelisted and subdomains are allowed' do
181
        before do
182
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com', '*.example.com'])
183
        end
184

185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

201
      context 'when a signup domain is whitelisted and subdomains are not allowed' do
202
        before do
203
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com'])
204
        end
205 206 207 208 209 210 211 212 213 214 215 216 217 218 219

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
220 221 222 223 224

        it 'accepts example@test.com when added by another user' do
          user = build(:user, email: "example@test.com", created_by_id: 1)
          expect(user).to be_valid
        end
225
      end
226

227 228 229 230 231 232
      context 'domain blacklist' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist_enabled?).and_return(true)
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['example.com'])
        end

233
        context 'when a signup domain is blacklisted' do
234 235 236 237 238 239 240 241 242
          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
243 244 245 246 247

          it 'accepts info@example.com when added by another user' do
            user = build(:user, email: 'info@example.com', created_by_id: 1)
            expect(user).to be_valid
          end
248 249
        end

250
        context 'when a signup domain is blacklisted but a wildcard subdomain is allowed' do
251 252
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['test.example.com'])
253
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['*.example.com'])
254 255
          end

256
          it 'gives priority to whitelist and allow info@test.example.com' do
257 258 259 260 261 262 263
            user = build(:user, email: 'info@test.example.com')
            expect(user).to be_valid
          end
        end

        context 'with both lists containing a domain' do
          before do
264
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['test.com'])
265 266 267 268 269 270 271 272 273 274 275 276 277 278
          end

          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end
      end

279 280 281 282 283 284
      context 'owns_notification_email' do
        it 'accepts temp_oauth_email emails' do
          user = build(:user, email: "temp-email-for-oauth@example.com")
          expect(user).to be_valid
        end
      end
285
    end
286 287 288 289 290 291 292
  end

  describe "scopes" do
    describe ".with_two_factor" do
      it "returns users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
293
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
294 295 296 297 298 299 300 301

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
302
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
303 304 305 306 307 308 309 310

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
311
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
312 313 314 315 316 317 318 319 320 321

        expect(users_with_two_factor).to eq([user_with_2fa.id])
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end
    end

    describe ".without_two_factor" do
      it "excludes users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
322
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
323 324 325 326 327 328 329 330

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
331
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
332 333 334 335 336 337 338 339

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
340
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
341 342 343 344 345

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end
    end
346 347 348 349 350 351 352 353 354 355

    describe '.todo_authors' do
      it 'filters users' do
        create :user
        user_2 = create :user
        user_3 = create :user
        current_user = create :user
        create(:todo, user: current_user, author: user_2, state: :done)
        create(:todo, user: current_user, author: user_3, state: :pending)

356 357
        expect(described_class.todo_authors(current_user.id, 'pending')).to eq [user_3]
        expect(described_class.todo_authors(current_user.id, 'done')).to eq [user_2]
358 359
      end
    end
gitlabhq's avatar
gitlabhq committed
360 361 362
  end

  describe "Respond to" do
363
    it { is_expected.to respond_to(:admin?) }
364
    it { is_expected.to respond_to(:name) }
Zeger-Jan van de Weg's avatar
Zeger-Jan van de Weg committed
365 366 367 368 369 370 371 372 373 374 375 376 377 378
    it { is_expected.to respond_to(:external?) }
  end

  describe 'before save hook' do
    context 'when saving an external user' do
      let(:user)          { create(:user) }
      let(:external_user) { create(:user, external: true) }

      it "sets other properties aswell" do
        expect(external_user.can_create_team).to be_falsey
        expect(external_user.can_create_group).to be_falsey
        expect(external_user.projects_limit).to be 0
      end
    end
379

380 381
    describe '#check_for_verified_email' do
      let(:user)      { create(:user) }
382 383
      let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user) }

384 385 386 387 388 389 390 391
      it 'allows a verfied secondary email to be used as the primary without needing reconfirmation' do
        user.update_attributes!(email: secondary.email)
        user.reload
        expect(user.email).to eq secondary.email
        expect(user.unconfirmed_email).to eq nil
        expect(user.confirmed?).to be_truthy
      end
    end
gitlabhq's avatar
gitlabhq committed
392 393
  end

394
  describe 'after commit hook' do
395 396 397 398 399 400 401 402 403 404 405 406 407
    describe '.update_invalid_gpg_signatures' do
      let(:user) do
        create(:user, email: 'tula.torphy@abshire.ca').tap do |user|
          user.skip_reconfirmation!
        end
      end

      it 'does nothing when the name is updated' do
        expect(user).not_to receive(:update_invalid_gpg_signatures)
        user.update_attributes!(name: 'Bette')
      end

      it 'synchronizes the gpg keys when the email is updated' do
408
        expect(user).to receive(:update_invalid_gpg_signatures).at_most(:twice)
409 410 411
        user.update_attributes!(email: 'shawnee.ritchie@denesik.com')
      end
    end
412 413 414 415 416 417 418 419 420 421 422 423

    describe '#update_emails_with_primary_email' do
      before do
        @user = create(:user, email: 'primary@example.com').tap do |user|
          user.skip_reconfirmation!
        end
        @secondary = create :email, email: 'secondary@example.com', user: @user
        @user.reload
      end

      it 'gets called when email updated' do
        expect(@user).to receive(:update_emails_with_primary_email)
424

425 426 427
        @user.update_attributes!(email: 'new_primary@example.com')
      end

428
      it 'adds old primary to secondary emails when secondary is a new email ' do
429 430
        @user.update_attributes!(email: 'new_primary@example.com')
        @user.reload
431

432 433
        expect(@user.emails.count).to eq 2
        expect(@user.emails.pluck(:email)).to match_array([@secondary.email, 'primary@example.com'])
434 435 436 437 438
      end

      it 'adds old primary to secondary emails if secondary is becoming a primary' do
        @user.update_attributes!(email: @secondary.email)
        @user.reload
439

440 441 442 443 444 445 446
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.email).to eq 'primary@example.com'
      end

      it 'transfers old confirmation values into new secondary' do
        @user.update_attributes!(email: @secondary.email)
        @user.reload
447

448 449 450 451
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.confirmed_at).not_to eq nil
      end
    end
452 453
  end

454
  describe '#update_tracked_fields!', :clean_gitlab_redis_shared_state do
455 456 457 458 459 460 461 462 463 464 465 466 467 468
    let(:request) { OpenStruct.new(remote_ip: "127.0.0.1") }
    let(:user) { create(:user) }

    it 'writes trackable attributes' do
      expect do
        user.update_tracked_fields!(request)
      end.to change { user.reload.current_sign_in_at }
    end

    it 'does not write trackable attributes when called a second time within the hour' do
      user.update_tracked_fields!(request)

      expect do
        user.update_tracked_fields!(request)
469 470 471 472 473 474 475 476 477 478 479
      end.not_to change { user.reload.current_sign_in_at }
    end

    it 'writes trackable attributes for a different user' do
      user2 = create(:user)

      user.update_tracked_fields!(request)

      expect do
        user2.update_tracked_fields!(request)
      end.to change { user2.reload.current_sign_in_at }
480
    end
481 482 483 484 485 486 487 488

    it 'does not write if the DB is in read-only mode' do
      expect(Gitlab::Database).to receive(:read_only?).and_return(true)

      expect do
        user.update_tracked_fields!(request)
      end.not_to change { user.reload.current_sign_in_at }
    end
489 490
  end

491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518
  shared_context 'user keys' do
    let(:user) { create(:user) }
    let!(:key) { create(:key, user: user) }
    let!(:deploy_key) { create(:deploy_key, user: user) }
  end

  describe '#keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored key, but not deploy_key' do
        expect(user.keys).to include key
        expect(user.keys).not_to include deploy_key
      end
    end
  end

  describe '#deploy_keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored deploy key, but not normal key' do
        expect(user.deploy_keys).to include deploy_key
        expect(user.deploy_keys).not_to include key
      end
    end
  end

519
  describe '#confirm' do
520 521 522
    before do
      allow_any_instance_of(ApplicationSetting).to receive(:send_user_confirmation_email).and_return(true)
    end
523

524 525 526 527 528 529 530
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
531
      user.confirm
532 533 534 535
      expect(user.confirmed?).to be_truthy
    end
  end

536 537 538 539 540 541 542 543
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

544
  describe '#generate_password' do
545
    it "does not generate password by default" do
546
      user = create(:user, password: 'abcdefghe')
547

548
      expect(user.password).to eq('abcdefghe')
549
    end
550 551
  end

552 553 554
  describe 'ensure incoming email token' do
    it 'has incoming email token' do
      user = create(:user)
555

556 557 558 559
      expect(user.incoming_email_token).not_to be_blank
    end
  end

560 561 562 563 564 565 566 567 568 569 570
  describe '#ensure_user_rights_and_limits' do
    describe 'with external user' do
      let(:user) { create(:user, external: true) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

        user.update_attributes(external: false)
      end

      it 'ensures correct rights and limits for user' do
571 572
        stub_config_setting(default_can_create_group: true)

573
        expect { user.update_attributes(external: false) }.to change { user.can_create_group }.to(true)
574
          .and change { user.projects_limit }.to(Gitlab::CurrentSettings.default_projects_limit)
575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593
      end
    end

    describe 'without external user' do
      let(:user) { create(:user, external: false) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

        user.update_attributes(external: true)
      end

      it 'ensures correct rights and limits for user' do
        expect { user.update_attributes(external: true) }.to change { user.can_create_group }.to(false)
          .and change { user.projects_limit }.to(0)
      end
    end
  end

594
  describe 'rss token' do
Alexis Reigel's avatar
Alexis Reigel committed
595 596 597
    it 'ensures an rss token on read' do
      user = create(:user, rss_token: nil)
      rss_token = user.rss_token
598

Alexis Reigel's avatar
Alexis Reigel committed
599 600
      expect(rss_token).not_to be_blank
      expect(user.reload.rss_token).to eq rss_token
601 602 603
    end
  end

604
  describe '#recently_sent_password_reset?' do
605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623
    it 'is false when reset_password_sent_at is nil' do
      user = build_stubbed(:user, reset_password_sent_at: nil)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is false when sent more than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: 5.minutes.ago)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is true when sent less than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: Time.now)

      expect(user.recently_sent_password_reset?).to eq true
    end
  end

624 625 626 627 628 629 630
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil
631
      expect(user.otp_grace_period_started_at).not_to be_nil
632 633 634 635 636 637 638 639

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
640
      expect(user.otp_grace_period_started_at).to be_nil
641 642 643
    end
  end

644 645
  describe 'projects' do
    before do
646
      @user = create(:user)
647

648 649
      @project = create(:project, namespace: @user.namespace)
      @project_2 = create(:project, group: create(:group)) do |project|
650 651
        project.add_master(@user)
      end
652
      @project_3 = create(:project, group: create(:group)) do |project|
653 654
        project.add_developer(@user)
      end
655 656
    end

657 658 659 660 661 662 663 664 665
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
666 667 668
  end

  describe 'groups' do
669 670 671
    let(:user) { create(:user) }
    let(:group) { create(:group) }

672
    before do
673
      group.add_owner(user)
674 675
    end

676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702
    it { expect(user.several_namespaces?).to be_truthy }
    it { expect(user.authorized_groups).to eq([group]) }
    it { expect(user.owned_groups).to eq([group]) }
    it { expect(user.namespaces).to contain_exactly(user.namespace, group) }
    it { expect(user.manageable_namespaces).to contain_exactly(user.namespace, group) }

    context 'with child groups', :nested_groups do
      let!(:subgroup) { create(:group, parent: group) }

      describe '#manageable_namespaces' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_namespaces).to contain_exactly(user.namespace, group, subgroup)
        end
      end

      describe '#manageable_groups' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end

        it 'does not include duplicates if a membership was added for the subgroup' do
          subgroup.add_owner(user)

          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end
      end
    end
703 704
  end

705 706 707 708
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
709 710
      @group = create :group
      @group.add_owner(@user)
711

712
      @group.add_user(@user2, GroupMember::OWNER)
713 714
    end

715
    it { expect(@user2.several_namespaces?).to be_truthy }
716 717
  end

718 719 720
  describe 'namespaced' do
    before do
      @user = create :user
721
      @project = create(:project, namespace: @user.namespace)
722 723
    end

724
    it { expect(@user.several_namespaces?).to be_falsey }
725
    it { expect(@user.namespaces).to eq([@user.namespace]) }
726 727 728 729 730
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

731
    it "blocks user" do
732
      user.block
733

734
      expect(user.blocked?).to be_truthy
735 736 737
    end
  end

738 739 740 741
  describe '.filter' do
    let(:user) { double }

    it 'filters by active users by default' do
742
      expect(described_class).to receive(:active).and_return([user])
743

744
      expect(described_class.filter(nil)).to include user
745 746
    end

747
    it 'filters by admins' do
748
      expect(described_class).to receive(:admins).and_return([user])
749

750
      expect(described_class.filter('admins')).to include user
751 752
    end

753
    it 'filters by blocked' do
754
      expect(described_class).to receive(:blocked).and_return([user])
755

756
      expect(described_class.filter('blocked')).to include user
757 758 759
    end

    it 'filters by two_factor_disabled' do
760
      expect(described_class).to receive(:without_two_factor).and_return([user])
761

762
      expect(described_class.filter('two_factor_disabled')).to include user
763 764 765
    end

    it 'filters by two_factor_enabled' do
766
      expect(described_class).to receive(:with_two_factor).and_return([user])
767

768
      expect(described_class.filter('two_factor_enabled')).to include user
769 770 771
    end

    it 'filters by wop' do
772
      expect(described_class).to receive(:without_projects).and_return([user])
773

774
      expect(described_class.filter('wop')).to include user
775
    end
776 777
  end

778
  describe '.without_projects' do
779
    let!(:project) { create(:project, :public, :access_requestable) }
780 781 782 783 784 785
    let!(:user) { create(:user) }
    let!(:user_without_project) { create(:user) }
    let!(:user_without_project2) { create(:user) }

    before do
      # add user to project
786
      project.add_master(user)
787 788 789 790 791 792 793 794

      # create invite to projet
      create(:project_member, :developer, project: project, invite_token: '1234', invite_email: 'inviteduser1@example.com')

      # create request to join project
      project.request_access(user_without_project2)
    end

795 796 797
    it { expect(described_class.without_projects).not_to include user }
    it { expect(described_class.without_projects).to include user_without_project }
    it { expect(described_class.without_projects).to include user_without_project2 }
798 799
  end

800 801 802
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
803

804
      it { expect(user.admin?).to be_falsey }
805 806 807 808
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
809
      it { expect(user.external).to be_falsey }
810
    end
811

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
812
    describe 'with defaults' do
813
      let(:user) { described_class.new }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
814

815
      it "applies defaults to user" do
816 817
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
818
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
Zeger-Jan van de Weg's avatar
Zeger-Jan van de Weg committed
819
        expect(user.external).to be_falsey
820 821 822
      end
    end

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
823
    describe 'with default overrides' do
824
      let(:user) { described_class.new(projects_limit: 123, can_create_group: false, can_create_team: true) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
825

826
      it "applies defaults to user" do
827 828
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
829
        expect(user.theme_id).to eq(1)
830
      end
831 832 833 834 835 836 837

      it 'does not undo projects_limit setting if it matches old DB default of 10' do
        # If the real default project limit is 10 then this test is worthless
        expect(Gitlab.config.gitlab.default_projects_limit).not_to eq(10)
        user = described_class.new(projects_limit: 10)
        expect(user.projects_limit).to eq(10)
      end
838
    end
839

840
    context 'when Gitlab::CurrentSettings.user_default_external is true' do
841 842 843 844 845
      before do
        stub_application_setting(user_default_external: true)
      end

      it "creates external user by default" do
846
        user = create(:user)
847 848

        expect(user.external).to be_truthy
849 850
        expect(user.can_create_group).to be_falsey
        expect(user.projects_limit).to be 0
851 852 853 854
      end

      describe 'with default overrides' do
        it "creates a non-external user" do
855
          user = create(:user, external: false)
856 857 858 859 860

          expect(user.external).to be_falsey
        end
      end
    end
861

862
    describe '#require_ssh_key?', :use_clean_rails_memory_store_caching do
863 864 865
      protocol_and_expectation = {
        'http' => false,
        'ssh' => true,
866
        '' => true
867 868 869 870 871 872 873 874 875
      }

      protocol_and_expectation.each do |protocol, expected|
        it "has correct require_ssh_key?" do
          stub_application_setting(enabled_git_access_protocol: protocol)
          user = build(:user)

          expect(user.require_ssh_key?).to eq(expected)
        end
876
      end
877 878 879 880 881 882

      it 'returns false when the user has 1 or more SSH keys' do
        key = create(:personal_key)

        expect(key.user.require_ssh_key?).to eq(false)
      end
883
    end
884
  end
885

886 887 888 889 890 891 892 893
  describe '.find_for_database_authentication' do
    it 'strips whitespace from login' do
      user = create(:user)

      expect(described_class.find_for_database_authentication({ login: " #{user.username} " })).to eq user
    end
  end

894
  describe '.find_by_any_email' do
895 896 897
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

898
      expect(described_class.find_by_any_email(user.email)).to eq user
899 900 901 902 903 904
    end

    it 'finds by secondary email' do
      email = create(:email, email: 'foo@example.com')
      user  = email.user

905
      expect(described_class.find_by_any_email(email.email)).to eq user
906 907 908
    end

    it 'returns nil when nothing found' do
909
      expect(described_class.find_by_any_email('')).to be_nil
910 911 912
    end
  end

913 914 915 916 917 918 919 920 921 922 923 924 925
  describe '.by_any_email' do
    it 'returns an ActiveRecord::Relation' do
      expect(described_class.by_any_email('foo@example.com'))
        .to be_a_kind_of(ActiveRecord::Relation)
    end

    it 'returns a relation of users' do
      user = create(:user)

      expect(described_class.by_any_email(user.email)).to eq([user])
    end
  end

926
  describe '.search' do
927 928
    let!(:user) { create(:user, name: 'user', username: 'usern', email: 'email@gmail.com') }
    let!(:user2) { create(:user, name: 'user name', username: 'username', email: 'someemail@gmail.com') }
929
    let!(:user3) { create(:user, name: 'us', username: 'se', email: 'foo@gmail.com') }
930

931 932 933 934
    describe 'name matching' do
      it 'returns users with a matching name with exact match first' do
        expect(described_class.search(user.name)).to eq([user, user2])
      end
935

936
      it 'returns users with a partially matching name' do
937
        expect(described_class.search(user.name[0..2])).to eq([user, user2])
938
      end
939

940 941 942
      it 'returns users with a matching name regardless of the casing' do
        expect(described_class.search(user2.name.upcase)).to eq([user2])
      end
943 944 945 946 947 948 949 950

      it 'returns users with a exact matching name shorter than 3 chars' do
        expect(described_class.search(user3.name)).to eq([user3])
      end

      it 'returns users with a exact matching name shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.name.upcase)).to eq([user3])
      end
951 952
    end

953 954
    describe 'email matching' do
      it 'returns users with a matching Email' do
955
        expect(described_class.search(user.email)).to eq([user])
956
      end
957

958 959
      it 'does not return users with a partially matching Email' do
        expect(described_class.search(user.email[0..2])).not_to include(user, user2)
960
      end
961

962 963 964
      it 'returns users with a matching Email regardless of the casing' do
        expect(described_class.search(user2.email.upcase)).to eq([user2])
      end
965 966
    end

967 968 969 970
    describe 'username matching' do
      it 'returns users with a matching username' do
        expect(described_class.search(user.username)).to eq([user, user2])
      end
971

972
      it 'returns users with a partially matching username' do
973
        expect(described_class.search(user.username[0..2])).to eq([user, user2])
974
      end
975

976 977 978
      it 'returns users with a matching username regardless of the casing' do
        expect(described_class.search(user2.username.upcase)).to eq([user2])
      end
979 980 981 982 983 984 985 986

      it 'returns users with a exact matching username shorter than 3 chars' do
        expect(described_class.search(user3.username)).to eq([user3])
      end

      it 'returns users with a exact matching username shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.username.upcase)).to eq([user3])
      end
987
    end
988 989 990 991 992 993 994 995

    it 'returns no matches for an empty string' do
      expect(described_class.search('')).to be_empty
    end

    it 'returns no matches for nil' do
      expect(described_class.search(nil)).to be_empty
    end
996 997 998
  end

  describe '.search_with_secondary_emails' do
Douwe Maan's avatar
Douwe Maan committed
999
    delegate :search_with_secondary_emails, to: :described_class
1000

1001 1002
    let!(:user) { create(:user, name: 'John Doe', username: 'john.doe', email: 'john.doe@example.com' ) }
    let!(:another_user) { create(:user, name: 'Albert Smith', username: 'albert.smith', email: 'albert.smith@example.com' ) }
1003 1004 1005
    let!(:email) do
      create(:email, user: another_user, email: 'alias@example.com')
    end
1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022

    it 'returns users with a matching name' do
      expect(search_with_secondary_emails(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(search_with_secondary_emails(user.name[0..2])).to eq([user])
    end

    it 'returns users with a matching name regardless of the casing' do
      expect(search_with_secondary_emails(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching email' do
      expect(search_with_secondary_emails(user.email)).to eq([user])
    end

1023 1024
    it 'does not return users with a partially matching email' do
      expect(search_with_secondary_emails(user.email[0..2])).not_to include([user])
1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046
    end

    it 'returns users with a matching email regardless of the casing' do
      expect(search_with_secondary_emails(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(search_with_secondary_emails(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(search_with_secondary_emails(user.username[0..2])).to eq([user])
    end

    it 'returns users with a matching username regardless of the casing' do
      expect(search_with_secondary_emails(user.username.upcase)).to eq([user])
    end

    it 'returns users with a matching whole secondary email' do
      expect(search_with_secondary_emails(email.email)).to eq([email.user])
    end

1047 1048
    it 'does not return users with a matching part of secondary email' do
      expect(search_with_secondary_emails(email.email[1..4])).not_to include([email.user])
1049
    end
1050 1051 1052 1053 1054 1055 1056 1057

    it 'returns no matches for an empty string' do
      expect(search_with_secondary_emails('')).to be_empty
    end

    it 'returns no matches for nil' do
      expect(search_with_secondary_emails(nil)).to be_empty
    end
1058 1059
  end

1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076
  describe '.find_by_ssh_key_id' do
    context 'using an existing SSH key ID' do
      let(:user) { create(:user) }
      let(:key) { create(:key, user: user) }

      it 'returns the corresponding User' do
        expect(described_class.find_by_ssh_key_id(key.id)).to eq(user)
      end
    end

    context 'using an invalid SSH key ID' do
      it 'returns nil' do
        expect(described_class.find_by_ssh_key_id(-1)).to be_nil
      end
    end
  end

1077 1078 1079 1080
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

1081
    it 'gets the correct user' do
1082 1083 1084 1085 1086 1087
      expect(described_class.by_login(user.email.upcase)).to eq user
      expect(described_class.by_login(user.email)).to eq user
      expect(described_class.by_login(username.downcase)).to eq user
      expect(described_class.by_login(username)).to eq user
      expect(described_class.by_login(nil)).to be_nil
      expect(described_class.by_login('')).to be_nil
1088 1089 1090
    end
  end

1091 1092 1093 1094 1095 1096 1097
  describe '.find_by_username' do
    it 'returns nil if not found' do
      expect(described_class.find_by_username('JohnDoe')).to be_nil
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1098

1099 1100 1101 1102
      expect(described_class.find_by_username('JOHNDOE')).to eq user
    end
  end

1103 1104
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
1105 1106
      expect { described_class.find_by_username!('JohnDoe') }
        .to raise_error(ActiveRecord::RecordNotFound)
1107 1108 1109 1110
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1111

1112 1113 1114 1115
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

1116 1117 1118 1119 1120 1121 1122
  describe '.find_by_full_path' do
    let!(:user) { create(:user) }

    context 'with a route matching the given path' do
      let!(:route) { user.namespace.route }

      it 'returns the user' do
1123
        expect(described_class.find_by_full_path(route.path)).to eq(user)
1124 1125 1126
      end

      it 'is case-insensitive' do
1127 1128
        expect(described_class.find_by_full_path(route.path.upcase)).to eq(user)
        expect(described_class.find_by_full_path(route.path.downcase)).to eq(user)
1129 1130 1131 1132 1133 1134 1135 1136
      end
    end

    context 'with a redirect route matching the given path' do
      let!(:redirect_route) { user.namespace.redirect_routes.create(path: 'foo') }

      context 'without the follow_redirects option' do
        it 'returns nil' do
1137
          expect(described_class.find_by_full_path(redirect_route.path)).to eq(nil)
1138 1139 1140 1141 1142
        end
      end

      context 'with the follow_redirects option set to true' do
        it 'returns the user' do
1143
          expect(described_class.find_by_full_path(redirect_route.path, follow_redirects: true)).to eq(user)
1144 1145 1146
        end

        it 'is case-insensitive' do
1147 1148
          expect(described_class.find_by_full_path(redirect_route.path.upcase, follow_redirects: true)).to eq(user)
          expect(described_class.find_by_full_path(redirect_route.path.downcase, follow_redirects: true)).to eq(user)
1149 1150 1151 1152 1153 1154 1155
        end
      end
    end

    context 'without a route or a redirect route matching the given path' do
      context 'without the follow_redirects option' do
        it 'returns nil' do
1156
          expect(described_class.find_by_full_path('unknown')).to eq(nil)
1157 1158 1159 1160
        end
      end
      context 'with the follow_redirects option set to true' do
        it 'returns nil' do
1161
          expect(described_class.find_by_full_path('unknown', follow_redirects: true)).to eq(nil)
1162 1163 1164 1165 1166
        end
      end
    end

    context 'with a group route matching the given path' do
1167 1168
      let!(:group) { create(:group, path: 'group_path') }

Michael Kozono's avatar
Michael Kozono committed
1169
      context 'when the group namespace has an owner_id (legacy data)' do
1170 1171 1172
        before do
          group.update!(owner_id: user.id)
        end
1173

Michael Kozono's avatar
Michael Kozono committed
1174
        it 'returns nil' do
1175
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
Michael Kozono's avatar
Michael Kozono committed
1176 1177 1178 1179 1180
        end
      end

      context 'when the group namespace does not have an owner_id' do
        it 'returns nil' do
1181
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
Michael Kozono's avatar
Michael Kozono committed
1182
        end
1183 1184 1185 1186
      end
    end
  end

1187
  describe 'all_ssh_keys' do
1188
    it { is_expected.to have_many(:keys).dependent(:destroy) }
1189

1190
    it "has all ssh keys" do
1191 1192 1193
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

1194
      expect(user.all_ssh_keys).to include(a_string_starting_with(key.key))
1195
    end
1196
  end
1197

1198
  describe '#avatar_type' do
1199 1200
    let(:user) { create(:user) }

1201
    it 'is true if avatar is image' do
1202
      user.update_attribute(:avatar, 'uploads/avatar.png')
1203

1204
      expect(user.avatar_type).to be_truthy
1205 1206
    end

1207
    it 'is false if avatar is html page' do
1208
      user.update_attribute(:avatar, 'uploads/avatar.html')
1209

1210
      expect(user.avatar_type).to eq(['file format is not supported. Please try one of the following supported formats: png, jpg, jpeg, gif, bmp, tiff'])
1211 1212
    end
  end
Jerome Dalbert's avatar
Jerome Dalbert committed
1213

1214 1215 1216 1217
  describe '#avatar_url' do
    let(:user) { create(:user, :with_avatar) }

    context 'when avatar file is uploaded' do
1218
      it 'shows correct avatar url' do
1219 1220
        expect(user.avatar_url).to eq(user.avatar.url)
        expect(user.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, user.avatar.url].join)
1221
      end
1222 1223 1224
    end
  end

1225 1226 1227 1228 1229 1230 1231
  describe '#all_emails' do
    let(:user) { create(:user) }

    it 'returns all emails' do
      email_confirmed   = create :email, user: user, confirmed_at: Time.now
      email_unconfirmed = create :email, user: user
      user.reload
1232

1233
      expect(user.all_emails).to match_array([user.email, email_unconfirmed.email, email_confirmed.email])
1234 1235 1236
    end
  end

1237
  describe '#verified_emails' do
1238 1239 1240
    let(:user) { create(:user) }

    it 'returns only confirmed emails' do
Brett Walker's avatar
Brett Walker committed
1241 1242
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1243
      user.reload
1244

1245
      expect(user.verified_emails).to match_array([user.email, email_confirmed.email])
1246 1247 1248 1249 1250 1251 1252
    end
  end

  describe '#verified_email?' do
    let(:user) { create(:user) }

    it 'returns true when the email is verified/confirmed' do
Brett Walker's avatar
Brett Walker committed
1253 1254
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1255 1256 1257
      user.reload

      expect(user.verified_email?(user.email)).to be_truthy
1258
      expect(user.verified_email?(email_confirmed.email.titlecase)).to be_truthy
1259 1260 1261 1262 1263 1264 1265 1266 1267 1268
    end

    it 'returns false when the email is not verified/confirmed' do
      email_unconfirmed = create :email, user: user
      user.reload

      expect(user.verified_email?(email_unconfirmed.email)).to be_falsy
    end
  end

1269
  describe '#requires_ldap_check?' do
1270
    let(:user) { described_class.new }
1271

1272 1273
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
1274
      allow(user).to receive(:ldap_user?).and_return(true)
1275
      user.last_credential_check_at = nil
1276

1277
      expect(user.requires_ldap_check?).to be_falsey
1278 1279
    end

1280
    context 'when LDAP is enabled' do
1281 1282 1283
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
1284

1285
      it 'is false for non-LDAP users' do
1286
        allow(user).to receive(:ldap_user?).and_return(false)
1287

1288
        expect(user.requires_ldap_check?).to be_falsey
1289 1290
      end

1291
      context 'and when the user is an LDAP user' do
1292 1293 1294
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
1295 1296 1297

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
1298

1299
          expect(user.requires_ldap_check?).to be_truthy
1300 1301 1302 1303
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
1304

1305
          expect(user.requires_ldap_check?).to be_truthy
1306
        end
1307 1308 1309 1310
      end
    end
  end

1311
  context 'ldap synchronized user' do
1312
    describe '#ldap_user?' do
1313 1314
      it 'is true if provider name starts with ldap' do
        user = create(:omniauth_user, provider: 'ldapmain')
1315

1316 1317
        expect(user.ldap_user?).to be_truthy
      end
1318

1319 1320
      it 'is false for other providers' do
        user = create(:omniauth_user, provider: 'other-provider')
1321

1322 1323 1324 1325 1326
        expect(user.ldap_user?).to be_falsey
      end

      it 'is false if no extern_uid is provided' do
        user = create(:omniauth_user, extern_uid: nil)
1327

1328 1329
        expect(user.ldap_user?).to be_falsey
      end
1330 1331
    end

1332
    describe '#ldap_identity' do
1333 1334
      it 'returns ldap identity' do
        user = create :omniauth_user
1335

1336 1337
        expect(user.ldap_identity.provider).not_to be_empty
      end
1338 1339
    end

1340 1341 1342 1343 1344
    describe '#ldap_block' do
      let(:user) { create(:omniauth_user, provider: 'ldapmain', name: 'John Smith') }

      it 'blocks user flaging the action caming from ldap' do
        user.ldap_block
1345

1346 1347 1348
        expect(user.blocked?).to be_truthy
        expect(user.ldap_blocked?).to be_truthy
      end
1349 1350 1351
    end
  end

Jerome Dalbert's avatar
Jerome Dalbert committed
1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
1391

Jerome Dalbert's avatar
Jerome Dalbert committed
1392 1393
      expect(user.short_website_url).to eq 'test.com'
    end
1394
  end
Ciro Santilli's avatar
Ciro Santilli committed
1395

1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407
  describe '#sanitize_attrs' do
    let(:user) { build(:user, name: 'test & user', skype: 'test&user') }

    it 'encodes HTML entities in the Skype attribute' do
      expect { user.sanitize_attrs }.to change { user.skype }.to('test&amp;user')
    end

    it 'does not encode HTML entities in the name attribute' do
      expect { user.sanitize_attrs }.not_to change { user.name }
    end
  end

1408 1409
  describe '#starred?' do
    it 'determines if user starred a project' do
1410
      user = create :user
1411 1412
      project1 = create(:project, :public)
      project2 = create(:project, :public)
1413

1414 1415
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1416 1417

      star1 = UsersStarProject.create!(project: project1, user: user)
1418

1419 1420
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
1421 1422

      star2 = UsersStarProject.create!(project: project2, user: user)
1423

1424 1425
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
1426 1427

      star1.destroy
1428

1429 1430
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
1431 1432

      star2.destroy
1433

1434 1435
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1436 1437 1438
    end
  end

1439 1440
  describe '#toggle_star' do
    it 'toggles stars' do
Ciro Santilli's avatar
Ciro Santilli committed
1441
      user = create :user
1442
      project = create(:project, :public)
Ciro Santilli's avatar
Ciro Santilli committed
1443

1444
      expect(user.starred?(project)).to be_falsey
1445

Ciro Santilli's avatar
Ciro Santilli committed
1446
      user.toggle_star(project)
1447

1448
      expect(user.starred?(project)).to be_truthy
1449

Ciro Santilli's avatar
Ciro Santilli committed
1450
      user.toggle_star(project)
1451

1452
      expect(user.starred?(project)).to be_falsey
Ciro Santilli's avatar
Ciro Santilli committed
1453 1454
    end
  end
Valery Sizov's avatar
Valery Sizov committed
1455

1456
  describe '#sort_by_attribute' do
Valery Sizov's avatar
Valery Sizov committed
1457
    before do
1458
      described_class.delete_all
1459 1460 1461
      @user = create :user, created_at: Date.today, current_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, current_sign_in_at: Date.today - 1, name: 'Omega'
      @user2 = create :user, created_at: Date.today - 2, name: 'Beta'
Valery Sizov's avatar
Valery Sizov committed
1462
    end
1463

1464
    context 'when sort by recent_sign_in' do
1465
      let(:users) { described_class.sort_by_attribute('recent_sign_in') }
1466 1467 1468 1469

      it 'sorts users by recent sign-in time' do
        expect(users.first).to eq(@user)
        expect(users.second).to eq(@user1)
1470 1471 1472
      end

      it 'pushes users who never signed in to the end' do
1473
        expect(users.third).to eq(@user2)
1474
      end
Valery Sizov's avatar
Valery Sizov committed
1475 1476
    end

1477
    context 'when sort by oldest_sign_in' do
1478
      let(:users) { described_class.sort_by_attribute('oldest_sign_in') }
1479

1480
      it 'sorts users by the oldest sign-in time' do
1481 1482
        expect(users.first).to eq(@user1)
        expect(users.second).to eq(@user)
1483 1484 1485
      end

      it 'pushes users who never signed in to the end' do
1486
        expect(users.third).to eq(@user2)
1487
      end
Valery Sizov's avatar
Valery Sizov committed
1488 1489
    end

1490
    it 'sorts users in descending order by their creation time' do
1491
      expect(described_class.sort_by_attribute('created_desc').first).to eq(@user)
Valery Sizov's avatar
Valery Sizov committed
1492 1493
    end

1494
    it 'sorts users in ascending order by their creation time' do
1495
      expect(described_class.sort_by_attribute('created_asc').first).to eq(@user2)
Valery Sizov's avatar
Valery Sizov committed
1496 1497
    end

1498
    it 'sorts users by id in descending order when nil is passed' do
1499
      expect(described_class.sort_by_attribute(nil).first).to eq(@user2)
Valery Sizov's avatar
Valery Sizov committed
1500 1501
    end
  end
1502

1503
  describe "#contributed_projects" do
1504
    subject { create(:user) }
1505
    let!(:project1) { create(:project) }
1506
    let!(:project2) { fork_project(project3) }
1507
    let!(:project3) { create(:project) }
1508
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
1509
    let!(:push_event) { create(:push_event, project: project1, author: subject) }
1510
    let!(:merge_event) { create(:event, :created, project: project3, target: merge_request, author: subject) }
1511 1512

    before do
1513 1514
      project1.add_master(subject)
      project2.add_master(subject)
1515 1516 1517
    end

    it "includes IDs for projects the user has pushed to" do
1518
      expect(subject.contributed_projects).to include(project1)
1519 1520 1521
    end

    it "includes IDs for projects the user has had merge requests merged into" do
1522
      expect(subject.contributed_projects).to include(project3)
1523 1524 1525
    end

    it "doesn't include IDs for unrelated projects" do
1526
      expect(subject.contributed_projects).not_to include(project2)
1527 1528
    end
  end
1529

1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546
  describe '#fork_of' do
    let(:user) { create(:user) }

    it "returns a user's fork of a project" do
      project = create(:project, :public)
      user_fork = fork_project(project, user, namespace: user.namespace)

      expect(user.fork_of(project)).to eq(user_fork)
    end

    it 'returns nil if the project does not have a fork network' do
      project = create(:project)

      expect(user.fork_of(project)).to be_nil
    end
  end

1547
  describe '#can_be_removed?' do
1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
1563 1564

  describe "#recent_push" do
1565 1566 1567
    let(:user) { build(:user) }
    let(:project) { build(:project) }
    let(:event) { build(:push_event) }
1568

1569 1570 1571 1572
    it 'returns the last push event for the user' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_user)
        .and_return(event)
1573

1574
      expect(user.recent_push).to eq(event)
1575 1576
    end

1577 1578 1579 1580
    it 'returns the last push event for a project when one is given' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_project)
        .and_return(event)
1581

1582
      expect(user.recent_push(project)).to eq(event)
1583
    end
1584
  end
1585 1586 1587 1588

  describe '#authorized_groups' do
    let!(:user) { create(:user) }
    let!(:private_group) { create(:group) }
1589 1590 1591 1592
    let!(:child_group) { create(:group, parent: private_group) }

    let!(:project_group) { create(:group) }
    let!(:project) { create(:project, group: project_group) }
1593 1594 1595

    before do
      private_group.add_user(user, Gitlab::Access::MASTER)
1596
      project.add_master(user)
1597 1598
    end

1599
    subject { user.authorized_groups }
1600

1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619
    it { is_expected.to contain_exactly private_group, project_group }
  end

  describe '#membership_groups' do
    let!(:user) { create(:user) }
    let!(:parent_group) { create(:group) }
    let!(:child_group) { create(:group, parent: parent_group) }

    before do
      parent_group.add_user(user, Gitlab::Access::MASTER)
    end

    subject { user.membership_groups }

    if Group.supports_nested_groups?
      it { is_expected.to contain_exactly parent_group, child_group }
    else
      it { is_expected.to contain_exactly parent_group }
    end
1620 1621
  end

1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647
  describe '#authorizations_for_projects' do
    let!(:user) { create(:user) }
    subject { Project.where("EXISTS (?)", user.authorizations_for_projects) }

    it 'includes projects that belong to a user, but no other projects' do
      owned = create(:project, :private, namespace: user.namespace)
      member = create(:project, :private).tap { |p| p.add_master(user) }
      other = create(:project)

      expect(subject).to include(owned)
      expect(subject).to include(member)
      expect(subject).not_to include(other)
    end

    it 'includes projects a user has access to, but no other projects' do
      other_user = create(:user)
      accessible = create(:project, :private, namespace: other_user.namespace) do |project|
        project.add_developer(user)
      end
      other = create(:project)

      expect(subject).to include(accessible)
      expect(subject).not_to include(other)
    end
  end

1648
  describe '#authorized_projects', :delete do
1649 1650 1651
    context 'with a minimum access level' do
      it 'includes projects for which the user is an owner' do
        user = create(:user)
1652
        project = create(:project, :private, namespace: user.namespace)
1653

1654 1655
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1656
      end
1657

1658 1659
      it 'includes projects for which the user is a master' do
        user = create(:user)
1660
        project = create(:project, :private)
1661

1662
        project.add_master(user)
1663

1664 1665
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1666 1667
      end
    end
1668 1669 1670

    it "includes user's personal projects" do
      user    = create(:user)
1671
      project = create(:project, :private, namespace: user.namespace)
1672 1673 1674 1675 1676 1677 1678

      expect(user.authorized_projects).to include(project)
    end

    it "includes personal projects user has been given access to" do
      user1   = create(:user)
      user2   = create(:user)
1679
      project = create(:project, :private, namespace: user1.namespace)
1680

1681
      project.add_developer(user2)
1682 1683 1684 1685 1686 1687

      expect(user2.authorized_projects).to include(project)
    end

    it "includes projects of groups user has been added to" do
      group   = create(:group)
1688
      project = create(:project, group: group)
1689 1690 1691 1692 1693 1694 1695 1696 1697
      user    = create(:user)

      group.add_developer(user)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include projects of groups user has been removed from" do
      group   = create(:group)
1698
      project = create(:project, group: group)
1699 1700 1701
      user    = create(:user)

      member = group.add_developer(user)
1702

1703 1704 1705
      expect(user.authorized_projects).to include(project)

      member.destroy
1706

1707 1708 1709 1710 1711
      expect(user.authorized_projects).not_to include(project)
    end

    it "includes projects shared with user's group" do
      user    = create(:user)
1712
      project = create(:project, :private)
1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723
      group   = create(:group)

      group.add_reporter(user)
      project.project_group_links.create(group: group)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include destroyed projects user had access to" do
      user1   = create(:user)
      user2   = create(:user)
1724
      project = create(:project, :private, namespace: user1.namespace)
1725

1726
      project.add_developer(user2)
1727

1728 1729 1730
      expect(user2.authorized_projects).to include(project)

      project.destroy
1731

1732 1733 1734 1735 1736
      expect(user2.authorized_projects).not_to include(project)
    end

    it "does not include projects of destroyed groups user had access to" do
      group   = create(:group)
1737
      project = create(:project, namespace: group)
1738 1739 1740
      user    = create(:user)

      group.add_developer(user)
1741

1742 1743 1744
      expect(user.authorized_projects).to include(project)

      group.destroy
1745

1746 1747
      expect(user.authorized_projects).not_to include(project)
    end
1748
  end
1749

1750 1751 1752 1753
  describe '#projects_where_can_admin_issues' do
    let(:user) { create(:user) }

    it 'includes projects for which the user access level is above or equal to reporter' do
1754 1755 1756
      reporter_project  = create(:project) { |p| p.add_reporter(user) }
      developer_project = create(:project) { |p| p.add_developer(user) }
      master_project    = create(:project) { |p| p.add_master(user) }
1757

1758
      expect(user.projects_where_can_admin_issues.to_a).to match_array([master_project, developer_project, reporter_project])
1759 1760 1761 1762 1763 1764
      expect(user.can?(:admin_issue, master_project)).to eq(true)
      expect(user.can?(:admin_issue, developer_project)).to eq(true)
      expect(user.can?(:admin_issue, reporter_project)).to eq(true)
    end

    it 'does not include for which the user access level is below reporter' do
1765 1766
      project = create(:project)
      guest_project = create(:project) { |p| p.add_guest(user) }
1767 1768 1769 1770 1771 1772 1773

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, guest_project)).to eq(false)
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include archived projects' do
1774
      project = create(:project, :archived)
1775 1776 1777 1778 1779 1780

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include projects for which issues are disabled' do
1781
      project = create(:project, :issues_disabled)
1782 1783 1784 1785 1786 1787

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end
  end

1788 1789 1790 1791
  describe '#ci_authorized_runners' do
    let(:user) { create(:user) }
    let(:runner) { create(:ci_runner) }

1792 1793 1794
    before do
      project.runners << runner
    end
1795 1796

    context 'without any projects' do
1797
      let(:project) { create(:project) }
1798 1799

      it 'does not load' do
1800
        expect(user.ci_authorized_runners).to be_empty
1801 1802 1803 1804 1805
      end
    end

    context 'with personal projects runners' do
      let(:namespace) { create(:namespace, owner: user) }
1806
      let(:project) { create(:project, namespace: namespace) }
1807 1808

      it 'loads' do
1809
        expect(user.ci_authorized_runners).to contain_exactly(runner)
1810 1811 1812 1813
      end
    end

    shared_examples :member do
1814
      context 'when the user is a master' do
1815
        before do
1816
          add_user(:master)
1817
        end
1818

1819 1820 1821
        it 'loads' do
          expect(user.ci_authorized_runners).to contain_exactly(runner)
        end
1822 1823
      end

1824
      context 'when the user is a developer' do
1825
        before do
1826
          add_user(:developer)
1827
        end
1828

1829 1830 1831
        it 'does not load' do
          expect(user.ci_authorized_runners).to be_empty
        end
1832 1833 1834 1835 1836
      end
    end

    context 'with groups projects runners' do
      let(:group) { create(:group) }
1837
      let(:project) { create(:project, group: group) }
1838

Lin Jen-Shin's avatar
Lin Jen-Shin committed
1839
      def add_user(access)
1840 1841 1842 1843 1844 1845 1846
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with other projects runners' do
1847
      let(:project) { create(:project) }
1848

Lin Jen-Shin's avatar
Lin Jen-Shin committed
1849
      def add_user(access)
1850
        project.add_role(user, access)
1851 1852 1853 1854
      end

      it_behaves_like :member
    end
1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869

    context 'with subgroup with different owner for project runner', :nested_groups do
      let(:group) { create(:group) }
      let(:another_user) { create(:user) }
      let(:subgroup) { create(:group, parent: group) }
      let(:project) { create(:project, group: subgroup) }

      def add_user(access)
        group.add_user(user, access)
        group.add_user(another_user, :owner)
        subgroup.add_user(another_user, :owner)
      end

      it_behaves_like :member
    end
1870 1871
  end

1872
  describe '#projects_with_reporter_access_limited_to' do
1873 1874
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
1875 1876 1877
    let(:user) { create(:user) }

    before do
1878 1879
      project1.add_reporter(user)
      project2.add_guest(user)
1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894
    end

    it 'returns the projects when using a single project ID' do
      projects = user.projects_with_reporter_access_limited_to(project1.id)

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an Array of project IDs' do
      projects = user.projects_with_reporter_access_limited_to([project1.id])

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an ActiveRecord relation' do
1895 1896
      projects = user
        .projects_with_reporter_access_limited_to(Project.select(:id))
1897 1898 1899 1900 1901 1902 1903 1904 1905 1906

      expect(projects).to eq([project1])
    end

    it 'does not return projects you do not have reporter access to' do
      projects = user.projects_with_reporter_access_limited_to(project2.id)

      expect(projects).to be_empty
    end
  end
1907

1908 1909
  describe '#all_expanded_groups' do
    # foo/bar would also match foo/barbaz instead of just foo/bar and foo/bar/baz
1910 1911
    let!(:user) { create(:user) }

1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927
    #                group
    #        _______ (foo) _______
    #       |                     |
    #       |                     |
    # nested_group_1        nested_group_2
    # (bar)                 (barbaz)
    #       |                     |
    #       |                     |
    # nested_group_1_1      nested_group_2_1
    # (baz)                 (baz)
    #
    let!(:group) { create :group }
    let!(:nested_group_1) { create :group, parent: group, name: 'bar' }
    let!(:nested_group_1_1) { create :group, parent: nested_group_1, name: 'baz' }
    let!(:nested_group_2) { create :group, parent: group, name: 'barbaz' }
    let!(:nested_group_2_1) { create :group, parent: nested_group_2, name: 'baz' }
1928

1929 1930 1931 1932 1933 1934
    subject { user.all_expanded_groups }

    context 'user is not a member of any group' do
      it 'returns an empty array' do
        is_expected.to eq([])
      end
1935 1936
    end

1937 1938 1939 1940 1941 1942 1943 1944
    context 'user is member of all groups' do
      before do
        group.add_owner(user)
        nested_group_1.add_owner(user)
        nested_group_1_1.add_owner(user)
        nested_group_2.add_owner(user)
        nested_group_2_1.add_owner(user)
      end
1945

1946 1947 1948 1949 1950 1951 1952 1953
      it 'returns all groups' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1,
          nested_group_2, nested_group_2_1
        ]
      end
    end
1954

1955
    context 'user is member of the top group' do
1956 1957 1958
      before do
        group.add_owner(user)
      end
1959

1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973
      if Group.supports_nested_groups?
        it 'returns all groups' do
          is_expected.to match_array [
            group,
            nested_group_1, nested_group_1_1,
            nested_group_2, nested_group_2_1
          ]
        end
      else
        it 'returns the top-level groups' do
          is_expected.to match_array [group]
        end
      end
    end
1974

1975
    context 'user is member of the first child (internal node), branch 1', :nested_groups do
1976 1977 1978
      before do
        nested_group_1.add_owner(user)
      end
1979

1980 1981 1982 1983 1984 1985 1986 1987 1988
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end

    context 'user is member of the first child (internal node), branch 2', :nested_groups do
1989 1990 1991
      before do
        nested_group_2.add_owner(user)
      end
1992

1993 1994 1995 1996 1997 1998
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_2, nested_group_2_1
        ]
      end
1999 2000
    end

2001
    context 'user is member of the last child (leaf node)', :nested_groups do
2002 2003 2004
      before do
        nested_group_1_1.add_owner(user)
      end
2005 2006 2007 2008 2009 2010 2011 2012

      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end
2013 2014
  end

2015
  describe '#refresh_authorized_projects', :clean_gitlab_redis_shared_state do
2016 2017
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
2018 2019 2020
    let(:user) { create(:user) }

    before do
2021 2022
      project1.add_reporter(user)
      project2.add_guest(user)
2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036

      user.project_authorizations.delete_all
      user.refresh_authorized_projects
    end

    it 'refreshes the list of authorized projects' do
      expect(user.project_authorizations.count).to eq(2)
    end

    it 'stores the correct access levels' do
      expect(user.project_authorizations.where(access_level: Gitlab::Access::GUEST).exists?).to eq(true)
      expect(user.project_authorizations.where(access_level: Gitlab::Access::REPORTER).exists?).to eq(true)
    end
  end
Douwe Maan's avatar
Douwe Maan committed
2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069

  describe '#access_level=' do
    let(:user) { build(:user) }

    it 'does nothing for an invalid access level' do
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:regular)
      expect(user.admin).to be false
    end

    it "assigns the 'admin' access level" do
      user.access_level = :admin

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "doesn't clear existing access levels when an invalid access level is passed in" do
      user.access_level = :admin
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "accepts string values in addition to symbols" do
      user.access_level = 'admin'

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end
  end
2070

2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084
  describe '#full_private_access?' do
    it 'returns false for regular user' do
      user = build(:user)

      expect(user.full_private_access?).to be_falsy
    end

    it 'returns true for admin user' do
      user = build(:user, :admin)

      expect(user.full_private_access?).to be_truthy
    end
  end

2085 2086
  describe '.ghost' do
    it "creates a ghost user if one isn't already present" do
2087
      ghost = described_class.ghost
2088 2089 2090

      expect(ghost).to be_ghost
      expect(ghost).to be_persisted
2091 2092
      expect(ghost.namespace).not_to be_nil
      expect(ghost.namespace).to be_persisted
2093 2094 2095 2096
    end

    it "does not create a second ghost user if one is already present" do
      expect do
2097 2098 2099 2100
        described_class.ghost
        described_class.ghost
      end.to change { described_class.count }.by(1)
      expect(described_class.ghost).to eq(described_class.ghost)
2101 2102 2103 2104 2105
    end

    context "when a regular user exists with the username 'ghost'" do
      it "creates a ghost user with a non-conflicting username" do
        create(:user, username: 'ghost')
2106
        ghost = described_class.ghost
2107 2108

        expect(ghost).to be_persisted
2109
        expect(ghost.username).to eq('ghost1')
2110 2111 2112 2113 2114 2115
      end
    end

    context "when a regular user exists with the email 'ghost@example.com'" do
      it "creates a ghost user with a non-conflicting email" do
        create(:user, email: 'ghost@example.com')
2116
        ghost = described_class.ghost
2117 2118

        expect(ghost).to be_persisted
2119
        expect(ghost.email).to eq('ghost1@example.com')
2120 2121
      end
    end
2122 2123 2124 2125 2126 2127 2128

    context 'when a domain whitelist is in place' do
      before do
        stub_application_setting(domain_whitelist: ['gitlab.com'])
      end

      it 'creates a ghost user' do
2129
        expect(described_class.ghost).to be_persisted
2130 2131
      end
    end
2132
  end
2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148

  describe '#update_two_factor_requirement' do
    let(:user) { create :user }

    context 'with 2FA requirement on groups' do
      let(:group1) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 23 }
      let(:group2) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 32 }

      before do
        group1.add_user(user, GroupMember::OWNER)
        group2.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2149
        expect(user.require_two_factor_authentication_from_group).to be true
2150 2151 2152 2153 2154 2155 2156
      end

      it 'uses the shortest grace period' do
        expect(user.two_factor_grace_period).to be 23
      end
    end

2157
    context 'with 2FA requirement on nested parent group', :nested_groups do
2158 2159 2160 2161 2162 2163 2164 2165 2166 2167
      let!(:group1) { create :group, require_two_factor_authentication: true }
      let!(:group1a) { create :group, require_two_factor_authentication: false, parent: group1 }

      before do
        group1a.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2168
        expect(user.require_two_factor_authentication_from_group).to be true
2169 2170 2171
      end
    end

2172
    context 'with 2FA requirement on nested child group', :nested_groups do
2173 2174 2175 2176 2177 2178 2179 2180 2181 2182
      let!(:group1) { create :group, require_two_factor_authentication: false }
      let!(:group1a) { create :group, require_two_factor_authentication: true, parent: group1 }

      before do
        group1.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2183
        expect(user.require_two_factor_authentication_from_group).to be true
2184 2185 2186
      end
    end

2187 2188 2189 2190 2191 2192 2193 2194 2195 2196
    context 'without 2FA requirement on groups' do
      let(:group) { create :group }

      before do
        group.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'does not require 2FA' do
2197
        expect(user.require_two_factor_authentication_from_group).to be false
2198 2199 2200 2201 2202 2203 2204
      end

      it 'falls back to the default grace period' do
        expect(user.two_factor_grace_period).to be 48
      end
    end
  end
James Lopez's avatar
James Lopez committed
2205 2206 2207

  context '.active' do
    before do
2208
      described_class.ghost
James Lopez's avatar
James Lopez committed
2209 2210 2211 2212 2213
      create(:user, name: 'user', state: 'active')
      create(:user, name: 'user', state: 'blocked')
    end

    it 'only counts active and non internal users' do
2214
      expect(described_class.active.count).to eq(1)
James Lopez's avatar
James Lopez committed
2215 2216
    end
  end
2217 2218 2219 2220 2221 2222 2223 2224

  describe 'preferred language' do
    it 'is English by default' do
      user = create(:user)

      expect(user.preferred_language).to eq('en')
    end
  end
2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252

  context '#invalidate_issue_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for issue counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_issues_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_issue_cache_counts
    end
  end

  context '#invalidate_merge_request_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for Merge Request counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_merge_requests_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_merge_request_cache_counts
    end
  end
2253

2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267
  context '#invalidate_personal_projects_count' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for personal projects counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'personal_projects_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_personal_projects_count
    end
  end

2268
  describe '#allow_password_authentication_for_web?' do
2269 2270 2271
    context 'regular user' do
      let(:user) { build(:user) }

2272 2273
      it 'returns true when password authentication is enabled for the web interface' do
        expect(user.allow_password_authentication_for_web?).to be_truthy
2274 2275
      end

2276 2277
      it 'returns false when password authentication is disabled for the web interface' do
        stub_application_setting(password_authentication_enabled_for_web: false)
2278

2279
        expect(user.allow_password_authentication_for_web?).to be_falsey
2280 2281 2282 2283 2284 2285
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308
      expect(user.allow_password_authentication_for_web?).to be_falsey
    end
  end

  describe '#allow_password_authentication_for_git?' do
    context 'regular user' do
      let(:user) { build(:user) }

      it 'returns true when password authentication is enabled for Git' do
        expect(user.allow_password_authentication_for_git?).to be_truthy
      end

      it 'returns false when password authentication is disabled Git' do
        stub_application_setting(password_authentication_enabled_for_git: false)

        expect(user.allow_password_authentication_for_git?).to be_falsey
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

      expect(user.allow_password_authentication_for_git?).to be_falsey
2309 2310
    end
  end
2311 2312 2313 2314 2315 2316

  describe '#personal_projects_count' do
    it 'returns the number of personal projects using a single query' do
      user = build(:user)
      projects = double(:projects, count: 1)

2317
      expect(user).to receive(:personal_projects).and_return(projects)
2318

2319
      expect(user.personal_projects_count).to eq(1)
2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332
    end
  end

  describe '#projects_limit_left' do
    it 'returns the number of projects that can be created by the user' do
      user = build(:user)

      allow(user).to receive(:projects_limit).and_return(10)
      allow(user).to receive(:personal_projects_count).and_return(5)

      expect(user.projects_limit_left).to eq(5)
    end
  end
2333 2334 2335 2336 2337 2338 2339

  describe '#ensure_namespace_correct' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'creates the namespace' do
        expect(user.namespace).to be_nil
2340

2341
        user.save!
2342

2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362
        expect(user.namespace).not_to be_nil
      end
    end

    context 'for an existing user' do
      let(:username) { 'foo' }
      let(:user) { create(:user, username: username) }

      context 'when the user is updated' do
        context 'when the username is changed' do
          let(:new_username) { 'bar' }

          it 'changes the namespace (just to compare to when username is not changed)' do
            expect do
              user.update_attributes!(username: new_username)
            end.to change { user.namespace.updated_at }
          end

          it 'updates the namespace name' do
            user.update_attributes!(username: new_username)
2363

2364 2365 2366 2367 2368
            expect(user.namespace.name).to eq(new_username)
          end

          it 'updates the namespace path' do
            user.update_attributes!(username: new_username)
2369

2370 2371 2372 2373
            expect(user.namespace.path).to eq(new_username)
          end

          context 'when there is a validation error (namespace name taken) while updating namespace' do
2374
            let!(:conflicting_namespace) { create(:group, path: new_username) }
2375

2376
            it 'causes the user save to fail' do
2377
              expect(user.update_attributes(username: new_username)).to be_falsey
2378
              expect(user.namespace.errors.messages[:path].first).to eq('has already been taken')
2379
            end
2380 2381 2382

            it 'adds the namespace errors to the user' do
              user.update_attributes(username: new_username)
2383

2384
              expect(user.errors.full_messages.first).to eq('Username has already been taken')
2385
            end
2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398
          end
        end

        context 'when the username is not changed' do
          it 'does not change the namespace' do
            expect do
              user.update_attributes!(email: 'asdf@asdf.com')
            end.not_to change { user.namespace.updated_at }
          end
        end
      end
    end
  end
2399

2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435
  describe '#username_changed_hook' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'does not trigger system hook' do
        expect(user).not_to receive(:system_hook_service)

        user.save!
      end
    end

    context 'for an existing user' do
      let(:user) { create(:user, username: 'old-username') }

      context 'when the username is changed' do
        let(:new_username) { 'very-new-name' }

        it 'triggers the rename system hook' do
          system_hook_service = SystemHooksService.new
          expect(system_hook_service).to receive(:execute_hooks_for).with(user, :rename)
          expect(user).to receive(:system_hook_service).and_return(system_hook_service)

          user.update_attributes!(username: new_username)
        end
      end

      context 'when the username is not changed' do
        it 'does not trigger system hook' do
          expect(user).not_to receive(:system_hook_service)

          user.update_attributes!(email: 'asdf@asdf.com')
        end
      end
    end
  end

2436 2437 2438 2439 2440 2441
  describe '#sync_attribute?' do
    let(:user) { described_class.new }

    context 'oauth user' do
      it 'returns true if name can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name location))
2442

2443 2444 2445 2446 2447
        expect(user.sync_attribute?(:name)).to be_truthy
      end

      it 'returns true if email can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name email))
2448

2449 2450 2451 2452 2453
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns true if location can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2454

2455 2456 2457 2458 2459
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns false if name can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2460

2461 2462 2463 2464 2465
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if email can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2466

2467 2468 2469 2470 2471
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if location can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2472

2473 2474 2475 2476 2477
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns true for all syncable attributes if all syncable attributes can be synced' do
        stub_omniauth_setting(sync_profile_attributes: true)
2478

2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493
        expect(user.sync_attribute?(:name)).to be_truthy
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end

      it 'returns false for all syncable attributes but email if no syncable attributes are declared' do
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end
    end

    context 'ldap user' do
      it 'returns true for email if ldap user' do
        allow(user).to receive(:ldap_user?).and_return(true)
2494

2495 2496 2497 2498 2499 2500 2501 2502
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end

      it 'returns true for email and location if ldap user and location declared as syncable' do
        allow(user).to receive(:ldap_user?).and_return(true)
        stub_omniauth_setting(sync_profile_attributes: %w(location))
2503

2504 2505 2506 2507 2508 2509
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end
    end
  end
2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525

  describe '#confirm_deletion_with_password?' do
    where(
      password_automatically_set: [true, false],
      ldap_user: [true, false],
      password_authentication_disabled: [true, false]
    )

    with_them do
      let!(:user) { create(:user, password_automatically_set: password_automatically_set) }
      let!(:identity) { create(:identity, user: user) if ldap_user }

      # Only confirm deletion with password if all inputs are false
      let(:expected) { !(password_automatically_set || ldap_user || password_authentication_disabled) }

      before do
2526 2527
        stub_application_setting(password_authentication_enabled_for_web: !password_authentication_disabled)
        stub_application_setting(password_authentication_enabled_for_git: !password_authentication_disabled)
2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555
      end

      it 'returns false unless all inputs are true' do
        expect(user.confirm_deletion_with_password?).to eq(expected)
      end
    end
  end

  describe '#delete_async' do
    let(:user) { create(:user) }
    let(:deleted_by) { create(:user) }

    it 'blocks the user then schedules them for deletion if a hard delete is specified' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, hard_delete: true)

      user.delete_async(deleted_by: deleted_by, params: { hard_delete: true })

      expect(user).to be_blocked
    end

    it 'schedules user for deletion without blocking them' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, {})

      user.delete_async(deleted_by: deleted_by)

      expect(user).not_to be_blocked
    end
  end
2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714

  describe '#max_member_access_for_project_ids' do
    shared_examples 'max member access for projects' do
      let(:user) { create(:user) }
      let(:group) { create(:group) }
      let(:owner_project) { create(:project, group: group) }
      let(:master_project) { create(:project) }
      let(:reporter_project) { create(:project) }
      let(:developer_project) { create(:project) }
      let(:guest_project) { create(:project) }
      let(:no_access_project) { create(:project) }

      let(:projects) do
        [owner_project, master_project, reporter_project, developer_project, guest_project, no_access_project].map(&:id)
      end

      let(:expected) do
        {
          owner_project.id => Gitlab::Access::OWNER,
          master_project.id => Gitlab::Access::MASTER,
          reporter_project.id => Gitlab::Access::REPORTER,
          developer_project.id => Gitlab::Access::DEVELOPER,
          guest_project.id => Gitlab::Access::GUEST,
          no_access_project.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        create(:group_member, user: user, group: group)
        master_project.add_master(user)
        reporter_project.add_reporter(user)
        developer_project.add_developer(user)
        guest_project.add_guest(user)
      end

      it 'returns correct roles for different projects' do
        expect(user.max_member_access_for_project_ids(projects)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for projects'

      def access_levels(projects)
        user.max_member_access_for_project_ids(projects)
      end

      it 'does not perform extra queries when asked for projects who have already been found' do
        access_levels(projects)

        expect { access_levels(projects) }.not_to exceed_query_limit(0)

        expect(access_levels(projects)).to eq(expected)
      end

      it 'only requests the extra projects when uncached projects are passed' do
        second_master_project = create(:project)
        second_developer_project = create(:project)
        second_master_project.add_master(user)
        second_developer_project.add_developer(user)

        all_projects = projects + [second_master_project.id, second_developer_project.id]

        expected_all = expected.merge(second_master_project.id => Gitlab::Access::MASTER,
                                      second_developer_project.id => Gitlab::Access::DEVELOPER)

        access_levels(projects)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_projects) }

        expect(queries.count).to eq(1)
        expect(queries.log_message).to match(/\W(#{second_master_project.id}, #{second_developer_project.id})\W/)
        expect(access_levels(all_projects)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for projects'
    end
  end

  describe '#max_member_access_for_group_ids' do
    shared_examples 'max member access for groups' do
      let(:user) { create(:user) }
      let(:owner_group) { create(:group) }
      let(:master_group) { create(:group) }
      let(:reporter_group) { create(:group) }
      let(:developer_group) { create(:group) }
      let(:guest_group) { create(:group) }
      let(:no_access_group) { create(:group) }

      let(:groups) do
        [owner_group, master_group, reporter_group, developer_group, guest_group, no_access_group].map(&:id)
      end

      let(:expected) do
        {
          owner_group.id => Gitlab::Access::OWNER,
          master_group.id => Gitlab::Access::MASTER,
          reporter_group.id => Gitlab::Access::REPORTER,
          developer_group.id => Gitlab::Access::DEVELOPER,
          guest_group.id => Gitlab::Access::GUEST,
          no_access_group.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        owner_group.add_owner(user)
        master_group.add_master(user)
        reporter_group.add_reporter(user)
        developer_group.add_developer(user)
        guest_group.add_guest(user)
      end

      it 'returns correct roles for different groups' do
        expect(user.max_member_access_for_group_ids(groups)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for groups'

      def access_levels(groups)
        user.max_member_access_for_group_ids(groups)
      end

      it 'does not perform extra queries when asked for groups who have already been found' do
        access_levels(groups)

        expect { access_levels(groups) }.not_to exceed_query_limit(0)

        expect(access_levels(groups)).to eq(expected)
      end

      it 'only requests the extra groups when uncached groups are passed' do
        second_master_group = create(:group)
        second_developer_group = create(:group)
        second_master_group.add_master(user)
        second_developer_group.add_developer(user)

        all_groups = groups + [second_master_group.id, second_developer_group.id]

        expected_all = expected.merge(second_master_group.id => Gitlab::Access::MASTER,
                                      second_developer_group.id => Gitlab::Access::DEVELOPER)

        access_levels(groups)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_groups) }

        expect(queries.count).to eq(1)
        expect(queries.log_message).to match(/\W(#{second_master_group.id}, #{second_developer_group.id})\W/)
        expect(access_levels(all_groups)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for groups'
    end
  end
2715

2716 2717
  context 'changing a username' do
    let(:user) { create(:user, username: 'foo') }
2718

2719 2720 2721
    it 'creates a redirect route' do
      expect { user.update!(username: 'bar') }
        .to change { RedirectRoute.where(path: 'foo').count }.by(1)
2722 2723
    end

2724 2725 2726 2727 2728
    it 'deletes the redirect when a user with the old username was created' do
      user.update!(username: 'bar')

      expect { create(:user, username: 'foo') }
        .to change { RedirectRoute.where(path: 'foo').count }.by(-1)
2729 2730
    end
  end
gitlabhq's avatar
gitlabhq committed
2731
end