git_access_spec.rb 46.7 KB
Newer Older
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1 2
require 'spec_helper'

3
describe Gitlab::GitAccess do
4 5
  set(:user) { create(:user) }

6
  let(:actor) { user }
7
  let(:project) { create(:project, :repository) }
8 9
  let(:project_path) { project.path }
  let(:namespace_path) { project&.namespace&.path }
10
  let(:protocol) { 'ssh' }
11
  let(:authentication_abilities) { %i[read_project download_code push_code] }
12
  let(:redirected_path) { nil }
13

14 15 16 17 18 19 20
  let(:access) do
    described_class.new(actor, project,
      protocol, authentication_abilities: authentication_abilities,
                namespace_path: namespace_path, project_path: project_path,
                redirected_path: redirected_path)
  end

21 22 23
  let(:changes) { '_any' }
  let(:push_access_check) { access.check('git-receive-pack', changes) }
  let(:pull_access_check) { access.check('git-upload-pack', changes) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
24

25 26
  describe '#check with single protocols allowed' do
    def disable_protocol(protocol)
27
      allow(Gitlab::ProtocolAccess).to receive(:allowed?).with(protocol).and_return(false)
28 29 30 31 32 33 34
    end

    context 'ssh disabled' do
      before do
        disable_protocol('ssh')
      end

35 36 37 38 39
      it 'blocks ssh git push and pull' do
        aggregate_failures do
          expect { push_access_check }.to raise_unauthorized('Git access over SSH is not allowed')
          expect { pull_access_check }.to raise_unauthorized('Git access over SSH is not allowed')
        end
40 41 42 43
      end
    end

    context 'http disabled' do
44 45
      let(:protocol) { 'http' }

46 47 48 49
      before do
        disable_protocol('http')
      end

50 51 52 53 54
      it 'blocks http push and pull' do
        aggregate_failures do
          expect { push_access_check }.to raise_unauthorized('Git access over HTTP is not allowed')
          expect { pull_access_check }.to raise_unauthorized('Git access over HTTP is not allowed')
        end
55 56 57 58
      end
    end
  end

59 60 61 62
  describe '#check_project_accessibility!' do
    context 'when the project exists' do
      context 'when actor exists' do
        context 'when actor is a DeployKey' do
63
          let(:deploy_key) { create(:deploy_key, user: user) }
64 65 66
          let(:actor) { deploy_key }

          context 'when the DeployKey has access to the project' do
67
            before do
68
              deploy_key.deploy_keys_projects.create(project: project, can_push: true)
69
            end
70

71 72 73 74 75
            it 'allows push and pull access' do
              aggregate_failures do
                expect { push_access_check }.not_to raise_error
                expect { pull_access_check }.not_to raise_error
              end
76 77 78 79
            end
          end

          context 'when the Deploykey does not have access to the project' do
80 81
            it 'blocks push and pull with "not found"' do
              aggregate_failures do
82 83
                expect { push_access_check }.to raise_not_found
                expect { pull_access_check }.to raise_not_found
84
              end
85 86 87 88 89 90
            end
          end
        end

        context 'when actor is a User' do
          context 'when the User can read the project' do
91
            before do
92
              project.add_master(user)
93
            end
94

95 96 97 98 99
            it 'allows push and pull access' do
              aggregate_failures do
                expect { pull_access_check }.not_to raise_error
                expect { push_access_check }.not_to raise_error
              end
100 101 102 103
            end
          end

          context 'when the User cannot read the project' do
104 105
            it 'blocks push and pull with "not found"' do
              aggregate_failures do
106 107
                expect { push_access_check }.to raise_not_found
                expect { pull_access_check }.to raise_not_found
108
              end
109 110 111 112 113 114 115 116 117 118 119 120 121 122
            end
          end
        end

        # For backwards compatibility
        context 'when actor is :ci' do
          let(:actor) { :ci }
          let(:authentication_abilities) { build_authentication_abilities }

          it 'allows pull access' do
            expect { pull_access_check }.not_to raise_error
          end

          it 'does not block pushes with "not found"' do
123
            expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:auth_upload])
124 125 126 127 128 129 130 131 132 133 134 135 136 137 138
          end
        end
      end

      context 'when actor is nil' do
        let(:actor) { nil }

        context 'when guests can read the project' do
          let(:project) { create(:project, :repository, :public) }

          it 'allows pull access' do
            expect { pull_access_check }.not_to raise_error
          end

          it 'does not block pushes with "not found"' do
139
            expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:upload])
140 141 142 143 144
          end
        end

        context 'when guests cannot read the project' do
          it 'blocks pulls with "not found"' do
145
            expect { pull_access_check }.to raise_not_found
146 147 148
          end

          it 'blocks pushes with "not found"' do
149
            expect { push_access_check }.to raise_not_found
150 151 152 153 154 155 156
          end
        end
      end
    end

    context 'when the project is nil' do
      let(:project) { nil }
157
      let(:project_path) { "new-project" }
158

159 160
      it 'blocks push and pull with "not found"' do
        aggregate_failures do
161 162
          expect { pull_access_check }.to raise_not_found
          expect { push_access_check }.to raise_not_found
163
        end
164
      end
165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200

      context 'when user is allowed to create project in namespace' do
        let(:namespace_path) { user.namespace.path }
        let(:access) do
          described_class.new(actor, nil,
            protocol, authentication_abilities: authentication_abilities,
                      project_path: project_path, namespace_path: namespace_path,
                      redirected_path: redirected_path)
        end

        it 'blocks pull access with "not found"' do
          expect { pull_access_check }.to raise_not_found
        end

        it 'allows push access' do
          expect { push_access_check }.not_to raise_error
        end
      end

      context 'when user is not allowed to create project in namespace' do
        let(:user2) { create(:user) }
        let(:namespace_path) { user2.namespace.path }
        let(:access) do
          described_class.new(actor, nil,
            protocol, authentication_abilities: authentication_abilities,
                      project_path: project_path, namespace_path: namespace_path,
                      redirected_path: redirected_path)
        end

        it 'blocks push and pull with "not found"' do
          aggregate_failures do
            expect { pull_access_check }.to raise_not_found
            expect { push_access_check }.to raise_not_found
          end
        end
      end
201 202 203
    end
  end

204 205 206 207 208 209 210 211 212 213
  shared_examples '#check with a key that is not valid' do
    before do
      project.add_master(user)
    end

    context 'key is too small' do
      before do
        stub_application_setting(rsa_key_restriction: 4096)
      end

214
      it 'does not allow keys which are too small', :aggregate_failures do
Nick Thomas's avatar
Nick Thomas committed
215 216 217
        expect(actor).not_to be_valid
        expect { pull_access_check }.to raise_unauthorized('Your SSH key must be at least 4096 bits.')
        expect { push_access_check }.to raise_unauthorized('Your SSH key must be at least 4096 bits.')
218 219 220 221 222 223 224 225
      end
    end

    context 'key type is not allowed' do
      before do
        stub_application_setting(rsa_key_restriction: ApplicationSetting::FORBIDDEN_KEY_VALUE)
      end

226
      it 'does not allow keys which are too small', :aggregate_failures do
Nick Thomas's avatar
Nick Thomas committed
227 228 229
        expect(actor).not_to be_valid
        expect { pull_access_check }.to raise_unauthorized(/Your SSH key type is forbidden/)
        expect { push_access_check }.to raise_unauthorized(/Your SSH key type is forbidden/)
230 231 232 233 234 235 236 237 238 239 240 241
      end
    end
  end

  it_behaves_like '#check with a key that is not valid' do
    let(:actor) { build(:rsa_key_2048, user: user) }
  end

  it_behaves_like '#check with a key that is not valid' do
    let(:actor) { build(:rsa_deploy_key_2048, user: user) }
  end

242 243 244 245
  shared_examples 'check_project_moved' do
    it 'enqueues a redirected message' do
      push_access_check

246
      expect(Gitlab::Checks::ProjectMoved.fetch_message(user.id, project.id)).not_to be_nil
247 248 249 250
    end
  end

  describe '#check_project_moved!', :clean_gitlab_redis_shared_state do
251
    before do
252
      project.add_master(user)
253 254 255
    end

    context 'when a redirect was not followed to find the project' do
256 257 258 259 260
      it 'allows push and pull access' do
        aggregate_failures do
          expect { push_access_check }.not_to raise_error
          expect { pull_access_check }.not_to raise_error
        end
261 262 263
      end
    end

264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297
    context 'when a permanent redirect and ssh protocol' do
      let(:redirected_path) { 'some/other-path' }

      before do
        allow_any_instance_of(Gitlab::Checks::ProjectMoved).to receive(:permanent_redirect?).and_return(true)
      end

      it 'allows push and pull access' do
        aggregate_failures do
          expect { push_access_check }.not_to raise_error
        end
      end

      it_behaves_like 'check_project_moved'
    end

    context 'with a permanent redirect and http protocol' do
      let(:redirected_path) { 'some/other-path' }
      let(:protocol) { 'http' }

      before do
        allow_any_instance_of(Gitlab::Checks::ProjectMoved).to receive(:permanent_redirect?).and_return(true)
      end

      it 'allows_push and pull access' do
        aggregate_failures do
          expect { push_access_check }.not_to raise_error
        end
      end

      it_behaves_like 'check_project_moved'
    end

    context 'with a temporal redirect and ssh protocol' do
298 299
      let(:redirected_path) { 'some/other-path' }

300 301
      it 'blocks push and pull access' do
        aggregate_failures do
302 303
          expect { push_access_check }.to raise_error(described_class::ProjectMovedError, /Project '#{redirected_path}' was moved to '#{project.full_path}'/)
          expect { push_access_check }.to raise_error(described_class::ProjectMovedError, /git remote set-url origin #{project.ssh_url_to_repo}/)
304

305 306
          expect { pull_access_check }.to raise_error(described_class::ProjectMovedError, /Project '#{redirected_path}' was moved to '#{project.full_path}'/)
          expect { pull_access_check }.to raise_error(described_class::ProjectMovedError, /git remote set-url origin #{project.ssh_url_to_repo}/)
307 308
        end
      end
309
    end
310

311 312 313
    context 'with a temporal redirect and http protocol' do
      let(:redirected_path) { 'some/other-path' }
      let(:protocol) { 'http' }
314

315 316 317
      it 'does not allow to push and pull access' do
        expect { push_access_check }.to raise_error(described_class::ProjectMovedError, /git remote set-url origin #{project.http_url_to_repo}/)
        expect { pull_access_check }.to raise_error(described_class::ProjectMovedError, /git remote set-url origin #{project.http_url_to_repo}/)
318 319 320 321
      end
    end
  end

322 323 324 325 326 327 328 329 330
  describe '#check_authentication_abilities!' do
    before do
      project.add_master(user)
    end

    context 'when download' do
      let(:authentication_abilities) { [] }

      it 'raises unauthorized with download error' do
331
        expect { pull_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:auth_download])
332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354
      end

      context 'when authentication abilities include download code' do
        let(:authentication_abilities) { [:download_code] }

        it 'does not raise any errors' do
          expect { pull_access_check }.not_to raise_error
        end
      end

      context 'when authentication abilities include build download code' do
        let(:authentication_abilities) { [:build_download_code] }

        it 'does not raise any errors' do
          expect { pull_access_check }.not_to raise_error
        end
      end
    end

    context 'when upload' do
      let(:authentication_abilities) { [] }

      it 'raises unauthorized with push error' do
355
        expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:auth_upload])
356 357 358 359 360 361 362 363 364 365 366 367
      end

      context 'when authentication abilities include push code' do
        let(:authentication_abilities) { [:push_code] }

        it 'does not raise any errors' do
          expect { push_access_check }.not_to raise_error
        end
      end
    end
  end

368
  describe '#check_command_disabled!' do
369
    before do
370
      project.add_master(user)
371
    end
372 373 374 375 376 377 378 379

    context 'over http' do
      let(:protocol) { 'http' }

      context 'when the git-upload-pack command is disabled in config' do
        before do
          allow(Gitlab.config.gitlab_shell).to receive(:upload_pack).and_return(false)
        end
380

381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
        context 'when calling git-upload-pack' do
          it { expect { pull_access_check }.to raise_unauthorized('Pulling over HTTP is not allowed.') }
        end

        context 'when calling git-receive-pack' do
          it { expect { push_access_check }.not_to raise_error }
        end
      end

      context 'when the git-receive-pack command is disabled in config' do
        before do
          allow(Gitlab.config.gitlab_shell).to receive(:receive_pack).and_return(false)
        end

        context 'when calling git-receive-pack' do
          it { expect { push_access_check }.to raise_unauthorized('Pushing over HTTP is not allowed.') }
        end

        context 'when calling git-upload-pack' do
          it { expect { pull_access_check }.not_to raise_error }
        end
      end
    end
  end

406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516
  describe '#check_db_accessibility!' do
    context 'when in a read-only GitLab instance' do
      before do
        create(:protected_branch, name: 'feature', project: project)
        allow(Gitlab::Database).to receive(:read_only?) { true }
      end

      it { expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:cannot_push_to_read_only]) }
    end
  end

  describe '#ensure_project_on_push!' do
    let(:access) do
      described_class.new(actor, project,
        protocol, authentication_abilities: authentication_abilities,
                  project_path: project_path, namespace_path: namespace_path,
                  redirected_path: redirected_path)
    end

    context 'when push' do
      let(:cmd) { 'git-receive-pack' }

      context 'when project does not exist' do
        let(:project_path) { "nonexistent" }
        let(:project) { nil }

        context 'when changes is _any' do
          let(:changes) { '_any' }

          context 'when authentication abilities include push code' do
            let(:authentication_abilities) { [:push_code] }

            context 'when user can create project in namespace' do
              let(:namespace_path) { user.namespace.path }

              it 'creates a new project' do
                expect { access.send(:ensure_project_on_push!, cmd, changes) }.to change { Project.count }.by(1)
              end
            end

            context 'when user cannot create project in namespace' do
              let(:user2) { create(:user) }
              let(:namespace_path) { user2.namespace.path }

              it 'does not create a new project' do
                expect { access.send(:ensure_project_on_push!, cmd, changes) }.not_to change { Project.count }
              end
            end
          end

          context 'when authentication abilities do not include push code' do
            let(:authentication_abilities) { [] }

            context 'when user can create project in namespace' do
              let(:namespace_path) { user.namespace.path }

              it 'does not create a new project' do
                expect { access.send(:ensure_project_on_push!, cmd, changes) }.not_to change { Project.count }
              end
            end
          end
        end

        context 'when check contains actual changes' do
          let(:changes) { "#{Gitlab::Git::BLANK_SHA} 570e7b2abdd848b95f2f578043fc23bd6f6fd24d refs/heads/new_branch" }

          it 'does not create a new project' do
            expect { access.send(:ensure_project_on_push!, cmd, changes) }.not_to change { Project.count }
          end
        end
      end

      context 'when project exists' do
        let(:changes) { '_any' }
        let!(:project) { create(:project) }

        it 'does not create a new project' do
          expect { access.send(:ensure_project_on_push!, cmd, changes) }.not_to change { Project.count }
        end
      end

      context 'when deploy key is used' do
        let(:key) { create(:deploy_key, user: user) }
        let(:actor) { key }
        let(:project_path) { "nonexistent" }
        let(:project) { nil }
        let(:namespace_path) { user.namespace.path }
        let(:changes) { '_any' }

        it 'does not create a new project' do
          expect { access.send(:ensure_project_on_push!, cmd, changes) }.not_to change { Project.count }
        end
      end
    end

    context 'when pull' do
      let(:cmd) { 'git-upload-pack' }
      let(:changes) { '_any' }

      context 'when project does not exist' do
        let(:project_path) { "new-project" }
        let(:namespace_path) { user.namespace.path }
        let(:project) { nil }

        it 'does not create a new project' do
          expect { access.send(:ensure_project_on_push!, cmd, changes) }.not_to change { Project.count }
        end
      end
    end
  end

517
  describe '#check_download_access!' do
518 519
    it 'allows masters to pull' do
      project.add_master(user)
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
520

521
      expect { pull_access_check }.not_to raise_error
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
522 523
    end

524 525
    it 'disallows guests to pull' do
      project.add_guest(user)
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
526

527
      expect { pull_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:download])
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
528 529
    end

530 531 532
    it 'disallows blocked users to pull' do
      project.add_master(user)
      user.block
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
533

534
      expect { pull_access_check }.to raise_unauthorized('Your account has been blocked.')
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
535 536
    end

537
    describe 'without access to project' do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
538
      context 'pull code' do
539
        it { expect { pull_access_check }.to raise_not_found }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
540
      end
541 542

      context 'when project is public' do
543
        let(:public_project) { create(:project, :public, :repository) }
544 545 546
        let(:project_path) { public_project.path }
        let(:namespace_path) { public_project.namespace.path }
        let(:access) { described_class.new(nil, public_project, 'web', authentication_abilities: [:download_code], project_path: project_path, namespace_path: namespace_path) }
547 548 549

        context 'when repository is enabled' do
          it 'give access to download code' do
550
            expect { pull_access_check }.not_to raise_error
551 552 553 554 555 556 557
          end
        end

        context 'when repository is disabled' do
          it 'does not give access to download code' do
            public_project.project_feature.update_attribute(:repository_access_level, ProjectFeature::DISABLED)

558
            expect { pull_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:download])
559 560 561
          end
        end
      end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
562
    end
563 564

    describe 'deploy key permissions' do
565
      let(:key) { create(:deploy_key, user: user) }
566
      let(:actor) { key }
567 568

      context 'pull code' do
569
        context 'when project is authorized' do
570 571 572
          before do
            key.projects << project
          end
573

574
          it { expect { pull_access_check }.not_to raise_error }
575 576 577 578
        end

        context 'when unauthorized' do
          context 'from public project' do
579
            let(:project) { create(:project, :public, :repository) }
580

581
            it { expect { pull_access_check }.not_to raise_error }
582 583 584
          end

          context 'from internal project' do
585
            let(:project) { create(:project, :internal, :repository) }
586

587
            it { expect { pull_access_check }.to raise_not_found }
588 589 590
          end

          context 'from private project' do
591
            let(:project) { create(:project, :private, :repository) }
592

593
            it { expect { pull_access_check }.to raise_not_found }
594 595
          end
        end
596 597
      end
    end
598

599 600
    describe 'build authentication_abilities permissions' do
      let(:authentication_abilities) { build_authentication_abilities }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
601

602
      describe 'owner' do
603
        let(:project) { create(:project, :repository, namespace: user.namespace) }
604 605

        context 'pull code' do
606
          it { expect { pull_access_check }.not_to raise_error }
607 608 609
        end
      end

Kamil Trzcinski's avatar
Kamil Trzcinski committed
610
      describe 'reporter user' do
611
        before do
612
          project.add_reporter(user)
613
        end
Kamil Trzcinski's avatar
Kamil Trzcinski committed
614 615

        context 'pull code' do
616
          it { expect { pull_access_check }.not_to raise_error }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
617 618 619 620 621 622 623
        end
      end

      describe 'admin user' do
        let(:user) { create(:admin) }

        context 'when member of the project' do
624
          before do
625
            project.add_reporter(user)
626
          end
Kamil Trzcinski's avatar
Kamil Trzcinski committed
627 628

          context 'pull code' do
629
            it { expect { pull_access_check }.not_to raise_error }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
630 631 632 633 634
          end
        end

        context 'when is not member of the project' do
          context 'pull code' do
635
            it { expect { pull_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:download]) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
636 637 638
          end
        end
      end
639 640 641 642 643 644 645 646

      describe 'generic CI (build without a user)' do
        let(:actor) { :ci }

        context 'pull code' do
          it { expect { pull_access_check }.not_to raise_error }
        end
      end
Kamil Trzcinski's avatar
Kamil Trzcinski committed
647
    end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
648 649
  end

650 651 652 653 654 655 656 657 658 659 660 661 662 663
  describe 'check LFS integrity' do
    let(:changes) { ['6f6d7e7ed 570e7b2ab refs/heads/master', '6f6d7e7ed 570e7b2ab refs/heads/feature'] }

    before do
      project.add_developer(user)
    end

    it 'checks LFS integrity only for first change' do
      expect_any_instance_of(Gitlab::Checks::LfsIntegrity).to receive(:objects_missing?).exactly(1).times

      push_access_check
    end
  end

664
  describe '#check_push_access!' do
665
    let(:unprotected_branch) { 'unprotected_branch' }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
666

667 668 669 670
    before do
      merge_into_protected_branch
    end

671 672
    let(:changes) do
      { push_new_branch: "#{Gitlab::Git::BLANK_SHA} 570e7b2ab refs/heads/wow",
673 674
        push_master: '6f6d7e7ed 570e7b2ab refs/heads/master',
        push_protected_branch: '6f6d7e7ed 570e7b2ab refs/heads/feature',
675 676
        push_remove_protected_branch: "570e7b2ab #{Gitlab::Git::BLANK_SHA} "\
                                      'refs/heads/feature',
677
        push_tag: '6f6d7e7ed 570e7b2ab refs/tags/v1.0.0',
678
        push_new_tag: "#{Gitlab::Git::BLANK_SHA} 570e7b2ab refs/tags/v7.8.9",
679 680
        push_all: ['6f6d7e7ed 570e7b2ab refs/heads/master', '6f6d7e7ed 570e7b2ab refs/heads/feature'],
        merge_into_protected_branch: "0b4bc9a #{merge_into_protected_branch} refs/heads/feature" }
681
    end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
682

683 684
    def stub_git_hooks
      # Running the `pre-receive` hook is expensive, and not necessary for this test.
685
      allow_any_instance_of(Gitlab::Git::HooksService).to receive(:execute) do |service, &block|
Sean McGivern's avatar
Sean McGivern committed
686 687
        block.call(service)
      end
688 689
    end

690 691
    def merge_into_protected_branch
      @protected_branch_merge_commit ||= begin
692 693 694 695 696
        stub_git_hooks
        project.repository.add_branch(user, unprotected_branch, 'feature')
        target_branch = project.repository.lookup('feature')
        source_branch = project.repository.create_file(
          user,
697
          'filename',
698 699
          'This is the file content',
          message: 'This is a good commit message',
700 701 702 703 704 705 706
          branch_name: unprotected_branch)
        rugged = project.repository.rugged
        author = { email: "email@example.com", time: Time.now, name: "Example Git User" }

        merge_index = rugged.merge_commits(target_branch, source_branch)
        Rugged::Commit.create(rugged, author: author, committer: author, message: "commit message", parents: [target_branch, source_branch], tree: merge_index.write_tree(rugged))
      end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
707
    end
708

709
    def self.run_permission_checks(permissions_matrix)
710 711 712 713 714 715 716 717 718 719
      permissions_matrix.each_pair do |role, matrix|
        # Run through the entire matrix for this role in one test to avoid
        # repeated setup.
        #
        # Expectations are given a custom failure message proc so that it's
        # easier to identify which check(s) failed.
        it "has the correct permissions for #{role}s" do
          if role == :admin
            user.update_attribute(:admin, true)
          else
720
            project.add_role(user, role)
Sean McGivern's avatar
Sean McGivern committed
721
          end
722

723 724 725
          aggregate_failures do
            matrix.each do |action, allowed|
              check = -> { access.send(:check_push_access!, changes[action]) }
726

727 728 729 730 731 732
              if allowed
                expect(&check).not_to raise_error,
                  -> { "expected #{action} to be allowed" }
              else
                expect(&check).to raise_error(Gitlab::GitAccess::UnauthorizedError),
                  -> { "expected #{action} to be disallowed" }
733 734 735 736 737 738 739 740 741
              end
            end
          end
        end
      end
    end

    # Run permission checks for a group
    def self.run_group_permission_checks(permissions_matrix)
742 743 744 745 746
      permissions_matrix.each_pair do |role, matrix|
        it "has the correct permissions for group #{role}s" do
          project
            .project_group_links
            .create(group: group, group_access: Gitlab::Access.sym_options[role])
747

748 749 750
          aggregate_failures do
            matrix.each do |action, allowed|
              check = -> { access.send(:check_push_access!, changes[action]) }
751

752 753 754 755 756 757
              if allowed
                expect(&check).not_to raise_error,
                  -> { "expected #{action} to be allowed" }
              else
                expect(&check).to raise_error(Gitlab::GitAccess::UnauthorizedError),
                  -> { "expected #{action} to be disallowed" }
758
              end
759 760 761 762 763
            end
          end
        end
      end
    end
764

765
    permissions_matrix = {
766 767 768 769 770 771 772 773 774 775 776
      admin: {
        push_new_branch: true,
        push_master: true,
        push_protected_branch: true,
        push_remove_protected_branch: false,
        push_tag: true,
        push_new_tag: true,
        push_all: true,
        merge_into_protected_branch: true
      },

777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821
      master: {
        push_new_branch: true,
        push_master: true,
        push_protected_branch: true,
        push_remove_protected_branch: false,
        push_tag: true,
        push_new_tag: true,
        push_all: true,
        merge_into_protected_branch: true
      },

      developer: {
        push_new_branch: true,
        push_master: true,
        push_protected_branch: false,
        push_remove_protected_branch: false,
        push_tag: false,
        push_new_tag: true,
        push_all: false,
        merge_into_protected_branch: false
      },

      reporter: {
        push_new_branch: false,
        push_master: false,
        push_protected_branch: false,
        push_remove_protected_branch: false,
        push_tag: false,
        push_new_tag: false,
        push_all: false,
        merge_into_protected_branch: false
      },

      guest: {
        push_new_branch: false,
        push_master: false,
        push_protected_branch: false,
        push_remove_protected_branch: false,
        push_tag: false,
        push_new_tag: false,
        push_all: false,
        merge_into_protected_branch: false
      }
    }

Douwe Maan's avatar
Douwe Maan committed
822
    [%w(feature exact), ['feat*', 'wildcard']].each do |protected_branch_name, protected_branch_type|
823
      context do
824
        before do
825
          create(:protected_branch, :masters_can_push, name: protected_branch_name, project: project)
826
        end
827 828

        run_permission_checks(permissions_matrix)
829 830
      end

831
      context "when developers are allowed to push into the #{protected_branch_type} protected branch" do
832
        before do
833
          create(:protected_branch, :masters_can_push, :developers_can_push, name: protected_branch_name, project: project)
834
        end
835

836 837 838
        run_permission_checks(permissions_matrix.deep_merge(developer: { push_protected_branch: true, push_all: true, merge_into_protected_branch: true }))
      end

839
      context "developers are allowed to merge into the #{protected_branch_type} protected branch" do
840
        before do
841
          create(:protected_branch, :masters_can_push, :developers_can_merge, name: protected_branch_name, project: project)
842
        end
843 844 845 846

        context "when a merge request exists for the given source/target branch" do
          context "when the merge request is in progress" do
            before do
847
              create(:merge_request, source_project: project, source_branch: unprotected_branch, target_branch: 'feature',
Timothy Andrew's avatar
Timothy Andrew committed
848
                                     state: 'locked', in_progress_merge_commit_sha: merge_into_protected_branch)
849
            end
850

851 852
            run_permission_checks(permissions_matrix.deep_merge(developer: { merge_into_protected_branch: true }))
          end
853

854 855 856
          context "when the merge request is not in progress" do
            before do
              create(:merge_request, source_project: project, source_branch: unprotected_branch, target_branch: 'feature', in_progress_merge_commit_sha: nil)
857
            end
858 859

            run_permission_checks(permissions_matrix.deep_merge(developer: { merge_into_protected_branch: false }))
860
          end
861

862
          context "when a merge request does not exist for the given source/target branch" do
863
            run_permission_checks(permissions_matrix.deep_merge(developer: { merge_into_protected_branch: false }))
864 865
          end
        end
866 867
      end

868
      context "when developers are allowed to push and merge into the #{protected_branch_type} protected branch" do
869
        before do
870
          create(:protected_branch, :masters_can_push, :developers_can_merge, :developers_can_push, name: protected_branch_name, project: project)
871
        end
872 873

        run_permission_checks(permissions_matrix.deep_merge(developer: { push_protected_branch: true, push_all: true, merge_into_protected_branch: true }))
874
      end
875

876 877 878
      context "user-specific access control" do
        context "when a specific user is allowed to push into the #{protected_branch_type} protected branch" do
          let(:user) { create(:user) }
879

880
          before do
881
            create(:protected_branch, authorize_user_to_push: user, name: protected_branch_name, project: project)
882 883 884 885 886
          end

          run_permission_checks(permissions_matrix.deep_merge(developer: { push_protected_branch: true, push_all: true, merge_into_protected_branch: true },
                                                              guest: { push_protected_branch: false, merge_into_protected_branch: false },
                                                              reporter: { push_protected_branch: false, merge_into_protected_branch: false }))
887 888
        end

889 890
        context "when a specific user is allowed to merge into the #{protected_branch_type} protected branch" do
          let(:user) { create(:user) }
891

892 893
          before do
            create(:merge_request, source_project: project, source_branch: unprotected_branch, target_branch: 'feature', state: 'locked', in_progress_merge_commit_sha: merge_into_protected_branch)
894
            create(:protected_branch, authorize_user_to_merge: user, name: protected_branch_name, project: project)
895
          end
896

897 898 899 900 901
          run_permission_checks(permissions_matrix.deep_merge(admin: { push_protected_branch: false, push_all: false, merge_into_protected_branch: true },
                                                              master: { push_protected_branch: false, push_all: false, merge_into_protected_branch: true },
                                                              developer: { push_protected_branch: false, push_all: false, merge_into_protected_branch: true },
                                                              guest: { push_protected_branch: false, merge_into_protected_branch: false },
                                                              reporter: { push_protected_branch: false, merge_into_protected_branch: false }))
902 903
        end

904 905 906 907 908
        context "when a specific user is allowed to push & merge into the #{protected_branch_type} protected branch" do
          let(:user) { create(:user) }

          before do
            create(:merge_request, source_project: project, source_branch: unprotected_branch, target_branch: 'feature', state: 'locked', in_progress_merge_commit_sha: merge_into_protected_branch)
909
            create(:protected_branch, authorize_user_to_push: user, authorize_user_to_merge: user, name: protected_branch_name, project: project)
910 911 912 913 914 915
          end

          run_permission_checks(permissions_matrix.deep_merge(developer: { push_protected_branch: true, push_all: true, merge_into_protected_branch: true },
                                                              guest: { push_protected_branch: false, merge_into_protected_branch: false },
                                                              reporter: { push_protected_branch: false, merge_into_protected_branch: false }))
        end
916 917
      end

918 919 920 921 922 923 924
      context "group-specific access control" do
        context "when a specific group is allowed to push into the #{protected_branch_type} protected branch" do
          let(:user) { create(:user) }
          let(:group) { create(:group) }

          before do
            group.add_master(user)
925
            create(:protected_branch, authorize_group_to_push: group, name: protected_branch_name, project: project)
926 927 928 929 930
          end

          permissions = permissions_matrix.except(:admin).deep_merge(developer: { push_protected_branch: true, push_all: true, merge_into_protected_branch: true },
                                                                     guest: { push_protected_branch: false, merge_into_protected_branch: false },
                                                                     reporter: { push_protected_branch: false, merge_into_protected_branch: false })
931

932
          run_group_permission_checks(permissions)
933 934
        end

935 936 937 938 939 940 941
        context "when a specific group is allowed to merge into the #{protected_branch_type} protected branch" do
          let(:user) { create(:user) }
          let(:group) { create(:group) }

          before do
            group.add_master(user)
            create(:merge_request, source_project: project, source_branch: unprotected_branch, target_branch: 'feature', state: 'locked', in_progress_merge_commit_sha: merge_into_protected_branch)
942
            create(:protected_branch, authorize_group_to_merge: group, name: protected_branch_name, project: project)
943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959
          end

          permissions = permissions_matrix.except(:admin).deep_merge(master: { push_protected_branch: false, push_all: false, merge_into_protected_branch: true },
                                                                     developer: { push_protected_branch: false, push_all: false, merge_into_protected_branch: true },
                                                                     guest: { push_protected_branch: false, merge_into_protected_branch: false },
                                                                     reporter: { push_protected_branch: false, merge_into_protected_branch: false })

          run_group_permission_checks(permissions)
        end

        context "when a specific group is allowed to push & merge into the #{protected_branch_type} protected branch" do
          let(:user) { create(:user) }
          let(:group) { create(:group) }

          before do
            group.add_master(user)
            create(:merge_request, source_project: project, source_branch: unprotected_branch, target_branch: 'feature', state: 'locked', in_progress_merge_commit_sha: merge_into_protected_branch)
960
            create(:protected_branch, authorize_group_to_push: group, authorize_group_to_merge: group, name: protected_branch_name, project: project)
961 962 963 964 965 966 967 968
          end

          permissions = permissions_matrix.except(:admin).deep_merge(developer: { push_protected_branch: true, push_all: true, merge_into_protected_branch: true },
                                                                     guest: { push_protected_branch: false, merge_into_protected_branch: false },
                                                                     reporter: { push_protected_branch: false, merge_into_protected_branch: false })

          run_group_permission_checks(permissions)
        end
969 970
      end

971
      context "when no one is allowed to push to the #{protected_branch_name} protected branch" do
972
        before do
973
          create(:protected_branch, :no_one_can_push, name: protected_branch_name, project: project)
974
        end
975 976

        run_permission_checks(permissions_matrix.deep_merge(developer: { push_protected_branch: false, push_all: false, merge_into_protected_branch: false },
977 978
                                                            master: { push_protected_branch: false, push_all: false, merge_into_protected_branch: false },
                                                            admin: { push_protected_branch: false, push_all: false, merge_into_protected_branch: false }))
979
      end
980
    end
981

982
    describe "push_rule_check" do
983 984 985
      let(:start_sha) { '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9' }
      let(:end_sha)   { '570e7b2abdd848b95f2f578043fc23bd6f6fd24d' }

986
      before do
987
        project.add_developer(user)
988

989 990
        allow(project.repository).to receive(:new_commits)
          .and_return(project.repository.commits_between(start_sha, end_sha))
991
      end
992

993 994
      describe "author email check" do
        it 'returns true' do
995
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.not_to raise_error
996
        end
997

998
        it 'returns false' do
999
          project.create_push_rule(commit_message_regex: "@only.com")
1000

1001
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.to raise_error(described_class::UnauthorizedError)
1002
        end
1003

1004
        it 'returns true for tags' do
1005
          project.create_push_rule(commit_message_regex: "@only.com")
1006

1007
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/tags/v1") }.not_to raise_error
1008
        end
1009

1010 1011 1012 1013 1014
        it 'allows githook for new branch with an old bad commit' do
          bad_commit = double("Commit", safe_message: 'Some change').as_null_object
          ref_object = double(name: 'heads/master')
          allow(bad_commit).to receive(:refs).and_return([ref_object])
          allow_any_instance_of(Repository).to receive(:commits_between).and_return([bad_commit])
1015

1016
          project.create_push_rule(commit_message_regex: "Change some files")
1017

1018
          # push to new branch, so use a blank old rev and new ref
1019
          expect { access.send(:check_push_access!, "#{Gitlab::Git::BLANK_SHA} #{end_sha} refs/heads/new-branch") }.not_to raise_error
1020
        end
1021

1022 1023 1024 1025
        it 'allows githook for any change with an old bad commit' do
          bad_commit = double("Commit", safe_message: 'Some change').as_null_object
          ref_object = double(name: 'heads/master')
          allow(bad_commit).to receive(:refs).and_return([ref_object])
1026
          allow(project.repository).to receive(:commits_between).and_return([bad_commit])
1027

1028
          project.create_push_rule(commit_message_regex: "Change some files")
1029

1030
          # push to new branch, so use a blank old rev and new ref
1031
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.not_to raise_error
1032
        end
Robert Speicher's avatar
Robert Speicher committed
1033

1034 1035 1036 1037 1038
        it 'does not allow any change from Web UI with bad commit' do
          bad_commit = double("Commit", safe_message: 'Some change').as_null_object
          # We use tmp ref a a temporary for Web UI commiting
          ref_object = double(name: 'refs/tmp')
          allow(bad_commit).to receive(:refs).and_return([ref_object])
1039 1040
          allow(project.repository).to receive(:commits_between).and_return([bad_commit])
          allow(project.repository).to receive(:new_commits).and_return([bad_commit])
1041

1042
          project.create_push_rule(commit_message_regex: "Change some files")
1043

1044
          # push to new branch, so use a blank old rev and new ref
1045
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.to raise_error(described_class::UnauthorizedError)
1046
        end
1047
      end
1048

1049 1050
      describe "member_check" do
        before do
1051
          project.create_push_rule(member_check: true)
1052
        end
1053

1054
        it 'returns false for non-member user' do
1055
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.to raise_error(described_class::UnauthorizedError)
1056
        end
1057

1058 1059
        it 'returns true if committer is a gitlab member' do
          create(:user, email: 'dmitriy.zaporozhets@gmail.com')
1060

1061
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.not_to raise_error
1062
        end
1063 1064
      end

1065
      describe "file names check" do
1066 1067 1068
        let(:start_sha) { '913c66a37b4a45b9769037c55c2d238bd0942d2e' }
        let(:end_sha)   { '33f3729a45c02fc67d00adb1b8bca394b0e761d9' }

1069
        before do
1070 1071
          allow(project.repository).to receive(:new_commits)
            .and_return(project.repository.commits_between(start_sha, end_sha))
1072 1073
        end

1074
        it 'returns false when filename is prohibited' do
1075
          project.create_push_rule(file_name_regex: "jpg$")
1076

1077
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.to raise_error(described_class::UnauthorizedError)
1078
        end
1079

1080
        it 'returns true if file name is allowed' do
1081
          project.create_push_rule(file_name_regex: "exe$")
1082

1083
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.not_to raise_error
1084
        end
1085 1086
      end

1087
      describe "max file size check" do
1088 1089 1090
        let(:start_sha) { 'cfe32cf61b73a0d5e9f13e774abde7ff789b1660' }
        let(:end_sha)   { '913c66a37b4a45b9769037c55c2d238bd0942d2e' }

1091 1092
        before do
          allow_any_instance_of(Gitlab::Git::Blob).to receive(:size).and_return(1.5.megabytes.to_i)
1093 1094
        end

1095
        it "returns false when size is too large" do
1096
          project.create_push_rule(max_file_size: 1)
1097

1098
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.to raise_error(described_class::UnauthorizedError)
1099 1100
        end

1101
        it "returns true when size is allowed" do
1102
          project.create_push_rule(max_file_size: 2)
1103

1104
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.not_to raise_error
1105
        end
1106

1107 1108
        it "returns true when size is nil" do
          allow_any_instance_of(Gitlab::Git::Blob).to receive(:size).and_return(nil)
1109
          project.create_push_rule(max_file_size: 2)
1110

1111
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.not_to raise_error
1112
        end
1113
      end
1114 1115 1116

      describe 'repository size restrictions' do
        before do
1117
          project.update_attribute(:repository_size_limit, 50.megabytes)
1118 1119 1120 1121 1122
        end

        it 'returns false when blob is too big' do
          allow_any_instance_of(Gitlab::Git::Blob).to receive(:size).and_return(100.megabytes.to_i)

1123
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.to raise_error(described_class::UnauthorizedError)
1124 1125 1126 1127 1128
        end

        it 'returns true when blob is just right' do
          allow_any_instance_of(Gitlab::Git::Blob).to receive(:size).and_return(2.megabytes.to_i)

1129
          expect { access.send(:check_push_access!, "#{start_sha} #{end_sha} refs/heads/master") }.not_to raise_error
1130 1131
        end
      end
1132
    end
1133
  end
1134

1135 1136
  describe 'build authentication abilities' do
    let(:authentication_abilities) { build_authentication_abilities }
1137

Kamil Trzcinski's avatar
Kamil Trzcinski committed
1138
    context 'when project is authorized' do
1139
      before do
1140
        project.add_reporter(user)
1141
      end
1142

1143
      it { expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:auth_upload]) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
1144
    end
1145

Kamil Trzcinski's avatar
Kamil Trzcinski committed
1146 1147
    context 'when unauthorized' do
      context 'to public project' do
1148
        let(:project) { create(:project, :public, :repository) }
1149

1150
        it { expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:auth_upload]) }
1151
      end
1152

Kamil Trzcinski's avatar
Kamil Trzcinski committed
1153
      context 'to internal project' do
1154
        let(:project) { create(:project, :internal, :repository) }
1155

1156
        it { expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:auth_upload]) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
1157
      end
1158

Kamil Trzcinski's avatar
Kamil Trzcinski committed
1159
      context 'to private project' do
1160
        let(:project) { create(:project, :private, :repository) }
1161

1162
        it { expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:auth_upload]) }
1163 1164
      end
    end
1165
  end
1166 1167

  context 'when the repository is read only' do
1168
    let(:project) { create(:project, :repository, :read_only) }
1169

1170
    it 'denies push access' do
1171
      project.add_master(user)
1172

1173
      expect { push_access_check }.to raise_unauthorized('The repository is temporarily read-only. Please try again later.')
1174 1175
    end
  end
1176

Kamil Trzcinski's avatar
Kamil Trzcinski committed
1177
  describe 'deploy key permissions' do
1178
    let(:key) { create(:deploy_key, user: user) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
1179 1180
    let(:actor) { key }

1181
    context 'when deploy_key can push' do
1182
      context 'when project is authorized' do
1183
        before do
1184
          key.deploy_keys_projects.create(project: project, can_push: true)
1185
        end
1186 1187 1188 1189 1190 1191 1192 1193

        it { expect { push_access_check }.not_to raise_error }
      end

      context 'when unauthorized' do
        context 'to public project' do
          let(:project) { create(:project, :public, :repository) }

1194
          it { expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:deploy_key_upload]) }
1195 1196 1197 1198 1199
        end

        context 'to internal project' do
          let(:project) { create(:project, :internal, :repository) }

1200
          it { expect { push_access_check }.to raise_not_found }
1201 1202 1203 1204 1205
        end

        context 'to private project' do
          let(:project) { create(:project, :private, :repository) }

1206
          it { expect { push_access_check }.to raise_not_found }
1207 1208 1209 1210 1211
        end
      end
    end

    context 'when deploy_key cannot push' do
1212
      context 'when project is authorized' do
1213
        before do
1214
          key.deploy_keys_projects.create(project: project, can_push: false)
1215
        end
1216

1217
        it { expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:deploy_key_upload]) }
1218 1219 1220 1221 1222 1223
      end

      context 'when unauthorized' do
        context 'to public project' do
          let(:project) { create(:project, :public, :repository) }

1224
          it { expect { push_access_check }.to raise_unauthorized(described_class::ERROR_MESSAGES[:deploy_key_upload]) }
1225 1226 1227 1228 1229
        end

        context 'to internal project' do
          let(:project) { create(:project, :internal, :repository) }

1230
          it { expect { push_access_check }.to raise_not_found }
1231 1232 1233 1234 1235
        end

        context 'to private project' do
          let(:project) { create(:project, :private, :repository) }

1236
          it { expect { push_access_check }.to raise_not_found }
1237
        end
Kamil Trzcinski's avatar
Kamil Trzcinski committed
1238 1239
      end
    end
Kamil Trzcinski's avatar
Kamil Trzcinski committed
1240 1241
  end

1242 1243 1244 1245 1246 1247 1248
  describe 'Geo system permissions' do
    let(:actor) { :geo }

    it { expect { pull_access_check }.not_to raise_error }
    it { expect { push_access_check }.to raise_unauthorized(Gitlab::GitAccess::ERROR_MESSAGES[:upload]) }
  end

Kamil Trzcinski's avatar
Kamil Trzcinski committed
1249 1250
  private

1251 1252 1253 1254
  def raise_unauthorized(message)
    raise_error(Gitlab::GitAccess::UnauthorizedError, message)
  end

1255
  def raise_not_found
1256
    raise_error(Gitlab::GitAccess::NotFoundError, Gitlab::GitAccess::ERROR_MESSAGES[:project_not_found])
1257 1258
  end

1259
  def build_authentication_abilities
Kamil Trzcinski's avatar
Kamil Trzcinski committed
1260 1261 1262 1263 1264
    [
      :read_project,
      :build_download_code
    ]
  end
1265

1266
  def full_authentication_abilities
1267 1268 1269 1270 1271 1272
    [
      :read_project,
      :download_code,
      :push_code
    ]
  end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1273
end