Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Repository
  • gitlab-ce
  • app
  • controllers
  • projects
  • cycle_analytics_controller.rb
Find file BlameHistoryPermalink
  • Douwe Maan's avatar
    Merge branch 'jej-fix-missing-access-check-on-issues' into 'security' · 6d37fe95
    Douwe Maan authored Nov 18, 2016
    Fix missing access checks on issue lookup using IssuableFinder
    
    Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867
    
    ⚠ - Potentially untested
    💣 - No test coverage
    🚥 - Test coverage of some sort exists (a test failed when error raised)
    🚦 - Test coverage of return value (a test failed when nil used)
    ✅ - Permissions check tested
    
    - [x] ✅ app/controllers/projects/branches_controller.rb:39
      - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with
        confidential issues, issues only visible to team, etc.
    - [x] 🚥 app/models/cycle_analytics/summary.rb:9 [`.count`]
    - [x] ✅ app/controllers/projects/todos_controller.rb:19
    
    - [x] Potential double render in app/controllers/projects/todos_controller.rb
    
    - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24
    
    See merge request !2030
    6d37fe95
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7