Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Repository
  • gitlab-ce
  • spec
  • javascripts
  • lib
  • utils
  • common_utils_spec.js.es6
Find file BlameHistoryPermalink
  • Fatih Acet's avatar
    Merge branch 'fix-compatibility-with-ie11-for-merge-requests' into 'master' · 1a4c8eba
    Fatih Acet authored Dec 05, 2016
    Fix compatibility with Internet Explorer 11 for merge requests
    
    ## What does this MR do?
    This merge request restores the compatibility with Internet Explorer 11.
    
    ## Are there points in the code the reviewer needs to double check?
    No.
    
    ## Why was this MR needed?
    Commit ca3c0c6c introduced an incompatibility with Internet Explorer 11. On all merge requests in all projects the 'Changes' tab does not display the changes in IE11 but instead fails with 'Something went wrong on our end'. The reason ist, that this code snipped produces different results on Firefox and Internet Explorer 11:
    
    ```
    var element = document.createElement('a');
    element.href = '/some/absolute/url';
    alert(element.pathname);
    ```
    
    With Internet Explorer 11 the alert will print a relative path, whereas with Firefox the alert will print an absolute path. For GitLab this meant that a wrong AJAX URL was composed which resulted in a 404.
    
    ## Screenshots (if relevant)
    None.
    
    ## Does this MR meet the acceptance criteria?
    
    - [X] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
    - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
    - [ ] API support added
    - Tests
      - [X] Added for this feature/bug
      - [ ] All builds are passing
    - [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
    - [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
    - [X] Branch has no merge conflicts with `master` (if it does - rebase it please)
    - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
    
    ## What are the relevant issue numbers?
    #23977 
    #24380
    
    See merge request !7525
    1a4c8eba
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7