• Fatih Acet's avatar
    Merge branch 'trim-new-user' into 'master' · 2208a878
    Fatih Acet authored
    Ensure that whitespace doesn't cause adding members to fail
    
    I recently had to debug an issue where adding users wasn't working. It turned out that I was hitting "space" to confirm a `select2` dialog, and the server would throw out the whole email address because it was invalid. It looked as though GitLab was entirely ignoring my add-member request.
    
    Here's a fun gif:
    ![out](/uploads/5c306addb764067bca54add3b7a53c6c/out.gif)
    
    Ideally, there should also be validation client-side, so that the server doesn't need to silently fail, and the user will know what's going wrong. I'll look into creating an issue for that.
    
    Additionally, GitLab already seems to trim email addresses, sometimes? If you add _two_ address, with spaces, then the `value` of the `user_ids` DOM element will have the first `n-1` addresses without spaces. Weird.
    
    **TL;DR: Now spaces are always trimmed from new-member email addresses.**
    
    See merge request !3443
    2208a878
To find the state of this project's repository at the time of any of these versions, check out the tags.
CHANGELOG 134 KB