Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Repository
  • gitlab-ce
  • lib
  • gitlab
  • git
  • base_error.rb
Find file BlameHistoryPermalink
  • Stan Hu's avatar
    Strip gRPC debug_error_string from Gitaly exceptions · 1384c4a0
    Stan Hu authored Sep 02, 2020
    This reverts https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40938
    because it wasn't actually working when gRPC exceptions were wrapped in
    `Gitlab::Git::CommandError` via `wrapped_gitaly_errors`.
    
    A much simpler approach is to strip `debug_error_string` when a
    `Gitlab::Git::BaseError` is created. With this change, we have
    effectively the same exception strings as we did before the upgrade of
    gRPC.
    
    Note that it appears Sentry retains a backtrace of the original gRPC
    exception that contains the `debug_error_string`, so if we really want
    to look at it the information is still there.
    
    This should solve https://gitlab.com/gitlab-org/gitlab/-/issues/238465.
    1384c4a0
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7