Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Repository
You need to sign in or sign up before continuing.
  • gitlab-ce
  • lib
  • api
  • projects.rb
Find file BlameHistoryPermalink
  • Rémy Coutable's avatar
    Merge branch 'api-fix-project-group-sharing' into 'security' · 670b2eb5
    Rémy Coutable authored Oct 11, 2016
    API: Share projects only with groups current_user can access
    
    Aims to address the issues here: https://gitlab.com/gitlab-org/gitlab-ce/issues/23004
    
    * Projects can be shared with non-existent groups
    * Projects can be shared with groups that the current user does not have access to read
    
    Concerns:
    
    The new implementation of the API endpoint allows projects to be shared with a larger range of groups than can be done via the web UI.
    
    The form for sharing a project with a group uses the following API endpoint to index the available groups: https://gitlab.com/gitlab-org/gitlab-ce/blob/494269fc92f61098ee6bd635a0426129ce2c5456/lib/api/groups.rb#L17
    
    . The groups indexed in the web form will only be those groups that the user is currently a member of.
    
    The new implementation allows projects to be shared with any group that the authenticated user has access to view. This widens the range of groups to those that are public and internal.
    
    See merge request !2005
    
    Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
    670b2eb5
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7