Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Repository
  • gitlab-ce
  • app
  • views
  • projects
  • generic_commit_statuses
  • _generic_commit_status_pipeline.html....
Find file BlameHistoryPermalink
  • Annabel Dunstone Gray's avatar
    Merge branch 'ci-style-tweaks-8.14' into 'master' · ac129ef8
    Annabel Dunstone Gray authored Nov 22, 2016
    Last minute CI Style tweaks for 8.14
    
    ## What does this MR do?
    - Skipped builds now have use a lighter gray.
    - Converted all status icons to be managed by scss colors only
    - Consolidated all status icon styles into icons.scss
    - Deleted any classes or styles within the svg's
    - Gave status badges a hover style, but only if clickable
    - Fixed alignment issue mini-pipeline graph
    
    ## Are there points in the code the reviewer needs to double check?
    
    ## Why was this MR needed?
    As per the discussion in the slack chat https://gitlab.slack.com/archives/ci/p1479743986004879
    
    ## Screenshots (if relevant)
    - skipped builds:
    ![image](/uploads/f59c615045472b9b13940463a64c8038/image.png)
    ![image](/uploads/26503d1da9c93b3c22c5c0c1369feceb/image.png)
    
    - hover style status badges:
    ![2016-11-22_00.21.27](/uploads/36afa7aa64d60e1755bf39d97f90c59f/2016-11-22_00.21.27.gif)![2016-11-22_00.58.38](/uploads/1d95fa5db124412d3f83b3e79b9b71ec/2016-11-22_00.58.38.gif)
    
    - mini pipeline graph:
    
    before:
    ![image](/uploads/38e5e57ada3907b17c6e24e1446b4514/image.png)
    
    
    after:
    ![image](/uploads/de4476693a1397eebfc680661159daf7/image.png)
    
    
    ## Does this MR meet the acceptance criteria?
    
    - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
    - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
    - [ ] API support added
    - Tests
      - [ ] Added for this feature/bug
      - [ ] All builds are passing
    - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
    - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
    - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
    - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
    
    ## What are the relevant issue numbers?
    
    See merge request !7643
    ac129ef8
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7