Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
G gitlab-ce
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedi
  • gitlab-ce
  • Repository

Switch branch/tag
  • gitlab-ce
  • testdata
  • file-ä.pdf
Find file HistoryPermalink
  • Stan Hu's avatar
    Support encoded Content-Disposition fields · c3cf9c0f
    Stan Hu authored Feb 05, 2019
    https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24919/diffs adds
    support for Rails sending the right `Content-Disposition` header when
    there are non-ASCII filenames (e.g. `テスト.txt`). That example file
    would render the following Content-Disposition:
    
    ```
    attachment; filename="テスト.txt", filename*=UTF-8''%E3%83%86%E3%82%B9%E3%83%88.txt
    ```
    
    Since mime.ParseMediaType appears to strip this header to a canonical
    filename, it's not possible to use this to generate the right
    Content-Disposition. Instead, we can preserve the existing
    Content-Disposition and convert types just by doing a search and replace
    (i.e. change `attachment` to `inline` and vice versa when necessary).
    
    Closes https://gitlab.com/gitlab-org/gitlab-workhorse/issues/207
    c3cf9c0f
file-ä.pdf 420 Bytes

Download (420 Bytes)

Replace file-ä.pdf

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7