Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedi
  • gitlab-ce
  • Repository

Switch branch/tag
  • gitlab-ce
  • app
  • models
  • user.rb
Find file BlameHistoryPermalink
  • Douwe Maan's avatar
    Merge branch '23662-issue-move-user-reference-exception' into 'master' · e6d6c415
    Douwe Maan authored Oct 25, 2016
    Fix `User#to_reference`
    
    Fix the method signature of `User#to_reference` so that moving an issue with a user reference does not throw a "invalid number of arguments" exception.
    
    1. Changes in 8.13 require `Referable`s that don't have a project
       reference to accept two arguments - `from_project` and
       `target_project`.
    
    2. `User#to_reference` was not changed to accept the
       `target_project` (even though it is not used). Moving an issue
       containing a user reference would throw a "invalid number of
       arguments" exception.
    
    3. The regression was introduced in [c8b2b3f7](https://gitlab.com/gitlab-org/gitlab-ce/commit/c8b2b3f7c32db873f1bebce3e3b1847ea24d235f#91fabb7ad88bd2fde6fef1c100a719c00e503047_75_79
    
    ), which expects
       all `Referable`s that don't respond to `:project` to have a `to_reference`
       method that takes two arguments.
    
    Closes #23662
    
    See merge request !7088
    Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
    e6d6c415

Replace user.rb

Attach a file by drag & drop or click to upload


Cancel
GitLab will create a branch in your fork and start a merge request.
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7