Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Repository
  • gitlab-ce
  • app
  • controllers
  • projects_controller.rb
Find file BlameHistoryPermalink
  • Stan Hu's avatar
    Fix incorrect project path warning after failed project path rename · f841efb8
    Stan Hu authored Aug 25, 2020
    If an update to the project path fails validation, the unsaved
    attributes would still be presented because the controller would fall
    through and call `render` on the unsaved object. This resulted in the
    wrong project path being displayed in the "Delete project"
    warning. However, unlike with
    https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40353, changes in
    `Project#to_param` in ea4d6c87 prevented
    the wrong project path from being deleted.
    
    While it may have been intentional to retain the failed values, it's
    better to be safe and reset all the values back to their persisted
    state.
    
    Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/241110
    f841efb8
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7