Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0058066c
Commit
0058066c
authored
Apr 26, 2021
by
David Fernandez
Committed by
Arturo Herrero
Apr 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable `check_maven_path_first` by default
parent
2499808c
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
3 deletions
+8
-3
changelogs/unreleased/327487-enable-by-default.yml
changelogs/unreleased/327487-enable-by-default.yml
+5
-0
config/feature_flags/development/check_maven_path_first.yml
config/feature_flags/development/check_maven_path_first.yml
+1
-1
lib/api/maven_packages.rb
lib/api/maven_packages.rb
+1
-1
spec/requests/api/maven_packages_spec.rb
spec/requests/api/maven_packages_spec.rb
+1
-1
No files found.
changelogs/unreleased/327487-enable-by-default.yml
0 → 100644
View file @
0058066c
---
title
:
Improve the Maven API file endpoints response time when a non existing package is requested
merge_request
:
60142
author
:
type
:
performance
config/feature_flags/development/check_maven_path_first.yml
View file @
0058066c
...
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/327487
milestone
:
'
13.11'
type
:
development
group
:
group::package
default_enabled
:
fals
e
default_enabled
:
tru
e
lib/api/maven_packages.rb
View file @
0058066c
...
...
@@ -25,7 +25,7 @@ module API
helpers
do
def
path_exists?
(
path
)
# return true when FF disabled so that processing the request is not stopped
return
true
unless
Feature
.
enabled?
(
:check_maven_path_first
)
return
true
unless
Feature
.
enabled?
(
:check_maven_path_first
,
default_enabled: :yaml
)
return
false
if
path
.
blank?
Packages
::
Maven
::
Metadatum
.
with_path
(
path
)
...
...
spec/requests/api/maven_packages_spec.rb
View file @
0058066c
...
...
@@ -49,7 +49,7 @@ RSpec.describe API::MavenPackages do
shared_examples
'rejecting the request for non existing maven path'
do
|
expected_status: :not_found
|
before
do
if
Feature
.
enabled?
(
:check_maven_path_first
)
if
Feature
.
enabled?
(
:check_maven_path_first
,
default_enabled: :yaml
)
expect
(
::
Packages
::
Maven
::
PackageFinder
).
not_to
receive
(
:new
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment