Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
01d29d43
Commit
01d29d43
authored
Apr 05, 2021
by
Huzaifa Iftikhar
Committed by
Robert Speicher
Apr 05, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix EmptyLineAfterFinalLetItBe Rubocop offenses for groups controller
parent
54a38df8
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
12 additions
and
4 deletions
+12
-4
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-4
changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-groups-controller.yml
...5836-fix-empty-line-after-let-it-be-groups-controller.yml
+5
-0
spec/controllers/groups/dependency_proxy_auth_controller_spec.rb
...ntrollers/groups/dependency_proxy_auth_controller_spec.rb
+2
-0
spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb
...groups/dependency_proxy_for_containers_controller_spec.rb
+3
-0
spec/controllers/groups/registry/repositories_controller_spec.rb
...ntrollers/groups/registry/repositories_controller_spec.rb
+1
-0
spec/controllers/groups/variables_controller_spec.rb
spec/controllers/groups/variables_controller_spec.rb
+1
-0
No files found.
.rubocop_manual_todo.yml
View file @
01d29d43
...
...
@@ -893,10 +893,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
-
ee/spec/workers/set_user_status_based_on_user_cap_setting_worker_spec.rb
-
spec/controllers/confirmations_controller_spec.rb
-
spec/controllers/dashboard/projects_controller_spec.rb
-
spec/controllers/groups/dependency_proxy_auth_controller_spec.rb
-
spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb
-
spec/controllers/groups/registry/repositories_controller_spec.rb
-
spec/controllers/groups/variables_controller_spec.rb
-
spec/controllers/invites_controller_spec.rb
-
spec/controllers/profiles/emails_controller_spec.rb
-
spec/controllers/projects/alerting/notifications_controller_spec.rb
...
...
changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-groups-controller.yml
0 → 100644
View file @
01d29d43
---
title
:
Fix EmptyLineAfterFinalLetItBe Rubocop offenses for groups controller
merge_request
:
58174
author
:
Huzaifa Iftikhar @huzaifaiftikhar
type
:
fixed
spec/controllers/groups/dependency_proxy_auth_controller_spec.rb
View file @
01d29d43
...
...
@@ -31,6 +31,7 @@ RSpec.describe Groups::DependencyProxyAuthController do
context
'with valid JWT'
do
let_it_be
(
:user
)
{
create
(
:user
)
}
let
(
:jwt
)
{
build_jwt
(
user
)
}
let
(
:token_header
)
{
"Bearer
#{
jwt
.
encoded
}
"
}
...
...
@@ -65,6 +66,7 @@ RSpec.describe Groups::DependencyProxyAuthController do
context
'expired token'
do
let_it_be
(
:user
)
{
create
(
:user
)
}
let
(
:jwt
)
{
build_jwt
(
user
,
expire_time:
Time
.
zone
.
now
-
1
.
hour
)
}
let
(
:token_header
)
{
"Bearer
#{
jwt
.
encoded
}
"
}
...
...
spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb
View file @
01d29d43
...
...
@@ -7,6 +7,7 @@ RSpec.describe Groups::DependencyProxyForContainersController do
include
DependencyProxyHelpers
let_it_be
(
:user
)
{
create
(
:user
)
}
let
(
:group
)
{
create
(
:group
)
}
let
(
:token_response
)
{
{
status: :success
,
token:
'abcd1234'
}
}
let
(
:jwt
)
{
build_jwt
(
user
)
}
...
...
@@ -102,6 +103,7 @@ RSpec.describe Groups::DependencyProxyForContainersController do
describe
'GET #manifest'
do
let_it_be
(
:manifest
)
{
create
(
:dependency_proxy_manifest
)
}
let
(
:pull_response
)
{
{
status: :success
,
manifest:
manifest
}
}
before
do
...
...
@@ -182,6 +184,7 @@ RSpec.describe Groups::DependencyProxyForContainersController do
describe
'GET #blob'
do
let_it_be
(
:blob
)
{
create
(
:dependency_proxy_blob
)
}
let
(
:blob_sha
)
{
blob
.
file_name
.
sub
(
'.gz'
,
''
)
}
let
(
:blob_response
)
{
{
status: :success
,
blob:
blob
}
}
...
...
spec/controllers/groups/registry/repositories_controller_spec.rb
View file @
01d29d43
...
...
@@ -6,6 +6,7 @@ RSpec.describe Groups::Registry::RepositoriesController do
let_it_be
(
:user
)
{
create
(
:user
)
}
let_it_be
(
:guest
)
{
create
(
:user
)
}
let_it_be
(
:group
,
reload:
true
)
{
create
(
:group
)
}
let
(
:additional_parameters
)
{
{}
}
subject
do
...
...
spec/controllers/groups/variables_controller_spec.rb
View file @
01d29d43
...
...
@@ -8,6 +8,7 @@ RSpec.describe Groups::VariablesController do
let_it_be
(
:group
)
{
create
(
:group
)
}
let_it_be
(
:user
)
{
create
(
:user
)
}
let_it_be
(
:variable
)
{
create
(
:ci_group_variable
,
group:
group
)
}
let
(
:access_level
)
{
:owner
}
before
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment