Merge branch 'if-delete_periodic_project_authorization_recalculation_feature_flag' into 'master'

Remove periodic_project_authorization_recalculation feature flag

See merge request gitlab-org/gitlab!42999

app/workers/authorized_project_update/periodic_recalculate_worker.rb

@@ -12,9 +12,7 @@ module AuthorizedProjectUpdate
     idempotent!
 
     def perform
-      if ::Feature.enabled?(:periodic_project_authorization_recalculation, default_enabled: true)
-        AuthorizedProjectUpdate::PeriodicRecalculateService.new.execute
-      end
+      AuthorizedProjectUpdate::PeriodicRecalculateService.new.execute
     end
   end
 end

app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb

@@ -12,9 +12,7 @@ module AuthorizedProjectUpdate
     idempotent!
 
     def perform(start_user_id, end_user_id)
-      if ::Feature.enabled?(:periodic_project_authorization_recalculation, default_enabled: true)
-        AuthorizedProjectUpdate::RecalculateForUserRangeService.new(start_user_id, end_user_id).execute
-      end
+      AuthorizedProjectUpdate::RecalculateForUserRangeService.new(start_user_id, end_user_id).execute
     end
   end
 end

config/feature_flags/development/periodic_project_authorization_recalculation.yml

----
-name: periodic_project_authorization_recalculation
-introduced_by_url: 
-rollout_issue_url: 
-group: 
-type: development
-default_enabled: true

spec/workers/authorized_project_update/periodic_recalculate_worker_spec.rb

@@ -11,17 +11,5 @@ RSpec.describe AuthorizedProjectUpdate::PeriodicRecalculateWorker do
 
       subject.perform
     end
-
-    context 'feature flag :periodic_project_authorization_recalculation is disabled' do
-      before do
-        stub_feature_flags(periodic_project_authorization_recalculation: false)
-      end
-
-      it 'does not call AuthorizedProjectUpdate::PeriodicRecalculateService' do
-        expect(AuthorizedProjectUpdate::PeriodicRecalculateService).not_to receive(:new)
-
-        subject.perform
-      end
-    end
   end
 end

spec/workers/authorized_project_update/user_refresh_over_user_range_worker_spec.rb

@@ -14,17 +14,5 @@ RSpec.describe AuthorizedProjectUpdate::UserRefreshOverUserRangeWorker do
 
       subject.perform(start_user_id, end_user_id)
     end
-
-    context 'feature flag :periodic_project_authorization_recalculation is disabled' do
-      before do
-        stub_feature_flags(periodic_project_authorization_recalculation: false)
-      end
-
-      it 'does not call AuthorizedProjectUpdate::RecalculateForUserRangeService' do
-        expect(AuthorizedProjectUpdate::RecalculateForUserRangeService).not_to receive(:new)
-
-        subject.perform(start_user_id, end_user_id)
-      end
-    end
   end
 end