Commit 04f23d03 authored by Illya Klymov's avatar Illya Klymov

Address reviewer comments

parent eb2b3a36
...@@ -7,14 +7,9 @@ export default { ...@@ -7,14 +7,9 @@ export default {
GlLink, GlLink,
GlSprintf, GlSprintf,
}, },
computed: { paths: {
groupsHelpPath() { groupsHelpPath: helpPagePath('user/group/index'),
return helpPagePath('user/group/index'); subgroupsHelpPath: helpPagePath('user/group/subgroups/index'),
},
subgroupsHelpPath() {
return helpPagePath('user/group/subgroups/index');
},
}, },
}; };
</script> </script>
...@@ -30,7 +25,7 @@ export default { ...@@ -30,7 +25,7 @@ export default {
" "
> >
<template #link="{ content }"> <template #link="{ content }">
<gl-link :href="groupsHelpPath" target="_blank">{{ content }}</gl-link> <gl-link :href="$options.paths.groupsHelpPath" target="_blank">{{ content }}</gl-link>
</template> </template>
</gl-sprintf> </gl-sprintf>
</p> </p>
...@@ -41,7 +36,7 @@ export default { ...@@ -41,7 +36,7 @@ export default {
" "
> >
<template #link="{ content }"> <template #link="{ content }">
<gl-link :href="subgroupsHelpPath" target="_blank">{{ content }}</gl-link> <gl-link :href="$options.paths.subgroupsHelpPath" target="_blank">{{ content }}</gl-link>
</template> </template>
</gl-sprintf> </gl-sprintf>
</p> </p>
......
...@@ -129,7 +129,7 @@ export default { ...@@ -129,7 +129,7 @@ export default {
<gl-icon name="chevron-right" :size="8" /> <gl-icon name="chevron-right" :size="8" />
</template> </template>
</gl-breadcrumb> </gl-breadcrumb>
<legacy-container :key="activePanel.name" class="gl-mt-3" :selector="activePanel.selector" /> <legacy-container :key="activePanel.name" :selector="activePanel.selector" />
</div> </div>
</div> </div>
</template> </template>
...@@ -22,6 +22,6 @@ ...@@ -22,6 +22,6 @@
.col-sm-4 .col-sm-4
= recaptcha_tags = recaptcha_tags
.row .row
.form-actions.col-sm-12 .col-sm-12
= f.submit _('Create group'), class: "btn gl-button btn-confirm" = f.submit _('Create group'), class: "btn gl-button btn-confirm"
= link_to _('Cancel'), dashboard_groups_path, class: 'btn gl-button btn-default btn-cancel' = link_to _('Cancel'), dashboard_groups_path, class: 'btn gl-button btn-default btn-cancel'
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment