Merge branch 'eugie/remove-include-url-helper' into 'master'

Do not include ActionView::Helpers::UrlHelper

See merge request gitlab-org/gitlab!71172

.rubocop_manual_todo.yml

@@ -2603,7 +2603,6 @@ Rails/IncludeUrlHelper:
     - 'ee/spec/lib/banzai/filter/cross_project_issuable_information_filter_spec.rb'
     - 'ee/spec/lib/banzai/filter/issuable_state_filter_spec.rb'
     - 'lib/gitlab/ci/badge/metadata.rb'
-    - 'lib/gitlab/email/message/in_product_marketing/helper.rb'
     - 'spec/helpers/merge_requests_helper_spec.rb'
     - 'spec/helpers/nav/top_nav_helper_spec.rb'
     - 'spec/helpers/notify_helper_spec.rb'

lib/gitlab/email/message/in_product_marketing/base.rb

@@ -50,7 +50,7 @@ module Gitlab
           def cta_link
             case format
             when :html
-              link_to cta_text, group_email_campaigns_url(group, track: track, series: series), target: '_blank', rel: 'noopener noreferrer'
+              ActionController::Base.helpers.link_to cta_text, group_email_campaigns_url(group, track: track, series: series), target: '_blank', rel: 'noopener noreferrer'
             else
               [cta_text, group_email_campaigns_url(group, track: track, series: series)].join(' >> ')
             end
@@ -89,7 +89,7 @@ module Gitlab
             case format
             when :html
               links.map do |text, link|
-                link_to(text, link)
+                ActionController::Base.helpers.link_to(text, link)
               end
             else
               '| ' + links.map do |text, link|

lib/gitlab/email/message/in_product_marketing/helper.rb

@@ -7,7 +7,6 @@ module Gitlab
         module Helper
           include ActionView::Context
           include ActionView::Helpers::TagHelper
-          include ActionView::Helpers::UrlHelper
 
           private
 
@@ -32,7 +31,7 @@ module Gitlab
           def link(text, link)
             case format
             when :html
-              link_to text, link
+              ActionController::Base.helpers.link_to text, link
             else
               "#{text} (#{link})"
             end