Merge branch '25145-remove-expand-sha-button-pipeline' into 'master'

Remove unnecessary expand sha button

See merge request gitlab-org/gitlab!47012

app/assets/javascripts/behaviors/index.js

@@ -4,7 +4,6 @@ import './bind_in_out';
 import './markdown/render_gfm';
 import initCopyAsGFM from './markdown/copy_as_gfm';
 import initCopyToClipboard from './copy_to_clipboard';
-import './details_behavior';
 import installGlEmojiElement from './gl_emoji';
 import './quick_submit';
 import './requires_input';

app/assets/javascripts/projects/commit_box/info/index.js

 import { loadBranches } from './load_branches';
+import { initDetailsButton } from './init_details_button';
 import { fetchCommitMergeRequests } from '~/commit_merge_requests';
 import MiniPipelineGraph from '~/mini_pipeline_graph_dropdown';
 
@@ -15,4 +16,6 @@ export const initCommitBoxInfo = (containerSelector = '.js-commit-box-info') =>
   new MiniPipelineGraph({
     container: '.js-commit-pipeline-graph',
   }).bindEvents();
+
+  initDetailsButton();
 };

app/assets/javascripts/behaviors/details_behavior.js → app/assets/javascripts/projects/commit_box/info/init_details_button.js

 import $ from 'jquery';
 
-$(() => {
-  $('body').on('click', '.js-details-target', function target() {
-    $(this)
-      .closest('.js-details-container')
-      .toggleClass('open');
-  });
-
-  // Show details content. Hides link after click.
-  //
-  // %div
-  //   %a.js-details-expand
-  //   %div.js-details-content
-  //
+export const initDetailsButton = () => {
   $('body').on('click', '.js-details-expand', function expand(e) {
     e.preventDefault();
     $(this)
       .next('.js-details-content')
       .removeClass('hide');
     $(this).hide();
-
-    const truncatedItem = $(this).siblings('.js-details-short');
-    if (truncatedItem.length) {
-      truncatedItem.addClass('hide');
-    }
   });
-});
+};

app/assets/stylesheets/behaviors.scss

-// Details
-//--------
-.js-details-container {
-  .content {
-    display: none;
-    &.hide { display: block; }
-  }
-
-  &.open .content {
-    display: block;
-    &.hide { display: none; }
-  }
-}
-
-// Toggle between two states.
-.js-toggler-container {
-  .turn-on { display: block; }
-  .turn-off { display: none; }
-
-  &.on {
-    .turn-on { display: none; }
-    .turn-off { display: block; }
-  }
-}
-
 // Hide element if Vue is still working on rendering it fully.
 [v-cloak='true'] {
   display: none !important;

app/assets/stylesheets/pages/commits.scss

@@ -14,12 +14,6 @@
   @extend %commit-description-base;
 }
 
-.js-details-expand {
-  &:hover {
-    text-decoration: none;
-  }
-}
-
 .commit-box {
   border-top: 1px solid $border-color;
   padding: $gl-padding 0;
@@ -30,17 +24,6 @@
   }
 }
 
-.commit-hash-full {
-  @include media-breakpoint-down(sm) {
-    width: 80px;
-    white-space: nowrap;
-    overflow: hidden;
-    text-overflow: ellipsis;
-    display: inline-block;
-    vertical-align: bottom;
-  }
-}
-
 .pipeline-info {
   .status-icon-container {
     display: inline-block;

app/views/projects/pipelines/_info.html.haml

@@ -57,12 +57,7 @@
   .well-segment.branch-info
     .icon-container.commit-icon
       = custom_icon("icon_commit")
-    = link_to commit.short_id, project_commit_path(@project, @pipeline.sha), class: "commit-sha js-details-short"
-    = link_to("#", class: "js-details-expand d-none d-md-inline") do
-      %span.text-expander
-        = sprite_icon('ellipsis_h', size: 12)
-    %span.js-details-content.hide
-      = link_to @pipeline.sha, project_commit_path(@project, @pipeline.sha), class: "commit-sha commit-hash-full"
+    = link_to commit.short_id, project_commit_path(@project, @pipeline.sha), class: "commit-sha"
     = clipboard_button(text: @pipeline.sha, title: _("Copy commit SHA"))
 
   .well-segment.related-merge-request-info

changelogs/unreleased/25145-remove-expand-sha-button-pipeline.yml

+---
+title: Remove unnecessary expand sha button in pipelines page
+merge_request: 47012
+author:
+type: fixed