Commit 05a00b84 authored by Sri's avatar Sri

Code review fixes

parent fd387d06
...@@ -119,33 +119,30 @@ RSpec.describe Sidebars::Projects::Menus::InfrastructureMenu do ...@@ -119,33 +119,30 @@ RSpec.describe Sidebars::Projects::Menus::InfrastructureMenu do
end end
it { is_expected.to be_nil } it { is_expected.to be_nil }
end
context 'when feature flag is turned off but enabled for project' do context 'when feature flag is enabled for specific project' do
before do before do
stub_feature_flags(incubation_5mp_google_cloud: false) stub_feature_flags(incubation_5mp_google_cloud: project)
stub_feature_flags(incubation_5mp_google_cloud: project) end
it_behaves_like 'access rights checks'
end end
it_behaves_like 'access rights checks' context 'when feature flag is enabled for specific group' do
end before do
stub_feature_flags(incubation_5mp_google_cloud: project.group)
end
context 'when feature flag is turned off but enabled for group' do it_behaves_like 'access rights checks'
before do
stub_feature_flags(incubation_5mp_google_cloud: false)
stub_feature_flags(incubation_5mp_google_cloud: project.group)
end end
it_behaves_like 'access rights checks' context 'when feature flag is enabled for specific project' do
end before do
stub_feature_flags(incubation_5mp_google_cloud: user)
end
context 'when feature flag is turned off but enabled for user' do it_behaves_like 'access rights checks'
before do
stub_feature_flags(incubation_5mp_google_cloud: false)
stub_feature_flags(incubation_5mp_google_cloud: user)
end end
it_behaves_like 'access rights checks'
end end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment