Commit 05ae26fe authored by Luis Mejia's avatar Luis Mejia

Avoid removing PI approved label

parent 62dd5e5e
...@@ -44,20 +44,26 @@ RSpec.describe Tooling::Danger::ProductIntelligence do ...@@ -44,20 +44,26 @@ RSpec.describe Tooling::Danger::ProductIntelligence do
context 'with product intelligence label' do context 'with product intelligence label' do
let(:expected_labels) { ['product intelligence::review pending'] } let(:expected_labels) { ['product intelligence::review pending'] }
let(:mr_labels) { [] }
before do before do
allow(fake_helper).to receive(:mr_has_labels?).with('product intelligence').and_return(true) allow(fake_helper).to receive(:mr_has_labels?).with('product intelligence').and_return(true)
allow(fake_helper).to receive(:mr_labels).and_return(mr_labels)
end end
it { is_expected.to match_array(expected_labels) } it { is_expected.to match_array(expected_labels) }
end
context 'with product intelligence::review pending' do context 'with product intelligence::review pending' do
before do let(:mr_labels) { ['product intelligence::review pending'] }
allow(fake_helper).to receive(:mr_has_labels?).and_return(true)
it { is_expected.to be_empty }
end end
it { is_expected.to be_empty } context 'with product intelligence::approved' do
let(:mr_labels) { ['product intelligence::approved'] }
it { is_expected.to be_empty }
end
end end
context 'with growth experiment label' do context 'with growth experiment label' do
......
...@@ -14,10 +14,16 @@ module Tooling ...@@ -14,10 +14,16 @@ module Tooling
labels = [] labels = []
labels << 'product intelligence' unless helper.mr_has_labels?('product intelligence') labels << 'product intelligence' unless helper.mr_has_labels?('product intelligence')
labels << 'product intelligence::review pending' unless helper.mr_has_labels?(WORKFLOW_LABELS) labels << 'product intelligence::review pending' unless has_workflow_labels?
labels labels
end end
private
def has_workflow_labels?
(WORKFLOW_LABELS & helper.mr_labels).any?
end
end end
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment