Commit 05cd5548 authored by Adam Hegyi's avatar Adam Hegyi

Prevent using `with_lock_retries` within `change` method

- Updated documentation.
- Rubocop rule.
parent fbfdc0b4
...@@ -176,9 +176,15 @@ Removing a column: ...@@ -176,9 +176,15 @@ Removing a column:
```ruby ```ruby
include Gitlab::Database::MigrationHelpers include Gitlab::Database::MigrationHelpers
def change def up
with_lock_retries do with_lock_retries do
remove_column :users, :full_name, :string remove_column :users, :full_name
end
end
def down
with_lock_retries do
add_column :users, :full_name, :string
end end
end end
``` ```
...@@ -188,11 +194,17 @@ Removing a foreign key: ...@@ -188,11 +194,17 @@ Removing a foreign key:
```ruby ```ruby
include Gitlab::Database::MigrationHelpers include Gitlab::Database::MigrationHelpers
def change def up
with_lock_retries do with_lock_retries do
remove_foreign_key :issues, :projects remove_foreign_key :issues, :projects
end end
end end
def down
with_lock_retries do
add_foreign_key :issues, :projects
end
end
``` ```
Changing default value for a column: Changing default value for a column:
...@@ -200,11 +212,17 @@ Changing default value for a column: ...@@ -200,11 +212,17 @@ Changing default value for a column:
```ruby ```ruby
include Gitlab::Database::MigrationHelpers include Gitlab::Database::MigrationHelpers
def change def up
with_lock_retries do with_lock_retries do
change_column_default :merge_requests, :lock_version, from: nil, to: 0 change_column_default :merge_requests, :lock_version, from: nil, to: 0
end end
end end
def down
with_lock_retries do
change_column_default :merge_requests, :lock_version, from: 0, to: nil
end
end
``` ```
### When to use the helper method ### When to use the helper method
...@@ -231,6 +249,8 @@ Example changes: ...@@ -231,6 +249,8 @@ Example changes:
**Note:** `with_lock_retries` method **cannot** be used with `disable_ddl_transaction!`. **Note:** `with_lock_retries` method **cannot** be used with `disable_ddl_transaction!`.
**Note:** `with_lock_retries` method **cannot** be used within the `change` method, you must manually define the `up` and `down` methods to make the migration reversible.
### How the helper method works ### How the helper method works
1. Iterate 50 times. 1. Iterate 50 times.
......
# frozen_string_literal: true
require_relative '../../migration_helpers'
module RuboCop
module Cop
module Migration
# Cop that prevents usage of `with_lock_retries` within the `change` method.
class WithLockRetriesWithChange < RuboCop::Cop::Cop
include MigrationHelpers
MSG = '`with_lock_retries` cannot be used within `change` so you must manually define ' \
'the `up` and `down` methods in your migration class and use `with_lock_retries` in both methods'.freeze
def on_send(node)
return unless in_migration?(node)
return unless node.children[1] == :with_lock_retries
node.each_ancestor(:def) do |def_node|
add_offense(def_node, location: :name) if method_name(def_node) == :change
end
end
def method_name(node)
node.children.first
end
end
end
end
end
# frozen_string_literal: true
require 'spec_helper'
require 'rubocop'
require 'rubocop/rspec/support'
require_relative '../../../../rubocop/cop/migration/with_lock_retries_with_change'
describe RuboCop::Cop::Migration::WithLockRetriesWithChange do
include CopHelper
subject(:cop) { described_class.new }
context 'in migration' do
before do
allow(cop).to receive(:in_migration?).and_return(true)
end
it 'registers an offense when `with_lock_retries` is used inside a `change` method' do
inspect_source('def change; with_lock_retries {}; end')
aggregate_failures do
expect(cop.offenses.size).to eq(1)
expect(cop.offenses.map(&:line)).to eq([1])
end
end
it 'registers no offense when `with_lock_retries` is used inside an `up` method' do
inspect_source('def up; with_lock_retries {}; end')
expect(cop.offenses.size).to eq(0)
end
end
context 'outside of migration' do
it 'registers no offense' do
inspect_source('def change; with_lock_retries {}; end')
expect(cop.offenses.size).to eq(0)
end
end
end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment