Extract EE-specific code from Projects::Prometheus::MetricsController

Signed-off-by: Rémy Coutable <remy@rymai.me>

app/controllers/projects/prometheus/metrics_controller.rb

 module Projects
   module Prometheus
     class MetricsController < Projects::ApplicationController
+      prepend EE::Projects::Prometheus::MetricsController
+
       before_action :authorize_admin_project!
       before_action :require_prometheus_metrics!
 
@@ -18,85 +20,8 @@ module Projects
         end
       end
 
-      def validate_query
-        respond_to do |format|
-          format.json do
-            result = prometheus_adapter.query(:validate, params[:query])
-
-            if result.any?
-              render json: result
-            else
-              head :no_content
-            end
-          end
-        end
-      end
-
-      def new
-        @metric = project.prometheus_metrics.new
-      end
-
-      def index
-        respond_to do |format|
-          format.json do
-            metrics = project.prometheus_metrics
-            response = {}
-            if metrics.any?
-              response[:metrics] = PrometheusMetricSerializer.new(project: project)
-                                     .represent(metrics.order(created_at: :asc))
-            end
-
-            render json: response
-          end
-        end
-      end
-
-      def create
-        @metric = project.prometheus_metrics.create(metrics_params)
-        if @metric.persisted?
-          redirect_to edit_project_service_path(project, PrometheusService),
-                      notice: 'Metric was successfully added.'
-        else
-          render 'new'
-        end
-      end
-
-      def update
-        @metric = project.prometheus_metrics.find(params[:id])
-        @metric.update(metrics_params)
-
-        if @metric.persisted?
-          redirect_to edit_project_service_path(project, PrometheusService),
-                      notice: 'Metric was successfully updated.'
-        else
-          render 'edit'
-        end
-      end
-
-      def edit
-        @metric = project.prometheus_metrics.find(params[:id])
-      end
-
-      def destroy
-        metric = project.prometheus_metrics.find(params[:id])
-        metric.destroy
-
-        respond_to do |format|
-          format.html do
-            redirect_to edit_project_service_path(project, PrometheusService), status: 303
-          end
-          format.json do
-            head :ok
-          end
-        end
-      end
-
       private
 
-      def metrics_params
-        params.require(:prometheus_metric).permit(:title, :query, :y_label, :unit, :legend, :group)
-      end
-
       def prometheus_adapter
         @prometheus_adapter ||= ::Prometheus::AdapterService.new(project).prometheus_adapter
       end

ee/app/controllers/ee/projects/prometheus/metrics_controller.rb

+module EE
+  module Projects
+    module Prometheus
+      module MetricsController
+        def validate_query
+          respond_to do |format|
+            format.json do
+              result = prometheus_adapter.query(:validate, params[:query])
+
+              if result.any?
+                render json: result
+              else
+                head :no_content
+              end
+            end
+          end
+        end
+
+        def new
+          @metric = project.prometheus_metrics.new # rubocop:disable Gitlab/ModuleWithInstanceVariables
+        end
+
+        def index
+          respond_to do |format|
+            format.json do
+              metrics = project.prometheus_metrics
+              response = {}
+              if metrics.any?
+                response[:metrics] = ::PrometheusMetricSerializer.new(project: project)
+                                       .represent(metrics.order(created_at: :asc))
+              end
+
+              render json: response
+            end
+          end
+        end
+
+        def create
+          @metric = project.prometheus_metrics.create(metrics_params) # rubocop:disable Gitlab/ModuleWithInstanceVariables
+          if @metric.persisted? # rubocop:disable Gitlab/ModuleWithInstanceVariables
+            redirect_to edit_project_service_path(project, ::PrometheusService),
+                        notice: 'Metric was successfully added.'
+          else
+            render 'new'
+          end
+        end
+
+        def update
+          @metric = project.prometheus_metrics.find(params[:id]) # rubocop:disable Gitlab/ModuleWithInstanceVariables
+          @metric.update(metrics_params) # rubocop:disable Gitlab/ModuleWithInstanceVariables
+
+          if @metric.persisted? # rubocop:disable Gitlab/ModuleWithInstanceVariables
+            redirect_to edit_project_service_path(project, ::PrometheusService),
+                        notice: 'Metric was successfully updated.'
+          else
+            render 'edit'
+          end
+        end
+
+        def edit
+          @metric = project.prometheus_metrics.find(params[:id]) # rubocop:disable Gitlab/ModuleWithInstanceVariables
+        end
+
+        def destroy
+          metric = project.prometheus_metrics.find(params[:id])
+          metric.destroy
+
+          respond_to do |format|
+            format.html do
+              redirect_to edit_project_service_path(project, ::PrometheusService), status: 303
+            end
+            format.json do
+              head :ok
+            end
+          end
+        end
+
+        private
+
+        def metrics_params
+          params.require(:prometheus_metric).permit(:title, :query, :y_label, :unit, :legend, :group)
+        end
+      end
+    end
+  end
+end