Merge branch 'xanf-remove-attachToDocument-196758' into 'master'

Remove useless attachToDocument usage in spec/frontend/monitoring

Closes #196758

See merge request gitlab-org/gitlab!23046

spec/frontend/monitoring/components/charts/time_series_spec.js

@@ -59,7 +59,6 @@ describe('Time series component', () => {
           default: mockWidgets,
         },
         store,
-        attachToDocument: true,
       });
   });
 

spec/frontend/monitoring/components/dashboard_spec.js

@@ -63,7 +63,7 @@ describe('Dashboard', () => {
     beforeEach(() => {
       mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
 
-      createShallowWrapper({}, { attachToDocument: true });
+      createShallowWrapper();
     });
 
     afterEach(() => {
@@ -79,7 +79,7 @@ describe('Dashboard', () => {
     beforeEach(done => {
       mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
 
-      createShallowWrapper({}, { attachToDocument: true });
+      createShallowWrapper();
 
       wrapper.vm.$nextTick(done);
     });
@@ -99,7 +99,7 @@ describe('Dashboard', () => {
     });
 
     it('shows up a loading state', done => {
-      createShallowWrapper({ hasMetrics: true }, { attachToDocument: true });
+      createShallowWrapper({ hasMetrics: true });
 
       wrapper.vm
         .$nextTick()
@@ -114,7 +114,7 @@ describe('Dashboard', () => {
     it('hides the group panels when showPanels is false', done => {
       createMountedWrapper(
         { hasMetrics: true, showPanels: false },
-        { attachToDocument: true, stubs: ['graph-group', 'panel-type'] },
+        { stubs: ['graph-group', 'panel-type'] },
       );
 
       setupComponentStore(wrapper);
@@ -136,10 +136,7 @@ describe('Dashboard', () => {
     it('fetches the metrics data with proper time window', done => {
       jest.spyOn(store, 'dispatch');
 
-      createMountedWrapper(
-        { hasMetrics: true },
-        { attachToDocument: true, stubs: ['graph-group', 'panel-type'] },
-      );
+      createMountedWrapper({ hasMetrics: true }, { stubs: ['graph-group', 'panel-type'] });
 
       wrapper.vm.$store.commit(
         `monitoringDashboard/${types.RECEIVE_ENVIRONMENTS_DATA_SUCCESS}`,
@@ -161,10 +158,7 @@ describe('Dashboard', () => {
     beforeEach(() => {
       mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
 
-      createMountedWrapper(
-        { hasMetrics: true },
-        { attachToDocument: true, stubs: ['graph-group', 'panel-type'] },
-      );
+      createMountedWrapper({ hasMetrics: true }, { stubs: ['graph-group', 'panel-type'] });
 
       setupComponentStore(wrapper);
     });
@@ -216,10 +210,7 @@ describe('Dashboard', () => {
   });
 
   it('hides the environments dropdown list when there is no environments', done => {
-    createMountedWrapper(
-      { hasMetrics: true },
-      { attachToDocument: true, stubs: ['graph-group', 'panel-type'] },
-    );
+    createMountedWrapper({ hasMetrics: true }, { stubs: ['graph-group', 'panel-type'] });
 
     wrapper.vm.$store.commit(
       `monitoringDashboard/${types.RECEIVE_METRICS_DATA_SUCCESS}`,
@@ -244,10 +235,7 @@ describe('Dashboard', () => {
   });
 
   it('renders the datetimepicker dropdown', done => {
-    createMountedWrapper(
-      { hasMetrics: true },
-      { attachToDocument: true, stubs: ['graph-group', 'panel-type'] },
-    );
+    createMountedWrapper({ hasMetrics: true }, { stubs: ['graph-group', 'panel-type'] });
 
     setupComponentStore(wrapper);
 
@@ -264,7 +252,7 @@ describe('Dashboard', () => {
     beforeEach(done => {
       mock.onGet(mockApiEndpoint).reply(200, metricsGroupsAPIResponse);
 
-      createShallowWrapper({ hasMetrics: true }, { attachToDocument: true });
+      createShallowWrapper({ hasMetrics: true });
       setupComponentStore(wrapper);
 
       wrapper.vm.$nextTick(done);
@@ -298,7 +286,7 @@ describe('Dashboard', () => {
     });
 
     beforeEach(done => {
-      createShallowWrapper({ hasMetrics: true }, { attachToDocument: true });
+      createShallowWrapper({ hasMetrics: true });
 
       setupComponentStore(wrapper);
 
@@ -415,7 +403,7 @@ describe('Dashboard', () => {
     beforeEach(done => {
       mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
 
-      createShallowWrapper({ hasMetrics: true }, { attachToDocument: true });
+      createShallowWrapper({ hasMetrics: true });
 
       wrapper.vm.$store.commit(
         `monitoringDashboard/${types.SET_ALL_DASHBOARDS}`,
@@ -452,10 +440,7 @@ describe('Dashboard', () => {
     beforeEach(() => {
       mock.onGet(mockApiEndpoint).reply(200, metricsGroupsAPIResponse);
 
-      createMountedWrapper(
-        { hasMetrics: true },
-        { attachToDocument: true, stubs: ['graph-group', 'panel-type'] },
-      );
+      createMountedWrapper({ hasMetrics: true }, { stubs: ['graph-group', 'panel-type'] });
 
       wrapper.vm.$store.commit(
         `monitoringDashboard/${types.SET_ALL_DASHBOARDS}`,
@@ -487,7 +472,7 @@ describe('Dashboard', () => {
           showTimeWindowDropdown: false,
           externalDashboardUrl: '/mockUrl',
         },
-        { attachToDocument: true, stubs: ['graph-group', 'panel-type'] },
+        { stubs: ['graph-group', 'panel-type'] },
       );
     });
 
@@ -517,7 +502,7 @@ describe('Dashboard', () => {
     beforeEach(done => {
       mock.onGet(mockApiEndpoint).reply(200, metricsGroupsAPIResponse);
 
-      createShallowWrapper({ hasMetrics: true, currentDashboard }, { attachToDocument: true });
+      createShallowWrapper({ hasMetrics: true, currentDashboard });
 
       setTimeout(done);
     });

spec/frontend/monitoring/components/dashboard_time_url_spec.js

@@ -38,10 +38,7 @@ describe('dashboard invalid url parameters', () => {
   });
 
   it('shows an error message if invalid url parameters are passed', done => {
-    createMountedWrapper(
-      { hasMetrics: true },
-      { attachToDocument: true, stubs: ['graph-group', 'panel-type'] },
-    );
+    createMountedWrapper({ hasMetrics: true }, { stubs: ['graph-group', 'panel-type'] });
 
     wrapper.vm
       .$nextTick()

spec/frontend/monitoring/components/dashboard_time_window_spec.js

@@ -45,10 +45,7 @@ describe('dashboard time window', () => {
   it('shows an error message if invalid url parameters are passed', done => {
     mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
 
-    createComponentWrapperMounted(
-      { hasMetrics: true },
-      { attachToDocument: true, stubs: ['graph-group', 'panel-type'] },
-    );
+    createComponentWrapperMounted({ hasMetrics: true }, { stubs: ['graph-group', 'panel-type'] });
 
     setupComponentStore(wrapper);
 

spec/frontend/monitoring/panel_type_spec.js

@@ -26,7 +26,6 @@ describe('Panel Type component', () => {
         ...props,
       },
       store,
-      attachToDocument: true,
     });
 
   beforeEach(() => {
@@ -151,7 +150,6 @@ describe('Panel Type component', () => {
           graphData: graphDataPrometheusQueryRange,
         },
         store,
-        attachToDocument: true,
       });
       panelType.vm.$nextTick(done);
     });