Merge branch 'osw-schedule-multiple-mr-assignees-ff-auto-enabling' into 'master'

Automatically enable multiple MR assignees feature flag

See merge request gitlab-org/gitlab-ee!10558

ee/changelogs/unreleased/osw-schedule-multiple-mr-assignees-ff-auto-enabling.yml

+---
+title: Automatically enable multiple MR assignees feature flag
+merge_request: 10558
+author:
+type: other

ee/db/post_migrate/20190402224749_schedule_merge_request_assignees_migration_progress_check.rb

+# frozen_string_literal: true
+
+class ScheduleMergeRequestAssigneesMigrationProgressCheck < ActiveRecord::Migration[5.0]
+  include Gitlab::Database::MigrationHelpers
+
+  MIGRATION = 'MergeRequestAssigneesMigrationProgressCheck'.freeze
+
+  DOWNTIME = false
+
+  disable_ddl_transaction!
+
+  def up
+    BackgroundMigrationWorker.perform_async(MIGRATION)
+  end
+
+  def down
+  end
+end

ee/lib/gitlab/background_migration/merge_request_assignees_migration_progress_check.rb

+# frozen_string_literal: true
+
+module Gitlab
+  module BackgroundMigration
+    class MergeRequestAssigneesMigrationProgressCheck
+      include Gitlab::Utils::StrongMemoize
+
+      RESCHEDULE_DELAY = 3.hours
+      WORKER = 'PopulateMergeRequestAssigneesTable'.freeze
+      DeadJobsError = Class.new(StandardError)
+
+      def perform
+        raise DeadJobsError, "Only dead background jobs in the queue for #{WORKER}" if !ongoing? && dead_jobs?
+
+        if ongoing?
+          BackgroundMigrationWorker.perform_in(RESCHEDULE_DELAY, self.class.name)
+        else
+          Feature.enable(:multiple_merge_request_assignees)
+        end
+      end
+
+      private
+
+      def dead_jobs?
+        strong_memoize(:dead_jobs) do
+          migration_klass.dead_jobs?(WORKER)
+        end
+      end
+
+      def ongoing?
+        strong_memoize(:ongoing) do
+          migration_klass.exists?(WORKER) || migration_klass.retrying_jobs?(WORKER)
+        end
+      end
+
+      def migration_klass
+        Gitlab::BackgroundMigration
+      end
+    end
+  end
+end

ee/spec/lib/gitlab/background_migration/merge_request_assignees_migration_progress_check_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Gitlab::BackgroundMigration::MergeRequestAssigneesMigrationProgressCheck do
+  context 'rescheduling' do
+    context 'when there are ongoing and no dead jobs' do
+      it 'reschedules check' do
+        allow(Gitlab::BackgroundMigration).to receive(:exists?)
+                                                .with('PopulateMergeRequestAssigneesTable')
+                                                .and_return(true)
+
+        allow(Gitlab::BackgroundMigration).to receive(:dead_jobs?)
+                                                .with('PopulateMergeRequestAssigneesTable')
+                                                .and_return(false)
+
+        expect(BackgroundMigrationWorker).to receive(:perform_in).with(described_class::RESCHEDULE_DELAY, described_class.name)
+
+        described_class.new.perform
+      end
+    end
+
+    context 'when there are ongoing and dead jobs' do
+      it 'reschedules check' do
+        allow(Gitlab::BackgroundMigration).to receive(:exists?)
+                                                .with('PopulateMergeRequestAssigneesTable')
+                                                .and_return(true)
+
+        allow(Gitlab::BackgroundMigration).to receive(:dead_jobs?)
+                                                .with('PopulateMergeRequestAssigneesTable')
+                                                .and_return(true)
+
+        expect(BackgroundMigrationWorker).to receive(:perform_in).with(described_class::RESCHEDULE_DELAY, described_class.name)
+
+        described_class.new.perform
+      end
+    end
+
+    context 'when there retrying jobs and no scheduled' do
+      it 'reschedules check' do
+        allow(Gitlab::BackgroundMigration).to receive(:exists?)
+                                                .with('PopulateMergeRequestAssigneesTable')
+                                                .and_return(false)
+
+        allow(Gitlab::BackgroundMigration).to receive(:retrying_jobs?)
+                                                .with('PopulateMergeRequestAssigneesTable')
+                                                .and_return(true)
+
+        expect(BackgroundMigrationWorker).to receive(:perform_in).with(described_class::RESCHEDULE_DELAY, described_class.name)
+
+        described_class.new.perform
+      end
+    end
+  end
+
+  context 'when there are no scheduled, or retrying or dead' do
+    it 'enables feature' do
+      allow(Gitlab::BackgroundMigration).to receive(:exists?)
+                                              .with('PopulateMergeRequestAssigneesTable')
+                                              .and_return(false)
+
+      allow(Gitlab::BackgroundMigration).to receive(:retrying_jobs?)
+                                              .with('PopulateMergeRequestAssigneesTable')
+                                              .and_return(false)
+
+      allow(Gitlab::BackgroundMigration).to receive(:dead_jobs?)
+                                              .with('PopulateMergeRequestAssigneesTable')
+                                              .and_return(false)
+
+      expect(Feature).to receive(:enable).with(:multiple_merge_request_assignees)
+
+      described_class.new.perform
+    end
+  end
+
+  context 'when there are only dead jobs' do
+    it 'raises DeadJobsError error' do
+      allow(Gitlab::BackgroundMigration).to receive(:exists?)
+                                              .with('PopulateMergeRequestAssigneesTable')
+                                              .and_return(false)
+
+      allow(Gitlab::BackgroundMigration).to receive(:retrying_jobs?)
+                                              .with('PopulateMergeRequestAssigneesTable')
+                                              .and_return(false)
+
+      allow(Gitlab::BackgroundMigration).to receive(:dead_jobs?)
+                                              .with('PopulateMergeRequestAssigneesTable')
+                                              .and_return(true)
+
+      expect { described_class.new.perform }
+        .to raise_error(described_class::DeadJobsError,
+                        "Only dead background jobs in the queue for #{described_class::WORKER}")
+    end
+  end
+end

ee/spec/migrations/schedule_merge_request_assignees_migration_progress_check_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+require Rails.root.join('ee', 'db', 'post_migrate', '20190402224749_schedule_merge_request_assignees_migration_progress_check.rb')
+
+describe ScheduleMergeRequestAssigneesMigrationProgressCheck do
+  describe '#up' do
+    it 'schedules MergeRequestAssigneesMigrationProgressCheck background job' do
+      expect(BackgroundMigrationWorker).to receive(:perform_async)
+                                             .with(described_class::MIGRATION)
+                                             .and_call_original
+
+      subject.up
+    end
+  end
+end