Setup specs with Geo nodes properly

Previously, many tests depended on the coupling between the
GeoNode factory and the config. With that decoupled, these
tests have GeoNodes in the database but *this* machine is
not associated with any GeoNode record.

ee/spec/controllers/oauth/geo_auth_controller_spec.rb

@@ -82,7 +82,7 @@ describe Oauth::GeoAuthController, :geo do
           it "redirects to primary node's oauth endpoint" do
             get :callback, params: { state: login_state }
 
-            expect(response).to redirect_to('/')
+            expect(response).to redirect_to(secondary_node.uri.path)
           end
         end
 

ee/spec/lib/gitlab/geo/jwt_request_decoder_spec.rb

 require 'spec_helper'
 
 describe Gitlab::Geo::JwtRequestDecoder do
+  include EE::GeoHelpers
+
   let!(:primary_node) { FactoryBot.create(:geo_node, :primary) }
   let(:data) { { input: 123 } }
   let(:request) { Gitlab::Geo::TransferRequest.new(data) }
 
   subject { described_class.new(request.headers['Authorization']) }
 
+  before do
+    stub_current_geo_node(primary_node)
+  end
+
   describe '#decode' do
     it 'decodes correct data' do
       expect(subject.decode).to eq(data)

ee/spec/lib/gitlab/geo_spec.rb

@@ -18,6 +18,8 @@ describe Gitlab::Geo, :geo, :request_store do
 
   describe '.current_node' do
     it 'returns a GeoNode instance' do
+      expect(GeoNode).to receive(:current_node).and_return(primary_node)
+
       expect(described_class.current_node).to eq(primary_node)
     end
 
@@ -42,6 +44,10 @@ describe Gitlab::Geo, :geo, :request_store do
 
   describe '.primary?' do
     context 'when current node is a primary node' do
+      before do
+        stub_current_geo_node(primary_node)
+      end
+
       it 'returns true' do
         expect(described_class.primary?).to be_truthy
       end

ee/spec/models/ci/job_artifact_spec.rb

@@ -3,11 +3,15 @@
 require 'spec_helper'
 
 describe Ci::JobArtifact do
+  include EE::GeoHelpers
+
   describe '#destroy' do
     set(:primary) { create(:geo_node, :primary) }
     set(:secondary) { create(:geo_node) }
 
     it 'creates a JobArtifactDeletedEvent' do
+      stub_current_geo_node(primary)
+
       job_artifact = create(:ci_job_artifact, :archive)
 
       expect do

ee/spec/models/geo_node_spec.rb

@@ -102,7 +102,8 @@ describe GeoNode, :geo, type: :model do
 
   context 'prevent locking yourself out' do
     it 'does not accept adding a non primary node with same details as current_node' do
-      node = build(:geo_node, :primary, primary: false)
+      stub_geo_setting(node_name: 'foo')
+      node = build(:geo_node, :primary, primary: false, name: 'foo')
 
       expect(node).not_to be_valid
       expect(node.errors.full_messages.count).to eq(1)

ee/spec/models/lfs_object_spec.rb

 require 'spec_helper'
 
 describe LfsObject do
+  include EE::GeoHelpers
+
   describe '#destroy' do
     subject { create(:lfs_object, :with_file) }
 
@@ -9,6 +11,8 @@ describe LfsObject do
       set(:secondary) { create(:geo_node) }
 
       it 'logs an event to the Geo event log' do
+        stub_current_geo_node(primary)
+
         expect { subject.destroy }.to change(Geo::LfsObjectDeletedEvent, :count).by(1)
       end
     end

ee/spec/models/namespace_spec.rb

@@ -3,6 +3,8 @@
 require 'spec_helper'
 
 describe Namespace do
+  include EE::GeoHelpers
+
   let!(:namespace) { create(:namespace) }
   let!(:free_plan) { create(:free_plan) }
   let!(:bronze_plan) { create(:bronze_plan) }
@@ -148,6 +150,8 @@ describe Namespace do
         allow(gitlab_shell).to receive(:mv_namespace)
           .with(project_legacy.repository_storage, full_path_was, new_path)
           .and_return(true)
+
+        stub_current_geo_node(primary)
       end
 
       it 'logs the Geo::RepositoryRenamedEvent for each project inside namespace' do

ee/spec/models/upload_spec.rb

 require 'spec_helper'
 
 describe Upload do
+  include EE::GeoHelpers
+
   describe '#destroy' do
     subject { create(:upload, checksum: '8710d2c16809c79fee211a9693b64038a8aae99561bc86ce98a9b46b45677fe4') }
 
@@ -9,6 +11,8 @@ describe Upload do
       set(:secondary) { create(:geo_node) }
 
       it 'logs an event to the Geo event log' do
+        stub_current_geo_node(primary)
+
         expect { subject.destroy }.to change(Geo::UploadDeletedEvent, :count).by(1)
       end
     end

ee/spec/requests/api/geo_nodes_spec.rb

@@ -170,7 +170,8 @@ describe API::GeoNodes, :geo, :prometheus, api: true do
     end
 
     it 'returns 200 for the primary node' do
-      expect(GeoNodeStatus).to receive(:fast_current_node_status).and_return(secondary_status)
+      set_current_geo_node!(primary)
+      create(:geo_node_status, :healthy, geo_node: primary)
 
       post api("/geo_nodes/#{primary.id}/repair", admin)
 

ee/spec/requests/api/geo_spec.rb

@@ -17,6 +17,10 @@ describe API::Geo do
     Gitlab::Geo::TransferRequest.new(transfer.request_data.merge(file_id: 100000)).headers
   end
 
+  before do
+    stub_current_geo_node(primary_node)
+  end
+
   shared_examples 'with terms enforced' do
     before do
       enforce_terms

ee/spec/requests/git_http_geo_spec.rb

@@ -12,7 +12,7 @@ describe "Git HTTP requests (Geo)", :geo do
   set(:secondary) { create(:geo_node) }
 
   # Ensure the token always comes from the real time of the request
-  let!(:auth_token) { Gitlab::Geo::BaseRequest.new(scope: project.full_path).authorization }
+  let(:auth_token) { Gitlab::Geo::BaseRequest.new(scope: project.full_path).authorization }
   let!(:user) { create(:user) }
   let!(:user_without_any_access) { create(:user) }
   let!(:user_without_push_access) { create(:user) }
@@ -29,6 +29,9 @@ describe "Git HTTP requests (Geo)", :geo do
 
     stub_licensed_features(geo: true)
     stub_current_geo_node(current_node)
+
+    # Current Geo node must be stubbed before this is instantiated
+    auth_token
   end
 
   shared_examples_for 'Geo request' do

ee/spec/services/geo/file_upload_service_spec.rb

 require 'spec_helper'
 
 describe Geo::FileUploadService do
+  include EE::GeoHelpers
+
   set(:node) { create(:geo_node, :primary) }
 
   let(:transfer_request) { Gitlab::Geo::TransferRequest.new(request_data) }
   let(:req_header) { transfer_request.headers['Authorization'] }
 
+  before do
+    stub_current_geo_node(node)
+  end
+
   shared_examples 'no authorization header' do
     it 'returns nil' do
       service = described_class.new(params, nil)

ee/spec/services/geo/node_create_service_spec.rb

@@ -3,32 +3,32 @@ require 'spec_helper'
 describe Geo::NodeCreateService do
   describe '#execute' do
     it 'creates a new node with valid params' do
-      service = described_class.new(url: 'http://example.com')
+      service = described_class.new(name: 'foo', url: 'http://example.com')
 
       expect { service.execute }.to change(GeoNode, :count).by(1)
     end
 
     it 'does not create a node with invalid params' do
-      service = described_class.new(url: 'ftp://example.com')
+      service = described_class.new(name: 'foo', url: 'ftp://example.com')
 
       expect { service.execute }.not_to change(GeoNode, :count)
     end
 
     it 'returns true when creation succeeds' do
-      service = described_class.new(url: 'http://example.com')
+      service = described_class.new(name: 'foo', url: 'http://example.com')
 
       expect(service.execute.persisted?).to eq true
     end
 
     it 'returns false when creation fails' do
-      service = described_class.new(url: 'ftp://example.com')
+      service = described_class.new(name: 'foo', url: 'ftp://example.com')
 
       expect(service.execute.persisted?).to eq false
     end
 
     it 'parses the namespace_ids when node have namespace restrictions' do
       groups = create_list(:group, 2)
-      params = { url: 'http://example.com', namespace_ids: groups.map(&:id).join(',') }
+      params = { name: 'foo', url: 'http://example.com', namespace_ids: groups.map(&:id).join(',') }
       service = described_class.new(params)
 
       service.execute

ee/spec/services/geo/node_status_post_service_spec.rb

@@ -10,6 +10,10 @@ describe Geo::NodeStatusPostService, :geo do
   subject { described_class.new }
 
   describe '#execute' do
+    before do
+      stub_current_geo_node(primary)
+    end
+
     it 'parses a 401 response' do
       response = double(success?: false,
                         code: 401,
@@ -59,8 +63,6 @@ describe Geo::NodeStatusPostService, :geo do
     end
 
     it 'does not include id in the payload' do
-      stub_current_geo_node(primary)
-
       expect(Gitlab::HTTP).to receive(:post)
                                 .with(
                                   primary.status_url,
@@ -76,8 +78,6 @@ describe Geo::NodeStatusPostService, :geo do
     end
 
     it 'sends geo_node_id in the request' do
-      stub_current_geo_node(primary)
-
       expect(Gitlab::HTTP).to receive(:post)
                                 .with(
                                   primary.status_url,

ee/spec/services/geo/node_update_service_spec.rb

 require 'spec_helper'
 
 describe Geo::NodeUpdateService do
+  include EE::GeoHelpers
+
   set(:primary) { create(:geo_node, :primary) }
 
   let(:geo_node) { create(:geo_node) }
   let(:groups) { create_list(:group, 2) }
   let(:namespace_ids) { groups.map(&:id).join(',') }
 
+  before do
+    stub_current_geo_node(primary)
+  end
+
   describe '#execute' do
     it 'updates the node' do
       params = { url: 'http://example.com' }

ee/spec/services/projects/after_rename_service_spec.rb

@@ -3,6 +3,8 @@
 require 'spec_helper'
 
 describe Projects::AfterRenameService do
+  include EE::GeoHelpers
+
   describe '#execute' do
     context 'when running on a primary node' do
       set(:primary) { create(:geo_node, :primary) }
@@ -12,6 +14,10 @@ describe Projects::AfterRenameService do
       let!(:full_path_before_rename) { project.full_path }
       let(:path_after_rename) { "#{project.path}-renamed" }
 
+      before do
+        stub_current_geo_node(primary)
+      end
+
       it 'logs the Geo::RepositoryRenamedEvent for project backed by hashed storage' do
         expect { service_execute }.to change(Geo::RepositoryRenamedEvent, :count)
       end

ee/spec/services/projects/create_service_spec.rb

 require 'spec_helper'
 
 describe Projects::CreateService, '#execute' do
+  include EE::GeoHelpers
+
   let(:user) { create :user }
   let(:opts) do
     {
@@ -197,6 +199,10 @@ describe Projects::CreateService, '#execute' do
     set(:primary) { create(:geo_node, :primary) }
     set(:secondary) { create(:geo_node) }
 
+    before do
+      stub_current_geo_node(primary)
+    end
+
     it 'logs an event to the Geo event log' do
       expect { create_project(user, opts) }.to change(Geo::RepositoryCreatedEvent, :count).by(1)
     end

ee/spec/services/projects/destroy_service_spec.rb

 require 'spec_helper'
 
 describe Projects::DestroyService do
+  include EE::GeoHelpers
+
   let!(:user) { create(:user) }
   let!(:project) { create(:project, :repository, namespace: user.namespace) }
   let!(:project_id) { project.id }
@@ -33,6 +35,10 @@ describe Projects::DestroyService do
     set(:primary) { create(:geo_node, :primary) }
     set(:secondary) { create(:geo_node) }
 
+    before do
+      stub_current_geo_node(primary)
+    end
+
     it 'logs an event to the Geo event log' do
       # Run Sidekiq immediately to check that renamed repository will be removed
       Sidekiq::Testing.inline! do

ee/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb

 require 'spec_helper'
 
 describe Projects::HashedStorage::MigrateAttachmentsService do
+  include EE::GeoHelpers
+
   let(:project) { create(:project, storage_version: 1) }
   let(:legacy_storage) { Storage::LegacyProject.new(project) }
   let(:hashed_storage) { Storage::HashedProject.new(project) }
   let(:old_attachments_path) { legacy_storage.disk_path }
   let(:new_attachments_path) { hashed_storage.disk_path }
   let(:service) { described_class.new(project, old_attachments_path) }
+  set(:primary) { create(:geo_node, :primary) }
+  set(:secondary) { create(:geo_node) }
 
-  describe '#execute' do
-    set(:primary) { create(:geo_node, :primary) }
-    set(:secondary) { create(:geo_node) }
+  before do
+    stub_current_geo_node(primary)
+  end
 
+  describe '#execute' do
     context 'on success' do
       before do
         TestEnv.clean_test_path

ee/spec/services/projects/hashed_storage/migrate_repository_service_spec.rb

 require 'spec_helper'
 
 describe Projects::HashedStorage::MigrateRepositoryService do
+  include EE::GeoHelpers
+
   let(:project) { create(:project, :empty_repo, :wiki_repo, :legacy_storage) }
   let(:legacy_storage) { Storage::LegacyProject.new(project) }
   let(:hashed_storage) { Storage::HashedProject.new(project) }
@@ -12,6 +14,7 @@ describe Projects::HashedStorage::MigrateRepositoryService do
 
     before do
       TestEnv.clean_test_path
+      stub_current_geo_node(primary)
     end
 
     it 'creates a Geo::HashedStorageMigratedEvent on success' do

ee/spec/services/projects/transfer_service_spec.rb

 require 'spec_helper'
 
 describe Projects::TransferService do
+  include EE::GeoHelpers
+
   let(:user) { create(:user) }
   let(:group) { create(:group) }
   let(:project) { create(:project, :repository, namespace: user.namespace) }
@@ -16,6 +18,8 @@ describe Projects::TransferService do
     set(:secondary) { create(:geo_node) }
 
     it 'logs an event to the Geo event log' do
+      stub_current_geo_node(primary)
+
       expect { subject.execute(group) }.to change(Geo::RepositoryRenamedEvent, :count).by(1)
     end
   end

ee/spec/support/helpers/ee/geo_helpers.rb

 module EE
   module GeoHelpers
+    # Actually sets the specified node to be the current one, so it works on new
+    # instances of GeoNode, unlike stub_current_geo_node. But this is slower.
+    def set_current_geo_node!(node)
+      node.name = GeoNode.current_node_name
+      node.save!(validate: false)
+    end
+
     def stub_current_geo_node(node)
       allow(::Gitlab::Geo).to receive(:current_node).and_return(node)
       allow(node).to receive(:current?).and_return(true) unless node.nil?

ee/spec/support/helpers/ee/stub_configuration.rb

@@ -25,5 +25,9 @@ module EE
         allow(object).to receive_message_chain(:current_application_settings, setting) { value }
       end
     end
+
+    def stub_geo_setting(messages)
+      allow(::Gitlab.config.geo).to receive_messages(to_settings(messages))
+    end
   end
 end

ee/spec/tasks/geo_rake_spec.rb

@@ -11,6 +11,7 @@ describe 'geo rake tasks', :geo do
   describe 'set_primary_node task' do
     before do
       stub_config_setting(url: 'https://example.com:1234/relative_part')
+      stub_geo_setting(node_name: 'Region 1 node')
     end
 
     it 'creates a GeoNode' do
@@ -22,6 +23,7 @@ describe 'geo rake tasks', :geo do
 
       node = GeoNode.first
 
+      expect(node.name).to eq('Region 1 node')
       expect(node.uri.scheme).to eq('https')
       expect(node.url).to eq('https://example.com:1234/relative_part/')
       expect(node.primary).to be_truthy

ee/spec/workers/remove_unreferenced_lfs_objects_worker_spec.rb

 require 'spec_helper'
 
 describe RemoveUnreferencedLfsObjectsWorker do
+  include EE::GeoHelpers
+
   describe '#perform' do
     context 'when running in a Geo primary node' do
       set(:primary) { create(:geo_node, :primary) }
       set(:secondary) { create(:geo_node) }
 
       it 'logs an event to the Geo event log for every unreferenced LFS objects' do
+        stub_current_geo_node(primary)
         unreferenced_lfs_object_1 = create(:lfs_object, :with_file)
         unreferenced_lfs_object_2 = create(:lfs_object, :with_file)
         referenced_lfs_object = create(:lfs_object)