Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
09a8c054
Commit
09a8c054
authored
May 04, 2020
by
charlie ablett
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'patch-95' into 'master'
I changed merge into merging See merge request gitlab-org/gitlab!30437
parents
c98dee5b
3c1c5906
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
doc/development/code_review.md
doc/development/code_review.md
+1
-1
No files found.
doc/development/code_review.md
View file @
09a8c054
...
...
@@ -319,7 +319,7 @@ Before taking the decision to merge:
-
Set the milestone.
-
Consider warnings and errors from danger bot, code quality, and other reports.
Unless a strong case can be made for the violation, these should be resolved
before merg
e
. A comment must to be posted if the MR is merged with any failed job.
before merg
ing
. A comment must to be posted if the MR is merged with any failed job.
When ready to merge:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment