Merge branch 'mc_rocha-find-user-by-email' into 'master'

Search the user by username or email

See merge request gitlab-org/gitlab!83871

ee/lib/api/captcha_check.rb

@@ -24,7 +24,7 @@ module API
         if rate_limit_reached
           present({ result: true }, with: Entities::CaptchaCheck)
         else
-          user = User.find_by_username(params[:username])
+          user = ::User.by_login(params[:username])
           not_found! 'User' unless user
           present(::Users::CaptchaChallengeService.new(user, request.ip).execute, with: Entities::CaptchaCheck)
         end

ee/spec/requests/api/captcha_check_spec.rb

@@ -4,7 +4,8 @@ require 'spec_helper'
 
 RSpec.describe API::CaptchaCheck do
   let_it_be(:username) { 'TestCaptcha' }
-  let_it_be_with_reload(:user) { create(:user, username: username) }
+  let_it_be(:email) { 'test_email@email.com' }
+  let_it_be_with_reload(:user) { create(:user, username: username, email: email) }
 
   describe 'GET users/:username/captcha_check' do
     context 'when the feature flag arkose_labs_login_challenge is disabled' do
@@ -41,6 +42,34 @@ RSpec.describe API::CaptchaCheck do
         end
       end
 
+      context 'when the email is valid' do
+        it 'returns status ok' do
+          get api("/users/#{email}/captcha_check")
+
+          expect(response).to have_gitlab_http_status(:ok)
+        end
+      end
+
+      context 'when the email is unknown' do
+        let(:unknown_email) { 'unknown_email@email.com' }
+
+        it 'returns status not_found' do
+          get api("/users/#{unknown_email}/captcha_check")
+
+          expect(response).to have_gitlab_http_status(:not_found)
+        end
+      end
+
+      context 'when the email is invalid' do
+        let(:invalid_email) { 'invalid_email@' }
+
+        it 'returns status not_found' do
+          get api("/users/#{invalid_email}/captcha_check")
+
+          expect(response).to have_gitlab_http_status(:not_found)
+        end
+      end
+
       context 'when the user meets the criteria for the captcha check' do
         before do
           user.last_sign_in_at = nil