Merge branch '340567-corrective-action-ban-include-actionview-helpers-urlhelper' into 'master'

Upgrade gitlab-styles to 6.3.0

See merge request gitlab-org/gitlab!70188

.rubocop_manual_todo.yml

@@ -2564,3 +2564,53 @@ Performance/ActiveRecordSubtransactionMethods:
     - 'lib/gitlab/composer/cache.rb'
     - 'lib/gitlab/database/async_indexes/migration_helpers.rb'
     - 'lib/gitlab/issuables_count_for_state.rb'
+
+# WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/340567
+Rails/IncludeUrlHelper:
+  Exclude:
+    - 'app/models/integrations/asana.rb'
+    - 'app/models/integrations/bamboo.rb'
+    - 'app/models/integrations/bugzilla.rb'
+    - 'app/models/integrations/campfire.rb'
+    - 'app/models/integrations/confluence.rb'
+    - 'app/models/integrations/custom_issue_tracker.rb'
+    - 'app/models/integrations/datadog.rb'
+    - 'app/models/integrations/discord.rb'
+    - 'app/models/integrations/ewm.rb'
+    - 'app/models/integrations/external_wiki.rb'
+    - 'app/models/integrations/flowdock.rb'
+    - 'app/models/integrations/hangouts_chat.rb'
+    - 'app/models/integrations/irker.rb'
+    - 'app/models/integrations/jenkins.rb'
+    - 'app/models/integrations/mattermost.rb'
+    - 'app/models/integrations/pivotaltracker.rb'
+    - 'app/models/integrations/redmine.rb'
+    - 'app/models/integrations/webex_teams.rb'
+    - 'app/models/integrations/youtrack.rb'
+    - 'app/presenters/alert_management/alert_presenter.rb'
+    - 'app/presenters/ci/pipeline_presenter.rb'
+    - 'app/presenters/clusters/cluster_presenter.rb'
+    - 'app/presenters/environment_presenter.rb'
+    - 'app/presenters/gitlab/blame_presenter.rb'
+    - 'app/presenters/group_clusterable_presenter.rb'
+    - 'app/presenters/instance_clusterable_presenter.rb'
+    - 'app/presenters/merge_request_presenter.rb'
+    - 'app/presenters/project_clusterable_presenter.rb'
+    - 'app/presenters/project_presenter.rb'
+    - 'app/presenters/prometheus_alert_presenter.rb'
+    - 'app/presenters/release_presenter.rb'
+    - 'app/presenters/releases/evidence_presenter.rb'
+    - 'ee/app/helpers/license_helper.rb'
+    - 'ee/app/models/integrations/github.rb'
+    - 'ee/app/presenters/merge_request_approver_presenter.rb'
+    - 'ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb'
+    - 'ee/spec/lib/banzai/filter/cross_project_issuable_information_filter_spec.rb'
+    - 'ee/spec/lib/banzai/filter/issuable_state_filter_spec.rb'
+    - 'lib/gitlab/ci/badge/metadata.rb'
+    - 'lib/gitlab/email/message/in_product_marketing/helper.rb'
+    - 'spec/helpers/merge_requests_helper_spec.rb'
+    - 'spec/helpers/nav/top_nav_helper_spec.rb'
+    - 'spec/helpers/notify_helper_spec.rb'
+    - 'spec/lib/banzai/filter/issuable_state_filter_spec.rb'
+    - 'spec/lib/banzai/filter/reference_redactor_filter_spec.rb'
+    - 'spec/lib/banzai/reference_redactor_spec.rb'

Gemfile

@@ -372,7 +372,7 @@ group :development, :test do
   gem 'spring', '~> 2.1.0'
   gem 'spring-commands-rspec', '~> 1.0.4'
 
-  gem 'gitlab-styles', '~> 6.2.0', require: false
+  gem 'gitlab-styles', '~> 6.3.0', require: false
 
   gem 'haml_lint', '~> 0.36.0', require: false
   gem 'bundler-audit', '~> 0.7.0.1', require: false

Gemfile.lock

@@ -493,7 +493,7 @@ GEM
       openid_connect (~> 1.2)
     gitlab-sidekiq-fetcher (0.5.6)
       sidekiq (~> 5)
-    gitlab-styles (6.2.0)
+    gitlab-styles (6.3.0)
       rubocop (~> 0.91, >= 0.91.1)
       rubocop-gitlab-security (~> 0.1.1)
       rubocop-performance (~> 1.9.2)
@@ -1477,7 +1477,7 @@ DEPENDENCIES
   gitlab-net-dns (~> 0.9.1)
   gitlab-omniauth-openid-connect (~> 0.8.0)
   gitlab-sidekiq-fetcher (= 0.5.6)
-  gitlab-styles (~> 6.2.0)
+  gitlab-styles (~> 6.3.0)
   gitlab_chronic_duration (~> 0.10.6.2)
   gitlab_omniauth-ldap (~> 2.1.1)
   gon (~> 6.4.0)