Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0ba51628
Commit
0ba51628
authored
Nov 27, 2020
by
Albert Salim
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix parallel_rspec_runner not to run all tests
parent
ca34a87a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
0 deletions
+15
-0
spec/tooling/lib/tooling/parallel_rspec_runner_spec.rb
spec/tooling/lib/tooling/parallel_rspec_runner_spec.rb
+10
-0
tooling/lib/tooling/parallel_rspec_runner.rb
tooling/lib/tooling/parallel_rspec_runner.rb
+5
-0
No files found.
spec/tooling/lib/tooling/parallel_rspec_runner_spec.rb
View file @
0ba51628
...
@@ -43,6 +43,16 @@ RSpec.describe Tooling::ParallelRSpecRunner do # rubocop:disable RSpec/FilePath
...
@@ -43,6 +43,16 @@ RSpec.describe Tooling::ParallelRSpecRunner do # rubocop:disable RSpec/FilePath
subject
.
run
subject
.
run
end
end
context
'when there is no intersect between allocated tests and filtered tests'
do
let
(
:filter_tests
)
{
'99_spec.rb'
}
it
'does not run rspec'
do
expect
(
subject
).
not_to
receive
(
:exec
)
subject
.
run
end
end
end
end
context
'with empty filter tests file'
do
context
'with empty filter tests file'
do
...
...
tooling/lib/tooling/parallel_rspec_runner.rb
View file @
0ba51628
...
@@ -38,6 +38,11 @@ module Tooling
...
@@ -38,6 +38,11 @@ module Tooling
Knapsack
.
logger
.
info
tests_to_run
Knapsack
.
logger
.
info
tests_to_run
Knapsack
.
logger
.
info
Knapsack
.
logger
.
info
if
tests_to_run
.
empty?
Knapsack
.
logger
.
info
'No tests to run on this node, exiting.'
return
end
exec
(
*
rspec_command
)
exec
(
*
rspec_command
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment