Code review changes and add changelog

- move key assignment to abobve the cache lifetime check

- add changelog

app/models/concerns/reactive_caching.rb

@@ -129,16 +129,16 @@ module ReactiveCaching
 
     def exclusively_update_reactive_cache!(*args)
       locking_reactive_cache(*args) do
+        key = full_reactive_cache_key(*args)
         if within_reactive_cache_lifetime?(*args)
           enqueuing_update(*args) do
-            key = full_reactive_cache_key(*args)
             new_value = calculate_reactive_cache(*args)
             old_value = Rails.cache.read(key)
             Rails.cache.write(key, new_value)
             reactive_cache_updated(*args) if new_value != old_value
           end
         else
-          Rails.cache.delete(full_reactive_cache_key(*args))
+          Rails.cache.delete(key)
         end
       end
     end

changelogs/unreleased/reactive-caching-self-cleanup.yml

+---
+title: reactive-caching-self-cleanup
+merge_request: 20111
+author:
+type: performance