Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0f4c87ca
Commit
0f4c87ca
authored
Apr 26, 2021
by
Abdul Wadood
Committed by
Michael Kozono
Apr 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/dora
parent
d7b72c34
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
1 deletion
+7
-1
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-1
ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-dora.yml
...released/rspec-empty-lines-after-letitbe-ee-spec-dora.yml
+5
-0
ee/spec/services/dora/aggregate_metrics_service_spec.rb
ee/spec/services/dora/aggregate_metrics_service_spec.rb
+2
-0
No files found.
.rubocop_manual_todo.yml
View file @
0f4c87ca
...
...
@@ -601,7 +601,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
-
ee/spec/services/dast_scanner_profiles/destroy_service_spec.rb
-
ee/spec/services/dast_scanner_profiles/update_service_spec.rb
-
ee/spec/services/dast_site_profiles/destroy_service_spec.rb
-
ee/spec/services/dora/aggregate_metrics_service_spec.rb
-
ee/spec/services/external_approval_rules/create_service_spec.rb
-
ee/spec/services/external_approval_rules/destroy_service_spec.rb
-
ee/spec/services/external_approval_rules/update_service_spec.rb
...
...
ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-dora.yml
0 → 100644
View file @
0f4c87ca
---
title
:
Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/services/dora
merge_request
:
58353
author
:
Abdul Wadood @abdulwd
type
:
fixed
ee/spec/services/dora/aggregate_metrics_service_spec.rb
View file @
0f4c87ca
...
...
@@ -93,6 +93,7 @@ RSpec.describe Dora::AggregateMetricsService do
let_it_be
(
:staging
)
{
create
(
:environment
,
:staging
,
project:
project
)
}
let_it_be
(
:maintainer
)
{
create
(
:user
)
}
let_it_be
(
:guest
)
{
create
(
:user
)
}
let
(
:container
)
{
project
}
let
(
:user
)
{
maintainer
}
let
(
:params
)
{
{
metric:
'deployment_frequency'
}.
merge
(
extra_params
)
}
...
...
@@ -153,6 +154,7 @@ RSpec.describe Dora::AggregateMetricsService do
let_it_be
(
:production_2
)
{
create
(
:environment
,
:production
,
project:
project_2
)
}
let_it_be
(
:maintainer
)
{
create
(
:user
)
}
let_it_be
(
:guest
)
{
create
(
:user
)
}
let
(
:container
)
{
group
}
let
(
:user
)
{
maintainer
}
let
(
:params
)
{
{
metric:
'deployment_frequency'
}.
merge
(
extra_params
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment