Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
10044dff
Commit
10044dff
authored
May 13, 2020
by
George Tsiolis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove ci_pipeline_persisted_stages feature flag
parent
4a064587
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
0 additions
and
19 deletions
+0
-19
app/models/ci/pipeline.rb
app/models/ci/pipeline.rb
+0
-5
spec/controllers/projects/pipelines_controller_spec.rb
spec/controllers/projects/pipelines_controller_spec.rb
+0
-8
spec/models/ci/pipeline_spec.rb
spec/models/ci/pipeline_spec.rb
+0
-2
spec/serializers/pipeline_serializer_spec.rb
spec/serializers/pipeline_serializer_spec.rb
+0
-4
No files found.
app/models/ci/pipeline.rb
View file @
10044dff
...
...
@@ -401,11 +401,6 @@ module Ci
# The `Ci::Stage` contains all up-to date data
# as atomic processing updates all data in-bulk
stages
elsif
Feature
.
enabled?
(
:ci_pipeline_persisted_stages
,
default_enabled:
true
)
&&
complete?
# The `Ci::Stage` contains up-to date data only for `completed` pipelines
# this is due to asynchronous processing of pipeline, and stages possibly
# not updated inline with processing of pipeline
stages
else
# In other cases, we need to calculate stages dynamically
legacy_stages
...
...
spec/controllers/projects/pipelines_controller_spec.rb
View file @
10044dff
...
...
@@ -26,10 +26,6 @@ describe Projects::PipelinesController do
context
'when using persisted stages'
,
:request_store
do
render_views
before
do
stub_feature_flags
(
ci_pipeline_persisted_stages:
true
)
end
it
'returns serialized pipelines'
do
expect
(
::
Gitlab
::
GitalyClient
).
to
receive
(
:allow_ref_name_caching
).
and_call_original
...
...
@@ -67,10 +63,6 @@ describe Projects::PipelinesController do
end
context
'when using legacy stages'
,
:request_store
do
before
do
stub_feature_flags
(
ci_pipeline_persisted_stages:
false
)
end
it
'returns JSON with serialized pipelines'
do
get_pipelines_index_json
...
...
spec/models/ci/pipeline_spec.rb
View file @
10044dff
...
...
@@ -1010,7 +1010,6 @@ describe Ci::Pipeline, :mailer do
context
'when using legacy stages'
do
before
do
stub_feature_flags
(
ci_pipeline_persisted_stages:
false
,
ci_atomic_processing:
false
)
end
...
...
@@ -1051,7 +1050,6 @@ describe Ci::Pipeline, :mailer do
context
'when using persisted stages'
do
before
do
stub_feature_flags
(
ci_pipeline_persisted_stages:
true
,
ci_atomic_processing:
false
)
end
...
...
spec/serializers/pipeline_serializer_spec.rb
View file @
10044dff
...
...
@@ -10,10 +10,6 @@ describe PipelineSerializer do
described_class
.
new
(
current_user:
user
,
project:
project
)
end
before
do
stub_feature_flags
(
ci_pipeline_persisted_stages:
true
)
end
subject
{
serializer
.
represent
(
resource
)
}
describe
'#represent'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment