Merge branch '31343-remove-unnecessary-use-of-freeze' into 'master'

Remove unnecessary use of freeze

See merge request gitlab-org/gitlab!57056

app/mailers/emails/in_product_marketing.rb

@@ -4,7 +4,7 @@ module Emails
   module InProductMarketing
     include InProductMarketingHelper
 
-    FROM_ADDRESS = 'GitLab <team@gitlab.com>'.freeze
+    FROM_ADDRESS = 'GitLab <team@gitlab.com>'
     CUSTOM_HEADERS = {
       'X-Mailgun-Track' => 'yes',
       'X-Mailgun-Track-Clicks' => 'yes',

changelogs/unreleased/31343-remove-unnecessary-use-of-freeze.yml

+---
+title: Remove unnecessary use of freeze
+merge_request: 57056
+author: Lee Tickett @leetickett
+type: other

ee/app/controllers/ee/repositories/git_http_client_controller.rb

@@ -131,7 +131,7 @@ module EE
       end
 
       class GeoGitLFSHelper
-        MINIMUM_GIT_LFS_VERSION = '2.4.2'.freeze
+        MINIMUM_GIT_LFS_VERSION = '2.4.2'
 
         def initialize(project, geo_route_helper, operation, current_version)
           @project = project

ee/app/controllers/groups/analytics/coverage_reports_controller.rb

@@ -3,7 +3,7 @@
 class Groups::Analytics::CoverageReportsController < Groups::Analytics::ApplicationController
   feature_category :code_testing
 
-  COVERAGE_PARAM = 'coverage'.freeze
+  COVERAGE_PARAM = 'coverage'
 
   before_action :load_group
   before_action -> { check_feature_availability!(:group_coverage_reports) }

ee/app/finders/dast_site_validations_finder.rb

 # frozen_string_literal: true
 
 class DastSiteValidationsFinder
-  DEFAULT_SORT_VALUE = 'id'.freeze
-  DEFAULT_SORT_DIRECTION = 'desc'.freeze
+  DEFAULT_SORT_VALUE = 'id'
+  DEFAULT_SORT_DIRECTION = 'desc'
 
   def initialize(params = {})
     @params = params

ee/app/models/ee/issue.rb

@@ -7,9 +7,9 @@ module EE
 
     prepended do
       WEIGHT_RANGE = (0..20).freeze
-      WEIGHT_ALL = 'Everything'.freeze
-      WEIGHT_ANY = 'Any'.freeze
-      WEIGHT_NONE = 'None'.freeze
+      WEIGHT_ALL = 'Everything'
+      WEIGHT_ANY = 'Any'
+      WEIGHT_NONE = 'None'
       ELASTICSEARCH_PERMISSION_TRACKED_FIELDS = %w(assignee_ids author_id confidential).freeze
 
       include Elastic::ApplicationVersionedSearch

ee/app/models/ee/plan.rb

@@ -6,12 +6,12 @@ module EE
     extend ::Gitlab::Utils::Override
 
     prepended do
-      FREE = 'free'.freeze
-      BRONZE = 'bronze'.freeze
-      SILVER = 'silver'.freeze
-      PREMIUM = 'premium'.freeze
-      GOLD = 'gold'.freeze
-      ULTIMATE = 'ultimate'.freeze
+      FREE = 'free'
+      BRONZE = 'bronze'
+      SILVER = 'silver'
+      PREMIUM = 'premium'
+      GOLD = 'gold'
+      ULTIMATE = 'ultimate'
 
       EE_DEFAULT_PLANS = (const_get(:DEFAULT_PLANS, false) + [FREE]).freeze
       PAID_HOSTED_PLANS = [BRONZE, SILVER, PREMIUM, GOLD, ULTIMATE].freeze

ee/app/models/geo_node_status.rb

@@ -190,8 +190,8 @@ class GeoNodeStatus < ApplicationRecord
   }.merge(replicator_class_prometheus_metrics).freeze
 
   EXPIRATION_IN_MINUTES = 10
-  HEALTHY_STATUS = 'Healthy'.freeze
-  UNHEALTHY_STATUS = 'Unhealthy'.freeze
+  HEALTHY_STATUS = 'Healthy'
+  UNHEALTHY_STATUS = 'Unhealthy'
 
   def self.alternative_status_store_accessor(attr_names)
     attr_names.each do |attr_name|

ee/app/models/productivity_analytics.rb

@@ -14,7 +14,7 @@ class ProductivityAnalytics
   }.freeze
 
   METRIC_TYPES = METRIC_COLUMNS.keys.freeze
-  DEFAULT_TYPE = 'days_to_merge'.freeze
+  DEFAULT_TYPE = 'days_to_merge'
 
   def self.start_date
     ApplicationSetting.current&.productivity_analytics_start_date

ee/app/models/saml_provider.rb

@@ -53,7 +53,7 @@ class SamlProvider < ApplicationRecord
   class DefaultOptions
     include Gitlab::Routing
 
-    NAME_IDENTIFIER_FORMAT = 'urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified'.freeze
+    NAME_IDENTIFIER_FORMAT = 'urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified'
 
     def initialize(group_path)
       @group_path = group_path