Commit 12880ac3 authored by Mark Florian's avatar Mark Florian

Address vue i18n literal string violations

This is a follow-up to
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/69622.

In dismiss_button.vue, the __() call was removed, since the argument
is already in a translated form via s__().

In modal_footer.vue, the __() call was removed, since the argument
is already in a translated form via s__().

In minutes_usage_project_chart.vue, the GlSprintf component was removed,
since it was effectively a no-op as it had no slots provided. The actual
rule violation has not been fixed, as it requires a bit more work to
solve correctly.
parent 7dd67b23
<script>
import { GlDropdown, GlDropdownItem, GlSprintf } from '@gitlab/ui';
import { GlDropdown, GlDropdownItem } from '@gitlab/ui';
import { GlColumnChart } from '@gitlab/ui/dist/charts';
import { keyBy } from 'lodash';
import {
......@@ -18,7 +18,6 @@ export default {
GlColumnChart,
GlDropdown,
GlDropdownItem,
GlSprintf,
},
props: {
minutesUsageData: {
......@@ -89,7 +88,7 @@ export default {
@click="changeSelectedMonth(monthName)"
>
<!-- eslint-disable-next-line @gitlab/vue-require-string-literal-i18n-helpers -->
<gl-sprintf :message="__(monthName)" />
{{ __(monthName) }}
</gl-dropdown-item>
</gl-dropdown>
</div>
......
......@@ -55,8 +55,7 @@ export default {
class="js-dismiss-btn"
@click="handleDismissClick"
>
<!-- eslint-disable-next-line @gitlab/vue-require-string-literal-i18n-helpers -->
{{ __(buttonText) }}
{{ buttonText }}
</gl-button>
<gl-button
v-if="!isDismissed"
......
......@@ -147,8 +147,7 @@ export default {
data-qa-selector="create_issue_button"
@click="$emit(actionButtons[0].action)"
>
<!-- eslint-disable-next-line @gitlab/vue-require-string-literal-i18n-helpers -->
{{ __(actionButtons[0].name) }}
{{ actionButtons[0].name }}
</gl-button>
</div>
</template>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment