Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
12d82f31
Commit
12d82f31
authored
Jun 18, 2021
by
Albert Salim
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make review-qa report jobs wait for test jobs
parent
a3415e03
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
23 additions
and
4 deletions
+23
-4
.gitlab/ci/rules.gitlab-ci.yml
.gitlab/ci/rules.gitlab-ci.yml
+23
-4
No files found.
.gitlab/ci/rules.gitlab-ci.yml
View file @
12d82f31
...
...
@@ -1200,19 +1200,31 @@
changes
:
*code-qa-patterns
allow_failure
:
true
# The rule needs to be duplicated between `on_success` and `on_failure`
# because the jobs `needs` the previous job to complete.
# See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63844#note_599012559
.review:rules:review-qa-smoke-report:
rules
:
-
<<
:
*if-not-ee
when
:
never
-
<<
:
*if-dot-com-gitlab-org-merge-request
changes
:
*ci-review-patterns
when
:
always
when
:
on_success
-
<<
:
*if-dot-com-gitlab-org-merge-request
changes
:
*ci-review-patterns
when
:
on_failure
-
<<
:
*if-dot-com-gitlab-org-merge-request
changes
:
*frontend-patterns
when
:
always
when
:
on_success
-
<<
:
*if-dot-com-gitlab-org-merge-request
changes
:
*frontend-patterns
when
:
on_failure
-
<<
:
*if-dot-com-gitlab-org-merge-request
changes
:
*code-qa-patterns
when
:
always
when
:
on_success
-
<<
:
*if-dot-com-gitlab-org-merge-request
changes
:
*code-qa-patterns
when
:
on_failure
.review:rules:review-qa-all:
rules
:
...
...
@@ -1226,6 +1238,9 @@
changes
:
*qa-patterns
allow_failure
:
true
# The rule needs to be duplicated between `on_success` and `on_failure`
# because the jobs `needs` the previous job to complete.
# See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63844#note_599012559
.review:rules:review-qa-all-report:
rules
:
-
<<
:
*if-not-ee
...
...
@@ -1237,7 +1252,11 @@
-
<<
:
*if-dot-com-gitlab-org-merge-request
changes
:
*qa-patterns
allow_failure
:
true
when
:
always
when
:
on_success
-
<<
:
*if-dot-com-gitlab-org-merge-request
changes
:
*qa-patterns
allow_failure
:
true
when
:
on_failure
.review:rules:review-cleanup:
rules
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment