Merge branch 'add-scanner-name-to-row' into 'master'

Add report type & scanner name to security dashboards

See merge request gitlab-org/gitlab!31775

ee/app/assets/javascripts/security_dashboard/components/security_dashboard_table.vue

@@ -77,6 +77,9 @@ export default {
       <div class="table-section flex-grow-1" role="rowheader">
         {{ s__('Reports|Vulnerability') }}
       </div>
+      <div class="table-section section-15" role="rowheader">
+        {{ s__('Reports|Scanner') }}
+      </div>
       <div class="table-section section-20" role="rowheader"></div>
     </div>
 

ee/app/assets/javascripts/security_dashboard/components/security_dashboard_table_row.vue

@@ -43,6 +43,10 @@ export default {
       }
       return location && (location.image || location.file || location.path);
     },
+    vulnerabilityScanner() {
+      const { scanner } = this.vulnerability;
+      return scanner?.name;
+    },
     isDismissed() {
       return Boolean(this.vulnerability.dismissal_feedback);
     },
@@ -135,6 +139,13 @@ export default {
       </div>
     </div>
 
+    <div class="table-section section-15">
+      <div class="table-mobile-header" role="rowheader">{{ s__('Reports|Scanner') }}</div>
+      <div class="table-mobile-content">
+        {{ vulnerabilityScanner }}
+      </div>
+    </div>
+
     <div class="table-section section-20">
       <div class="table-mobile-header" role="rowheader">{{ s__('Reports|Actions') }}</div>
       <div class="table-mobile-content action-buttons d-flex justify-content-end">

ee/app/assets/javascripts/security_dashboard/helpers.js

@@ -27,7 +27,7 @@ export const initFirstClassVulnerabilityFilters = projects => {
       selection: new Set([ALL]),
     },
     {
-      name: s__('SecurityReports|Report type'),
+      name: s__('Reports|Scanner'),
       id: 'reportType',
       options: [BASE_FILTERS.report_type, ...parseOptions(REPORT_TYPES)],
       selection: new Set([ALL]),

ee/app/assets/javascripts/security_dashboard/store/modules/filters/constants.js

@@ -8,7 +8,7 @@ export const BASE_FILTERS = {
     id: ALL,
   },
   report_type: {
-    name: s__('ciReport|All report types'),
+    name: s__('ciReport|All scanner types'),
     id: ALL,
   },
   project_id: {

ee/app/assets/javascripts/security_dashboard/store/modules/filters/state.js

@@ -14,7 +14,7 @@ export default () => ({
       selection: new Set([BASE_FILTERS.severity.id]),
     },
     {
-      name: s__('SecurityReports|Report type'),
+      name: s__('SecurityReports|Scanner type'),
       id: 'report_type',
       options: [BASE_FILTERS.report_type, ...optionsObjectToArray(REPORT_TYPES)],
       hidden: false,

ee/app/assets/javascripts/vulnerabilities/components/vulnerability_list.vue

@@ -93,6 +93,11 @@ export default {
           label: __('Description'),
           thClass: commonThClass,
         },
+        {
+          key: 'reportType',
+          label: s__('Reports|Scanner'),
+          thClass: `${commonThClass}`,
+        },
       ];
     },
   },
@@ -201,6 +206,10 @@ export default {
         <remediated-badge v-if="item.resolved_on_default_branch" class="ml-2" />
       </template>
 
+      <template #cell(reportType)="{ item }">
+        <span class="text-capitalize js-reportType">{{ item.reportType }}</span>
+      </template>
+
       <template #table-busy>
         <gl-skeleton-loading
           v-for="n in $options.VULNERABILITIES_PER_PAGE"

ee/app/assets/javascripts/vulnerabilities/graphql/vulnerability.fragment.graphql

@@ -4,6 +4,7 @@ fragment Vulnerability on Vulnerability {
   state
   severity
   vulnerabilityPath
+  reportType
   location {
     ... on VulnerabilityLocationContainerScanning {
       image

ee/changelogs/unreleased/add-scanner-name-to-row.yml

+---
+title: Add scanner name to vulnerability row
+merge_request: 31775
+author:
+type: changed

ee/spec/frontend/security_dashboard/components/security_dashboard_table_row_spec.js

@@ -77,6 +77,14 @@ describe('Security Dashboard Table Row', () => {
       ).toContain(wrapper.props().vulnerability.severity);
     });
 
+    it('should render the scanner name', () => {
+      expect(
+        findContent(2)
+          .text()
+          .toLowerCase(),
+      ).toContain(wrapper.props().vulnerability.scanner.name.toLowerCase());
+    });
+
     describe('the project name', () => {
       it('should render the name', () => {
         expect(findContent(1).text()).toContain(wrapper.props().vulnerability.name);

ee/spec/frontend/vulnerabilities/mock_data.js

@@ -4,6 +4,7 @@ export const generateVulnerabilities = () => [
     title: 'Vulnerability 1',
     severity: 'critical',
     state: 'dismissed',
+    reportType: 'sast',
     location: {
       image:
         'registry.gitlab.com/groulot/container-scanning-test/master:5f21de6956aee99ddb68ae49498662d9872f50ff',
@@ -17,6 +18,7 @@ export const generateVulnerabilities = () => [
     title: 'Vulnerability 2',
     severity: 'high',
     state: 'opened',
+    reportType: 'sast',
     location: {
       file: 'src/main/java/com/gitlab/security_products/tests/App.java',
     },

ee/spec/frontend/vulnerabilities/vulnerability_list_spec.js

@@ -63,6 +63,11 @@ describe('Vulnerability list component', () => {
       expect(cell.text().toLowerCase()).toBe(newVulnerabilities[0].severity);
     });
 
+    it('should correctly render the scanner type', () => {
+      const cell = findCell('reportType');
+      expect(cell.text().toLowerCase()).toBe(newVulnerabilities[0].reportType);
+    });
+
     it('should correctly render the description', () => {
       const cell = findCell('description');
 

locale/gitlab.pot

@@ -18190,6 +18190,9 @@ msgstr ""
 msgid "Reports|Metrics reports failed loading results"
 msgstr ""
 
+msgid "Reports|Scanner"
+msgstr ""
+
 msgid "Reports|Severity"
 msgstr ""
 
@@ -19140,10 +19143,10 @@ msgstr ""
 msgid "SecurityReports|Remove project from dashboard"
 msgstr ""
 
-msgid "SecurityReports|Report type"
+msgid "SecurityReports|Return to dashboard"
 msgstr ""
 
-msgid "SecurityReports|Return to dashboard"
+msgid "SecurityReports|Scanner type"
 msgstr ""
 
 msgid "SecurityReports|Security Dashboard"
@@ -25704,7 +25707,7 @@ msgstr ""
 msgid "ciReport|All projects"
 msgstr ""
 
-msgid "ciReport|All report types"
+msgid "ciReport|All scanner types"
 msgstr ""
 
 msgid "ciReport|All severities"