Merge branch...

Merge branch '218045-feature-flag-remove-feature-flag-for-create-issue-from-alert-detail-page' into 'master'

Remove feature flag for "Create issue" from alert detail page

See merge request gitlab-org/gitlab!33221

app/services/alert_management/create_alert_issue_service.rb

@@ -29,8 +29,7 @@ module AlertManagement
     delegate :project, to: :alert
 
     def allowed?
-      Feature.enabled?(:alert_management_create_alert_issue, project) &&
-        user.can?(:create_issue, project)
+      user.can?(:create_issue, project)
     end
 
     def create_issue(alert, user, alert_payload)

changelogs/unreleased/218045-feature-flag-remove-feature-flag-for-create-issue-from-alert-detai.yml

+---
+title: Add button to create an issue from an alert management alert
+merge_request: 33221
+author:
+type: added

doc/user/project/operations/alert_management.md

@@ -72,8 +72,20 @@ You will need at least Developer [permissions](../../permissions.md) to view Ale
 
 Navigate to the Alert Management detail view by visiting the [Alert Management list](#alert-management-list) and selecting an Alert from the list.
 
-![Alert Management Detail View](img/alert_detail_v13_0.png)
+![Alert Management Detail Overview](img/alert_detail_overview_v13_1.png)
+
+![Alert Management Full Details](img/alert_detail_full_v13_1.png)
 
 ### Update an Alert's status
 
-The Alert Management detail view allows users to update the Alert Status. See [Alert Management statuses](#alert-management-statuses) for more details.
+The Alert Management detail view enables you to update the Alert Status.
+See [Alert Management statuses](#alert-management-statuses) for more details.
+
+### Create an Issue from an Alert
+
+> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/217745) in GitLab 13.1.
+
+The Alert Management detail view enables you to create an issue with a
+description automatically populated from an alert. To create the issue,
+click the **Create Issue** button. You can then view the issue from the
+alert by clicking the **View Issue** button.

spec/services/alert_management/create_alert_issue_service_spec.rb

@@ -118,17 +118,6 @@ RSpec.describe AlertManagement::CreateAlertIssueService do
           expect(execute.message).to eq(_('An issue already exists'))
         end
       end
-
-      context 'when alert_management_create_alert_issue feature flag is disabled' do
-        before do
-          stub_feature_flags(alert_management_create_alert_issue: false)
-        end
-
-        it 'responds with error' do
-          expect(execute).to be_error
-          expect(execute.message).to eq(_('You have no permissions'))
-        end
-      end
     end
 
     context 'when a user is not allowed to create an issue' do