Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1378be87
Commit
1378be87
authored
Jan 08, 2021
by
David Kim
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable reviewer_approval_rules feature by default
parent
86bfedbc
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
3 deletions
+8
-3
app/controllers/projects/merge_requests/creations_controller.rb
...ntrollers/projects/merge_requests/creations_controller.rb
+1
-1
app/controllers/projects/merge_requests_controller.rb
app/controllers/projects/merge_requests_controller.rb
+1
-1
changelogs/unreleased/default-enabled-reviewer-approval-rules.yml
...gs/unreleased/default-enabled-reviewer-approval-rules.yml
+5
-0
config/feature_flags/development/reviewer_approval_rules.yml
config/feature_flags/development/reviewer_approval_rules.yml
+1
-1
No files found.
app/controllers/projects/merge_requests/creations_controller.rb
View file @
1378be87
...
@@ -14,7 +14,7 @@ class Projects::MergeRequests::CreationsController < Projects::MergeRequests::Ap
...
@@ -14,7 +14,7 @@ class Projects::MergeRequests::CreationsController < Projects::MergeRequests::Ap
before_action
do
before_action
do
push_frontend_feature_flag
(
:merge_request_reviewers
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:merge_request_reviewers
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:mr_collapsed_approval_rules
,
@project
)
push_frontend_feature_flag
(
:mr_collapsed_approval_rules
,
@project
)
push_frontend_feature_flag
(
:reviewer_approval_rules
,
@project
)
push_frontend_feature_flag
(
:reviewer_approval_rules
,
@project
,
default_enabled: :yaml
)
end
end
def
new
def
new
...
...
app/controllers/projects/merge_requests_controller.rb
View file @
1378be87
...
@@ -53,7 +53,7 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
...
@@ -53,7 +53,7 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
push_frontend_feature_flag
(
:vue_issuable_sidebar
,
@project
.
group
)
push_frontend_feature_flag
(
:vue_issuable_sidebar
,
@project
.
group
)
push_frontend_feature_flag
(
:merge_request_reviewers
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:merge_request_reviewers
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:mr_collapsed_approval_rules
,
@project
)
push_frontend_feature_flag
(
:mr_collapsed_approval_rules
,
@project
)
push_frontend_feature_flag
(
:reviewer_approval_rules
,
@project
)
push_frontend_feature_flag
(
:reviewer_approval_rules
,
@project
,
default_enabled: :yaml
)
end
end
around_action
:allow_gitaly_ref_name_caching
,
only:
[
:index
,
:show
,
:discussions
]
around_action
:allow_gitaly_ref_name_caching
,
only:
[
:index
,
:show
,
:discussions
]
...
...
changelogs/unreleased/default-enabled-reviewer-approval-rules.yml
0 → 100644
View file @
1378be87
---
title
:
Enable reviewer_approval_rules by default
merge_request
:
51183
author
:
type
:
changed
config/feature_flags/development/reviewer_approval_rules.yml
View file @
1378be87
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/293742
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/293742
milestone
:
'
13.7'
milestone
:
'
13.7'
type
:
development
type
:
development
group
:
group::code review
group
:
group::code review
default_enabled
:
fals
e
default_enabled
:
tru
e
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment