Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1532bd2b
Commit
1532bd2b
authored
Apr 16, 2020
by
Sanad Liaquat
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add extra logging on ip address restriction spec
parent
65f019e5
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
0 deletions
+21
-0
qa/qa/ee/page/group/settings/general.rb
qa/qa/ee/page/group/settings/general.rb
+1
-0
qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb
.../browser_ui/1_manage/group/restrict_by_ip_address_spec.rb
+20
-0
No files found.
qa/qa/ee/page/group/settings/general.rb
View file @
1532bd2b
...
@@ -66,6 +66,7 @@ module QA
...
@@ -66,6 +66,7 @@ module QA
def
restricted_ip_address
def
restricted_ip_address
expand_section
(
:permission_lfs_2fa_section
)
expand_section
(
:permission_lfs_2fa_section
)
scroll_to_element
(
:ip_restriction_field
)
find_element
(
:ip_restriction_field
).
value
find_element
(
:ip_restriction_field
).
value
end
end
...
...
qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb
View file @
1532bd2b
...
@@ -62,6 +62,26 @@ module QA
...
@@ -62,6 +62,26 @@ module QA
end
end
end
end
# TODO - Remove this block when the test is un-quarantined.
after
do
|
example
|
if
example
.
exception
@group
.
sandbox
.
visit!
QA
::
Runtime
::
Logger
.
info
"On failure - Revisiting:
#{
@group
.
sandbox
.
path
}
"
QA
::
Runtime
::
Logger
.
info
page
.
save_screenshot
(
::
File
.
join
(
QA
::
Runtime
::
Namespace
.
name
,
"group_sandbox_on_failure.png"
),
full:
true
)
Flow
::
Login
.
while_signed_in_as_admin
do
@group
.
sandbox
.
visit!
Page
::
Group
::
Menu
.
perform
(
&
:click_group_general_settings_item
)
Page
::
Group
::
Settings
::
General
.
perform
do
|
settings
|
QA
::
Runtime
::
Logger
.
info
"On failure - IP address restriction is set to:
#{
settings
.
restricted_ip_address
}
"
QA
::
Runtime
::
Logger
.
info
page
.
save_screenshot
(
::
File
.
join
(
QA
::
Runtime
::
Namespace
.
name
,
"ip_restriction_on_failure.png"
),
full:
true
)
end
end
end
end
private
private
def
set_ip_address_restriction_to
(
ip_address
)
def
set_ip_address_restriction_to
(
ip_address
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment