Merge branch 'xanf-remove-isEmpty-false' into 'master'

Replace isEmpty() check with other expectations

See merge request gitlab-org/gitlab!40215

spec/frontend/import_projects/components/import_projects_table_spec.js

@@ -110,8 +110,8 @@ describe('ImportProjectsTable', () => {
       wrapper
         .findAll('th')
         .filter(w => w.text() === `From ${providerTitle}`)
-        .isEmpty(),
-    ).toBe(false);
+        .exists(),
+    ).toBe(true);
 
     expect(wrapper.contains(ProviderRepoTableRow)).toBe(true);
     expect(wrapper.contains(ImportedProjectTableRow)).toBe(true);

spec/frontend/issuable_suggestions/components/app_spec.js

@@ -41,7 +41,7 @@ describe('Issuable suggestions app component', () => {
       wrapper.setData(data);
 
       return wrapper.vm.$nextTick(() => {
-        expect(wrapper.isEmpty()).toBe(false);
+        expect(wrapper.findAll('li').length).toBe(data.issues.length);
       });
     });
 

spec/frontend/logs/components/environment_logs_spec.js

@@ -122,7 +122,6 @@ describe('EnvironmentLogs', () => {
     initWrapper();
 
     expect(wrapper.isVueInstance()).toBe(true);
-    expect(wrapper.isEmpty()).toBe(false);
 
     expect(findEnvironmentsDropdown().is(GlDeprecatedDropdown)).toBe(true);
     expect(findSimpleFilters().exists()).toBe(true);

spec/frontend/logs/components/log_advanced_filters_spec.js

@@ -69,7 +69,6 @@ describe('LogAdvancedFilters', () => {
     initWrapper();
 
     expect(wrapper.isVueInstance()).toBe(true);
-    expect(wrapper.isEmpty()).toBe(false);
 
     expect(findFilteredSearch().exists()).toBe(true);
     expect(findTimeRangePicker().exists()).toBe(true);

spec/frontend/logs/components/log_control_buttons_spec.js

@@ -29,7 +29,6 @@ describe('LogControlButtons', () => {
     initWrapper();
 
     expect(wrapper.isVueInstance()).toBe(true);
-    expect(wrapper.isEmpty()).toBe(false);
 
     expect(findScrollToTop().is(GlButton)).toBe(true);
     expect(findScrollToBottom().is(GlButton)).toBe(true);

spec/frontend/logs/components/log_simple_filters_spec.js

@@ -60,7 +60,6 @@ describe('LogSimpleFilters', () => {
     initWrapper();
 
     expect(wrapper.isVueInstance()).toBe(true);
-    expect(wrapper.isEmpty()).toBe(false);
 
     expect(findPodsDropdown().exists()).toBe(true);
   });

spec/frontend/monitoring/components/dashboard_spec.js

@@ -668,7 +668,11 @@ describe('Dashboard', () => {
         });
 
         it('shows a remove button, which removes a panel', () => {
-          expect(findFirstDraggableRemoveButton().isEmpty()).toBe(false);
+          expect(
+            findFirstDraggableRemoveButton()
+              .find('a')
+              .exists(),
+          ).toBe(true);
 
           expect(findDraggablePanels().length).toEqual(metricsDashboardPanelCount);
           findFirstDraggableRemoveButton().trigger('click');

spec/frontend/pipelines/components/pipelines_filtered_search_spec.js

@@ -48,7 +48,6 @@ describe('Pipelines filtered search', () => {
 
   it('displays UI elements', () => {
     expect(wrapper.isVueInstance()).toBe(true);
-    expect(wrapper.isEmpty()).toBe(false);
 
     expect(findFilteredSearch().exists()).toBe(true);
   });

spec/frontend/vue_shared/components/table_pagination_spec.js

@@ -50,7 +50,7 @@ describe('Pagination component', () => {
         change: spy,
       });
 
-      expect(wrapper.isEmpty()).toBe(false);
+      expect(wrapper.find(GlPagination).exists()).toBe(true);
     });
 
     it('renders if there is a prev page', () => {
@@ -66,7 +66,7 @@ describe('Pagination component', () => {
         change: spy,
       });
 
-      expect(wrapper.isEmpty()).toBe(false);
+      expect(wrapper.find(GlPagination).exists()).toBe(true);
     });
   });