Merge branch 'pl-service-response-success-http-status' into 'master'

Set default http status of a successful ServiceResponse

See merge request gitlab-org/gitlab!16608

app/services/service_response.rb

 # frozen_string_literal: true
 
 class ServiceResponse
-  def self.success(message: nil, payload: {})
-    new(status: :success, message: message, payload: payload)
+  def self.success(message: nil, payload: {}, http_status: :ok)
+    new(status: :success, message: message, payload: payload, http_status: http_status)
   end
 
   def self.error(message:, payload: {}, http_status: nil)

spec/services/service_response_spec.rb

@@ -23,6 +23,20 @@ describe ServiceResponse do
       expect(response).to be_success
       expect(response.payload).to eq(good: 'orange')
     end
+
+    it 'creates a successful response with default HTTP status' do
+      response = described_class.success
+
+      expect(response).to be_success
+      expect(response.http_status).to eq(:ok)
+    end
+
+    it 'creates a successful response with custom HTTP status' do
+      response = described_class.success(http_status: 204)
+
+      expect(response).to be_success
+      expect(response.http_status).to eq(204)
+    end
   end
 
   describe '.error' do