Commit 15b8749b authored by Clement Ho's avatar Clement Ho

Fix eslint

parent a216d424
<script> <script>
import eventHub from '../event_hub';
import relatedIssueMixin from '../mixins/related_issues_mixin'; import relatedIssueMixin from '../mixins/related_issues_mixin';
export default { export default {
......
<script> <script>
import eventHub from '../event_hub';
import tooltip from '../../../vue_shared/directives/tooltip';
import relatedIssueMixin from '../mixins/related_issues_mixin'; import relatedIssueMixin from '../mixins/related_issues_mixin';
export default { export default {
......
<script> <script>
import Sortable from 'vendor/Sortable';
import loadingIcon from '~/vue_shared/components/loading_icon.vue'; import loadingIcon from '~/vue_shared/components/loading_icon.vue';
import tooltip from '~/vue_shared/directives/tooltip'; import tooltip from '~/vue_shared/directives/tooltip';
import eventHub from '../event_hub'; import eventHub from '../event_hub';
......
...@@ -34,7 +34,6 @@ const SPACE_FACTOR = 1; ...@@ -34,7 +34,6 @@ const SPACE_FACTOR = 1;
export default { export default {
name: 'RelatedIssuesRoot', name: 'RelatedIssuesRoot',
props: { props: {
endpoint: { endpoint: {
type: String, type: String,
...@@ -66,7 +65,6 @@ export default { ...@@ -66,7 +65,6 @@ export default {
default: true, default: true,
}, },
}, },
data() { data() {
this.store = new RelatedIssuesStore(); this.store = new RelatedIssuesStore();
...@@ -78,24 +76,21 @@ export default { ...@@ -78,24 +76,21 @@ export default {
inputValue: '', inputValue: '',
}; };
}, },
components: { components: {
relatedIssuesBlock: RelatedIssuesBlock, relatedIssuesBlock: RelatedIssuesBlock,
}, },
computed: { computed: {
autoCompleteSources() { autoCompleteSources() {
if (!this.allowAutoComplete) return {}; if (!this.allowAutoComplete) return {};
return gl.GfmAutoComplete && gl.GfmAutoComplete.dataSources; return gl.GfmAutoComplete && gl.GfmAutoComplete.dataSources;
}, },
}, },
methods: { methods: {
onRelatedIssueRemoveRequest(idToRemove) { onRelatedIssueRemoveRequest(idToRemove) {
const issueToRemove = _.find(this.state.relatedIssues, issue => issue.id === idToRemove); const issueToRemove = _.find(this.state.relatedIssues, issue => issue.id === idToRemove);
if (issueToRemove) { if (issueToRemove) {
this.service.removeRelatedIssue(issueToRemove.relation_path) RelatedIssuesService.remove(issueToRemove.relation_path)
.then(res => res.json()) .then(res => res.json())
.then((data) => { .then((data) => {
this.store.setRelatedIssues(data.issues); this.store.setRelatedIssues(data.issues);
...@@ -161,16 +156,15 @@ export default { ...@@ -161,16 +156,15 @@ export default {
}); });
}, },
saveIssueOrder({ issueId, newOrder = 1 }) { saveIssueOrder({ issueId, newOrder = 1 }) {
const issue = _.find(this.state.relatedIssues, issue => issue.id === issueId); const issueToReorder = _.find(this.state.relatedIssues, issue => issue.id === issueId);
if (issue) { if (issueToReorder) {
this.service.saveRelatedIssueOrder({ RelatedIssuesService.saveOrder({
endpoint: issue.relation_path, endpoint: issueToReorder.relation_path,
position: newOrder, position: newOrder,
}); });
} }
}, },
onInput(newValue, caretPos) { onInput(newValue, caretPos) {
const rawReferences = newValue const rawReferences = newValue
.split(/\s/); .split(/\s/);
...@@ -210,7 +204,6 @@ export default { ...@@ -210,7 +204,6 @@ export default {
this.inputValue = ''; this.inputValue = '';
}, },
}, },
created() { created() {
eventHub.$on('relatedIssue-removeRequest', this.onRelatedIssueRemoveRequest); eventHub.$on('relatedIssue-removeRequest', this.onRelatedIssueRemoveRequest);
eventHub.$on('toggleAddRelatedIssuesForm', this.onToggleAddRelatedIssuesForm); eventHub.$on('toggleAddRelatedIssuesForm', this.onToggleAddRelatedIssuesForm);
...@@ -223,7 +216,6 @@ export default { ...@@ -223,7 +216,6 @@ export default {
this.service = new RelatedIssuesService(this.endpoint); this.service = new RelatedIssuesService(this.endpoint);
this.fetchRelatedIssues(); this.fetchRelatedIssues();
}, },
beforeDestroy() { beforeDestroy() {
eventHub.$off('relatedIssue-removeRequest', this.onRelatedIssueRemoveRequest); eventHub.$off('relatedIssue-removeRequest', this.onRelatedIssueRemoveRequest);
eventHub.$off('toggleAddRelatedIssuesForm', this.onToggleAddRelatedIssuesForm); eventHub.$off('toggleAddRelatedIssuesForm', this.onToggleAddRelatedIssuesForm);
......
...@@ -18,7 +18,7 @@ class RelatedIssuesService { ...@@ -18,7 +18,7 @@ class RelatedIssuesService {
}); });
} }
saveRelatedIssueOrder({ endpoint, position }) { static saveOrder({ endpoint, position }) {
return Vue.http.put(endpoint, { return Vue.http.put(endpoint, {
epic: { epic: {
position, position,
...@@ -26,8 +26,7 @@ class RelatedIssuesService { ...@@ -26,8 +26,7 @@ class RelatedIssuesService {
}); });
} }
// eslint-disable-next-line class-methods-use-this static remove(endpoint) {
removeRelatedIssue(endpoint) {
return Vue.http.delete(endpoint); return Vue.http.delete(endpoint);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment