Merge branch 'notifications-helper-cleanup' into 'master'

NotificationsHelper: Remove unused helper methods

See merge request gitlab-org/gitlab!55346

app/helpers/notifications_helper.rb

@@ -72,52 +72,6 @@ module NotificationsHelper
     end
   end
 
-  def notification_list_item(level, setting)
-    title = notification_title(level)
-
-    data = {
-      notification_level: level,
-      notification_title: title
-    }
-
-    content_tag(:li, role: "menuitem") do
-      link_to '#', class: "update-notification #{('is-active' if setting.level == level)}", data: data do
-        link_output = content_tag(:strong, title, class: 'dropdown-menu-inner-title')
-        link_output << content_tag(:span, notification_description(level), class: 'dropdown-menu-inner-content')
-      end
-    end
-  end
-
-  # Identifier to trigger individually dropdowns and custom settings modals in the same view
-  def notifications_menu_identifier(type, notification_setting)
-    "#{type}-#{notification_setting.user_id}-#{notification_setting.source_id}-#{notification_setting.source_type}"
-  end
-
-  # Create hidden field to send notification setting source to controller
-  def hidden_setting_source_input(notification_setting)
-    return unless notification_setting.source_type
-
-    hidden_field_tag "#{notification_setting.source_type.downcase}_id", notification_setting.source_id
-  end
-
-  def notification_event_name(event)
-    # All values from NotificationSetting.email_events
-    case event
-    when :success_pipeline
-      s_('NotificationEvent|Successful pipeline')
-    else
-      event_name = "NotificationEvent|#{event.to_s.humanize}"
-      s_(event_name)
-    end
-  end
-
-  def notification_setting_icon(notification_setting = nil)
-    sprite_icon(
-      !notification_setting.present? || notification_setting.disabled? ? "notifications-off" : "notifications",
-      css_class: "icon notifications-icon js-notifications-icon"
-    )
-  end
-
   def show_unsubscribe_title?(noteable)
     can?(current_user, "read_#{noteable.to_ability_name}".to_sym, noteable)
   end

spec/helpers/notifications_helper_spec.rb

@@ -19,22 +19,6 @@ RSpec.describe NotificationsHelper do
     it { expect(notification_title(:global)).to match('Global') }
   end
 
-  describe '#notification_event_name' do
-    context 'for success_pipeline' do
-      it 'returns the custom name' do
-        expect(FastGettext).to receive(:cached_find).with('NotificationEvent|Successful pipeline')
-        expect(notification_event_name(:success_pipeline)).to eq('Successful pipeline')
-      end
-    end
-
-    context 'for everything else' do
-      it 'returns a humanized name' do
-        expect(FastGettext).to receive(:cached_find).with('NotificationEvent|Failed pipeline')
-        expect(notification_event_name(:failed_pipeline)).to eq('Failed pipeline')
-      end
-    end
-  end
-
   describe '#notification_icon_level' do
     let(:user) { create(:user) }
     let(:global_setting) { user.global_notification_setting }