Merge branch 'tz-remove-unnecessary-inlinejavascript-lints-disablers' into 'master'

Removing old unnecessary HAML Linting for Inline JS

See merge request gitlab-org/gitlab!42574

app/views/authentication/_register.html.haml

 #js-register-token-2fa
 
--# haml-lint:disable InlineJavaScript
 %script#js-register-2fa-message{ type: "text/template" }
   %p <%= message %>
 

app/views/projects/branches/new.html.haml

@@ -28,5 +28,4 @@
   .form-actions
     = button_tag 'Create branch', class: 'btn btn-success', tabindex: 3
     = link_to 'Cancel', project_branches_path(@project), class: 'btn btn-cancel'
--# haml-lint:disable InlineJavaScript
 %script#availableRefs{ type: "application/json" }= @project.repository.ref_names.to_json.html_safe

app/views/projects/pipelines/new.html.haml

@@ -43,5 +43,4 @@
       = f.submit s_('Pipeline|Run Pipeline'), class: 'btn btn-success js-variables-save-button', tabindex: 3
       = link_to _('Cancel'), project_pipelines_path(@project), class: 'btn btn-default float-right'
 
-  -# haml-lint:disable InlineJavaScript
   %script#availableRefs{ type: "application/json" }= @project.repository.ref_names.to_json.html_safe

app/views/projects/tags/new.html.haml

@@ -54,5 +54,4 @@
   .form-actions
     = button_tag s_('TagsPage|Create tag'), class: 'btn btn-success', data: { qa_selector: "create_tag_button" }
     = link_to s_('TagsPage|Cancel'), project_tags_path(@project), class: 'btn btn-cancel'
--# haml-lint:disable InlineJavaScript
 %script#availableRefs{ type: "application/json" }= @project.repository.ref_names.to_json.html_safe

app/views/shared/boards/_show.html.haml

@@ -11,7 +11,6 @@
 
 - content_for :page_specific_javascripts do
 
-  -# haml-lint:disable InlineJavaScript
   %script#js-board-modal-filter{ type: "text/x-template" }= render "shared/issuable/search_bar", type: :boards_modal, show_sorting_dropdown: false
   %script#js-board-promotion{ type: "text/x-template" }= render_if_exists "shared/promotions/promote_issue_board"
 

app/views/shared/issuable/_sidebar.html.haml

@@ -146,11 +146,9 @@
           .js-sidebar-status-entry-point
 
         - if issuable_sidebar.has_key?(:confidential)
-          -# haml-lint:disable InlineJavaScript
           %script#js-confidential-issue-data{ type: "application/json" }= { is_confidential: issuable_sidebar[:confidential], is_editable: can_edit_issuable }.to_json.html_safe
           #js-confidential-entry-point
 
-        -# haml-lint:disable InlineJavaScript
         %script#js-lock-issue-data{ type: "application/json" }= { is_locked: !!issuable_sidebar[:discussion_locked], is_editable: can_edit_issuable }.to_json.html_safe
         #js-lock-entry-point
 

app/views/shared/notes/_notes_with_form.html.haml

@@ -28,5 +28,4 @@
       = sprite_icon('lock', css_class: 'icon')
       %span
         = html_escape(_("This %{issuable} is locked. Only %{strong_open}project members%{strong_close} can comment.")) % { issuable: issuable.class.to_s.titleize.downcase, strong_open: '<strong>'.html_safe, strong_close: '</strong>'.html_safe }
--# haml-lint:disable InlineJavaScript
 %script.js-notes-data{ type: "application/json" }= initial_notes_data(autocomplete).to_json.html_safe

ee/app/views/groups/contribution_analytics/show.html.haml

@@ -67,7 +67,6 @@
       #js_issues_chart_vue
 
   #js-group-member-contributions{ data: { member_contributions_path: group_contribution_analytics_path(@group, { start_date: @start_date, format: :json }) } }
-  -# haml-lint:disable InlineJavaScript
   %script#js-analytics-data{ type: "application/json" }
     = @data_collector.group_member_contributions_table_data.to_json.html_safe
 - elsif show_promotions?

ee/app/views/projects/blob/_header_file_locks.html.haml

@@ -3,7 +3,6 @@
 
 - return unless project.feature_available?(:file_locks)
 
--# haml-lint:disable InlineJavaScript
 %script#js-file-lock{ type: "application/json" }
   - data = { path: path, toggle_path: toggle_project_path_locks_path(project) }
   = data.to_json.html_safe