Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
17edfc32
Commit
17edfc32
authored
Apr 19, 2021
by
Abdul Wadood
Committed by
Matthias Käppler
Apr 19, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/controllers/admin
parent
6853eeb8
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
7 additions
and
2 deletions
+7
-2
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-2
ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-controllers-admin.yml
...c-empty-lines-after-letitbe-ee-spec-controllers-admin.yml
+5
-0
ee/spec/controllers/admin/geo/projects_controller_spec.rb
ee/spec/controllers/admin/geo/projects_controller_spec.rb
+1
-0
ee/spec/controllers/admin/projects_controller_spec.rb
ee/spec/controllers/admin/projects_controller_spec.rb
+1
-0
No files found.
.rubocop_manual_todo.yml
View file @
17edfc32
...
...
@@ -412,8 +412,6 @@ Rails/TimeZone:
# WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/325836
RSpec/EmptyLineAfterFinalLetItBe
:
Exclude
:
-
ee/spec/controllers/admin/geo/projects_controller_spec.rb
-
ee/spec/controllers/admin/projects_controller_spec.rb
-
ee/spec/controllers/groups/analytics/cycle_analytics/stages_controller_spec.rb
-
ee/spec/controllers/groups/analytics/cycle_analytics/summary_controller_spec.rb
-
ee/spec/controllers/groups/analytics/cycle_analytics/value_streams_controller_spec.rb
...
...
ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-controllers-admin.yml
0 → 100644
View file @
17edfc32
---
title
:
Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/controllers/admin
merge_request
:
58417
author
:
Abdul Wadood @abdulwd
type
:
fixed
ee/spec/controllers/admin/geo/projects_controller_spec.rb
View file @
17edfc32
...
...
@@ -7,6 +7,7 @@ RSpec.describe Admin::Geo::ProjectsController, :geo do
let_it_be
(
:admin
)
{
create
(
:admin
)
}
let_it_be
(
:geo_primary
)
{
create
(
:geo_node
,
:primary
)
}
let
(
:synced_registry
)
{
create
(
:geo_project_registry
,
:synced
)
}
before
do
...
...
ee/spec/controllers/admin/projects_controller_spec.rb
View file @
17edfc32
...
...
@@ -6,6 +6,7 @@ RSpec.describe Admin::ProjectsController, :geo do
include
EE
::
GeoHelpers
let_it_be
(
:geo_primary
)
{
create
(
:geo_node
,
:primary
)
}
let!
(
:project_registry
)
{
create
(
:geo_project_registry
)
}
let
(
:project
)
{
project_registry
.
project
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment