Remove disable_fields_service? completely

Since it always returned `false`, we can safely remove it.

Also removes all `disabled` attributes from form fields
which are now redundant.

app/assets/javascripts/integrations/edit/components/active_toggle.vue

@@ -12,10 +12,6 @@ export default {
       type: Boolean,
       required: true,
     },
-    disabled: {
-      type: Boolean,
-      required: true,
-    },
   },
   data() {
     return {
@@ -41,12 +37,7 @@ export default {
     <div class="form-group row" role="group">
       <label for="service[active]" class="col-form-label col-sm-2">{{ __('Active') }}</label>
       <div class="col-sm-10 pt-1">
-        <gl-toggle
-          v-model="activated"
-          :disabled="disabled"
-          name="service[active]"
-          @change="onToggle"
-        />
+        <gl-toggle v-model="activated" name="service[active]" @change="onToggle" />
       </div>
     </div>
   </div>

app/assets/javascripts/integrations/edit/index.js

@@ -7,10 +7,9 @@ export default el => {
     return null;
   }
 
-  const { showActive: showActiveStr, activated: activatedStr, disabled: disabledStr } = el.dataset;
+  const { showActive: showActiveStr, activated: activatedStr } = el.dataset;
   const showActive = parseBoolean(showActiveStr);
   const activated = parseBoolean(activatedStr);
-  const disabled = parseBoolean(disabledStr);
 
   if (!showActive) {
     return null;
@@ -22,7 +21,6 @@ export default el => {
       return createElement(ActiveToggle, {
         props: {
           initialActivated: activated,
-          disabled,
         },
       });
     },

app/helpers/services_helper.rb

@@ -58,10 +58,6 @@ module ServicesHelper
     end
   end
 
-  def disable_fields_service?(service)
-    !current_controller?('admin/services')
-  end
-
   def scoped_integrations_path
     if @project.present?
       project_settings_integrations_path(@project)

app/views/shared/_field.html.haml

@@ -7,7 +7,6 @@
 - choices = field[:choices]
 - default_choice = field[:default_choice]
 - help = field[:help]
-- disabled = disable_fields_service?(@service)
 
 .form-group.row
   - if type == "password" && value.present?
@@ -16,14 +15,14 @@
     = form.label name, title, class: "col-form-label col-sm-2"
   .col-sm-10
     - if type == 'text'
-      = form.text_field name, class: "form-control", placeholder: placeholder, required: required, disabled: disabled, data: { qa_selector: "#{name.downcase.gsub('\s', '')}_field" }
+      = form.text_field name, class: "form-control", placeholder: placeholder, required: required, data: { qa_selector: "#{name.downcase.gsub('\s', '')}_field" }
     - elsif type == 'textarea'
-      = form.text_area name, rows: 5, class: "form-control", placeholder: placeholder, required: required, disabled: disabled
+      = form.text_area name, rows: 5, class: "form-control", placeholder: placeholder, required: required
     - elsif type == 'checkbox'
-      = form.check_box name, disabled: disabled
+      = form.check_box name
     - elsif type == 'select'
-      = form.select name, options_for_select(choices, value ? value : default_choice), {}, { class: "form-control", disabled: disabled}
+      = form.select name, options_for_select(choices, value ? value : default_choice), {}, { class: "form-control"}
     - elsif type == 'password'
-      = form.password_field name, autocomplete: "new-password", placeholder: placeholder, class: "form-control", required: value.blank? && required, disabled: disabled, data: { qa_selector: "#{name.downcase.gsub('\s', '')}_field" }
+      = form.password_field name, autocomplete: "new-password", placeholder: placeholder, class: "form-control", required: value.blank? && required, data: { qa_selector: "#{name.downcase.gsub('\s', '')}_field" }
     - if help
       %span.form-text.text-muted= help

app/views/shared/_service_settings.html.haml

@@ -8,7 +8,7 @@
       = markdown @service.help
 
 .service-settings
-  .js-vue-integration-settings{ data: { show_active: @service.show_active_box?.to_s, activated: (@service.active || @service.new_record?).to_s, disabled: disable_fields_service?(@service).to_s } }
+  .js-vue-integration-settings{ data: { show_active: @service.show_active_box?.to_s, activated: (@service.active || @service.new_record?).to_s } }
 
   - if @service.configurable_events.present?
     .form-group.row