Merge branch 'leaky-constant-fix-4' into 'master'

Add stub for query recorder spec

See merge request gitlab-org/gitlab!31954

.rubocop.yml

@@ -402,7 +402,6 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb'
     - 'spec/support/shared_contexts/spam_constants.rb'
     - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb'
-    - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb'
     - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb'
     - 'spec/uploaders/records_uploads_spec.rb'
 

changelogs/unreleased/leaky-constant-fix-4.yml

+---
+title: Add class stubs and fix leaky constant alert in query recorder spec
+merge_request: 31954
+author: Rajendra Kadam
+type: fixed

spec/support_specs/helpers/active_record/query_recorder_spec.rb

@@ -3,8 +3,12 @@
 require 'spec_helper'
 
 describe ActiveRecord::QueryRecorder do
-  class TestQueries < ActiveRecord::Base
-    self.table_name = 'schema_migrations'
+  before do
+    stub_const('TestQueries', Class.new(ActiveRecord::Base))
+
+    TestQueries.class_eval do
+      self.table_name = 'schema_migrations'
+    end
   end
 
   describe 'detecting the right number of calls and their origin' do