Merge branch '263408-improve-delete-snippet-test' into 'master'

Improve user_deletes_snippet_spec assertion

See merge request gitlab-org/gitlab!51020

changelogs/unreleased/263408-improve-delete-snippet-test.yml

+---
+title: Improve delete snippet feature spec
+merge_request: 51020
+author: Lee Tickett @leetickett
+type: other

spec/features/projects/snippets/user_deletes_snippet_spec.rb

@@ -21,6 +21,8 @@ RSpec.describe 'Projects > Snippets > User deletes a snippet', :js do
     click_button('Delete snippet')
     wait_for_requests
 
-    expect(page).not_to have_content(snippet.title)
+    # This assertion also confirms we did not end up on an error page
+    expect(page).to have_selector('#new_snippet_link')
+    expect(project.snippets.length).to eq(0)
   end
 end