Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1cd2df17
Commit
1cd2df17
authored
Apr 14, 2021
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix a flaky test by stop using hardcoded ID & name
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
397835f2
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
5 deletions
+7
-5
ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb
...b/gitlab/analytics/cycle_analytics/request_params_spec.rb
+7
-5
No files found.
ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb
View file @
1cd2df17
...
...
@@ -204,11 +204,13 @@ RSpec.describe Gitlab::Analytics::CycleAnalytics::RequestParams do
subject
{
described_class
.
new
(
params
).
to_data_attributes
}
it
{
expect
(
subject
[
:milestone
]).
to
eq
(
'title'
)
}
it
{
expect
(
subject
[
:assignees
]).
to
eq
(
'["username1"]'
)
}
it
{
expect
(
subject
[
:labels
]).
to
eq
(
'["label1","label2"]'
)
}
it
{
expect
(
subject
[
:author
]).
to
eq
(
'author'
)
}
it
{
expect
(
subject
[
:stage
]).
to
eq
(
'{"id":1,"title":"Stage #1"}'
)
}
it
"has the correct attributes"
do
expect
(
subject
[
:milestone
]).
to
eq
(
'title'
)
expect
(
subject
[
:assignees
]).
to
eq
(
'["username1"]'
)
expect
(
subject
[
:labels
]).
to
eq
(
'["label1","label2"]'
)
expect
(
subject
[
:author
]).
to
eq
(
'author'
)
expect
(
subject
[
:stage
]).
to
eq
(
%Q|{"id":
#{
stage
.
id
}
,"title":"
#{
stage
.
name
}
"}|
)
end
end
describe
'sorting params'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment